You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/02 09:23:07 UTC

[GitHub] [maven-resolver] cstamas commented on a diff in pull request #212: [MRESOLVER-282] Drop PartialFile use

cstamas commented on code in PR #212:
URL: https://github.com/apache/maven-resolver/pull/212#discussion_r1011453560


##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/ChecksumValidator.java:
##########
@@ -85,13 +82,12 @@ boolean fetchChecksum( URI remote, File local )
     {
         this.dataFile = dataFile;
         this.checksumAlgorithmFactories = checksumAlgorithmFactories;
-        this.tempFiles = new HashSet<>();
         this.fileProcessor = fileProcessor;
         this.checksumFetcher = checksumFetcher;
         this.checksumPolicy = checksumPolicy;
         this.providedChecksums = providedChecksums;
         this.checksumLocations = checksumLocations;
-        this.checksumFiles = new HashMap<>();
+        this.checksumExpectedValues = new HashMap<>();

Review Comment:
   Yes, that map has checksum Files as keys (their final files, not tmp or so) and values are the "expected" ones as Strings, no more Object and so on....



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org