[jira] [Commented] (HBASE-10049) Small improvments in region_mover.rb

["Jean-Marc Spaggiari (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851979#comment-13851979 ] 

Jean-Marc Spaggiari commented on HBASE-10049:
---------------------------------------------

Sorry to come late on this ;)
What is the reason behind the 20 seconds delay? Just before this delay there is a check to wait for the server to be online. So delay should not be required?

Also, adding a log in the move method make the application VERY verbose, doubling the output. Is that really useful? 

I'm working on 8803 where I might have to remove some of those improvements to get the output readable, but before doing that I want to understand why it has been added so I can take that into consideration.

Thanks.

> Small improvments in region_mover.rb
> ------------------------------------
>
>                 Key: HBASE-10049
>                 URL: https://issues.apache.org/jira/browse/HBASE-10049
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liu Shaohui
>            Assignee: Liu Shaohui
>            Priority: Minor
>             Fix For: 0.98.0, 0.94.15, 0.96.2
>
>         Attachments: HBASE-10049-0.94-v1.diff, HBASE-10049-0.94-v2.diff, HBASE-10049-trunk-v1.diff
>
>
> We use region_mover.rb in the graceful upgrade of hbase cluster.
> Here are small improvements.
> a. remove the table.close(), because  the htable could be reused.
> b. Add more info in the log of moving region.
> c. Add 20s sleep in load command to make sure the rs finished initialization of rpc server. There is a time gap between rs startup report and rpc server initialization.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)