[GitHub] [metron] sardell commented on a change in pull request #1460: METRON-2179: Make navigation in both UIs consistent

[GitBox <gi...@apache.org>]

sardell commented on a change in pull request #1460: METRON-2179: Make navigation in both UIs consistent
URL: https://github.com/apache/metron/pull/1460#discussion_r303000570
 
 

 ##########
 File path: metron-interface/metron-config/src/app/service/sensor-indexing-config.service.spec.ts
 ##########
 @@ -101,12 +101,10 @@ describe('SensorIndexingConfigService', () => {
     });
 
     it('deleteSensorEnrichments', () => {
-      sensorIndexingConfigService.deleteSensorIndexingConfig('squid').subscribe(
-        result => {
-          expect(result.status).toEqual(200);
 
 Review comment:
   I noticed this test because of a failing Type Error. However, because we are mocking the backend and injecting the response, this test is just checking what we are injecting and is unnecessary. As a result, I removed it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services