You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Angela Schreiber (Jira)" <ji...@apache.org> on 2020/08/13 15:47:00 UTC

[jira] [Updated] (OAK-9178) PasswordHistory.updatePasswordHistory may return false status

     [ https://issues.apache.org/jira/browse/OAK-9178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Angela Schreiber updated OAK-9178:
----------------------------------
    Description: 
{{PasswordHistory.updatePasswordHistory}} is defined to return true if:

{code}
returns true if the history is enabled, the new password is not included in the history and the history was successfully updated; false otherwise.
{code}

however, if the feature is enabled and {{shiftPasswordHistory}} doesn't perform the update, the method still returns true. instead {{shiftPasswordHistory}} should report if the history was updated and the return value should be respected by {{PasswordHistory.updatePasswordHistory}}.

  was:
{{PasswordHistory.updatePasswordHistory}} is defined to return true if:

??returns {@code true} if the history is enabled, the new password is not
     * included in the history and the history was successfully updated;
     * {@code false} otherwise.??

however, if the feature is enabled and {{shiftPasswordHistory}} doesn't perform the update, the method still returns true. instead {{shiftPasswordHistory}} should report if the history was updated and the return value should be respected by {{PasswordHistory.updatePasswordHistory}}.


> PasswordHistory.updatePasswordHistory may return false status
> -------------------------------------------------------------
>
>                 Key: OAK-9178
>                 URL: https://issues.apache.org/jira/browse/OAK-9178
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, security
>            Reporter: Angela Schreiber
>            Priority: Minor
>
> {{PasswordHistory.updatePasswordHistory}} is defined to return true if:
> {code}
> returns true if the history is enabled, the new password is not included in the history and the history was successfully updated; false otherwise.
> {code}
> however, if the feature is enabled and {{shiftPasswordHistory}} doesn't perform the update, the method still returns true. instead {{shiftPasswordHistory}} should report if the history was updated and the return value should be respected by {{PasswordHistory.updatePasswordHistory}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)