You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/02/15 10:19:43 UTC
[GitHub] [avro] KyleSchoonover opened a new pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
KyleSchoonover opened a new pull request #1534:
URL: https://github.com/apache/avro/pull/1534
Documenting the C# styling guidelines as they are implemented in the .editorconfig
### Jira
- [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3384
### Tests
- [ ] My PR does not need testing for this extremely good reason: documentation
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
❌ Deploy Preview for *avro-website-preview* failed.
🔨 Explore the source changes: e8d5bde2364c528af2fc9448f9d7a3d37eb958ae
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206defbca01b200071f1ff5](https://app.netlify.com/sites/avro-website-preview/deploys/6206defbca01b200071f1ff5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba edited a comment on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
RyanSkraba edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040096964
Hello, I just want to mention that I haven't had a lot of extra time recently, and I haven't been following this conversation closely! @zcsizmadia I saw you mentioned that we might be waiting on finalizing this specific PR. Are you both satisfied with these initial settings, and should it be cherry-picked to branch-1.11 or wait for the next major release?
(N.B. Misclicked for close/reopening! Sorry for the noise)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040549856
The reason I added the override sectio to the ruleset file was, that we can diverge fr from the "stanbdard" ruleset by overriding them in that section. https://github.com/apache/avro/blob/master/lang/csharp/CodeAnalysis.src.globalconfig#L1581
It is easier to follow what work can be done in the future, and add comments if certain messages should be forced to be overwritten for whatever reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040542379
My suggestion would be that PRs are grouped around the compiler warning. Eg. 1 PR fixes 1 particular compiler warning. In that case thereviewer has an easier job, just focusing one kind of change. If the PR is "too big" it might have to be split into multiple ones. I am not sure what is a too big PR btw.
Compiler codes to fix:
IDE0001
IDE0002
IDE0003
IDE0004
IDE0005
IDE0034
IDE0036
IDE0040
IDE0044
IDE0049
IDE0055
IDE0059
IDE0071
IDE0076
IDE0078
IDE0079
Compiler codes to turn off for now:
IDE0017
IDE0018
IDE0019
IDE0028
IDE0029
IDE0041
IDE0038
IDE0045
IDE0046
IDE0066
In the PRs the main objective should be that it is as reviewer friendly is possible, so the diff is as easily readable as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1051080595
Just for reference
- [Google C# Style guidelines](https://google.github.io/styleguide/csharp-style.html)
- [Dotnet runtime Style guidelines](https://github.com/dotnet/runtime/blob/main/docs/coding-guidelines/coding-style.md)
I'm going to consider these "mature" styling practices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040697094
That language feature is not supported, unless we override the language version in the csproj file. which IMO is not ideal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040096964
Hello, I just want to mention that I haven't had a lot of extra time recently, and I haven't been following this conversation closely! @zcsizmadia I saw you mentioned that we might be waiting on finalizing this specific PR. Are you both satisfied with these initial settings, and should it be cherry-picked to branch-1.11 or wait for the next major release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
👷 Deploy Preview for *avro-website-preview* processing.
🔨 Explore the source changes: e8d5bde2364c528af2fc9448f9d7a3d37eb958ae
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206defbca01b200071f1ff5](https://app.netlify.com/sites/avro-website-preview/deploys/6206defbca01b200071f1ff5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] commented on pull request #1534: draft: AVRO-3384 Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
👷 Deploy Preview for *avro-website-preview* processing.
🔨 Explore the source changes: 2b25fed1fb0eddef472bae3bf3716a5b28cfc011
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/62058a1d62d5730007e85b55](https://app.netlify.com/sites/avro-website-preview/deploys/62058a1d62d5730007e85b55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1534: draft: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1036518804
I really do like the way you tweak the editorconfig and having the styling md file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia edited a comment on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040542379
My suggestion would be that PRs are grouped around the compiler warning. Eg. 1 PR fixes 1 particular compiler warning. In that case thereviewer has an easier job, just focusing one kind of change. If the PR is "too big" it might have to be split into multiple ones. I am not sure what is a too big PR btw.
Compiler codes to fix:
IDE0001
IDE0002
IDE0003
IDE0004
IDE0005
IDE0034
IDE0036
IDE0040
IDE0044
IDE0049
IDE0055
IDE0059
IDE0071
IDE0076
IDE0078
IDE0079
Compiler codes to turn off for now:
IDE0008
IDE0017
IDE0018
IDE0019
IDE0028
IDE0029
IDE0041
IDE0038
IDE0045
IDE0046
IDE0066
In the PRs the main objective should be that it is as reviewer friendly as possible, so the diff is as easily readable as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: draft: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
❌ Deploy Preview for *avro-website-preview* failed.
🔨 Explore the source changes: 2190042cf59e8b889ce563f8405ca15794e31b86
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/62069d4be1de890008d57c9b](https://app.netlify.com/sites/avro-website-preview/deploys/62069d4be1de890008d57c9b)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1534: draft: AVRO-3384 Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035677171
@KyleSchoonover Do you think we should include the non-formatting related coding styles and the preferred usage of language features in this file? IMO that might make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040490847
Here's your list of things to fix.
`IDE0001:Name can be simplified. 74`
`IDE0002:Name can be simplified. 117`
`IDE0003:Name can be simplified. 262`
`IDE0004:Cast is redundant. 29`
`IDE0005:Using directive is unnecessary. 39`
`IDE0017:Object initialization can be simplified 44`
`IDE0018:Variable declaration can be inlined 42`
`IDE0019:Use pattern matching 46`
`IDE0020:Use pattern matching 6`
`IDE0028:Collection initialization can be simplified 15`
`IDE0029:Null check can be simplified 4`
`IDE0034:'default' expression can be simplified 2`
`IDE0036:Modifiers are not ordered 2`
`IDE0038:Use pattern matching 12`
`IDE0040:Accessibility modifiers required 35`
`IDE0041:Null check can be simplified 6`
`IDE0044:Make field readonly 48`
`IDE0045:'if' statement can be simplified 19`
`IDE0046:'if' statement can be simplified 100`
`IDE0049:Name can be simplified. 51`
`IDE0055:Fix formatting 1054`
`IDE0059:Unnecessary assignment of a value to 'enumType' 2`
`IDE0059:Unnecessary assignment of a value to 'obj' 2`
`IDE0059:Unnecessary assignment of a value to 'rc' 3`
`IDE0059:Unnecessary assignment of a value to 'reader' 2`
`IDE0059:Unnecessary assignment of a value to 'recordtype' 2`
`IDE0059:Unnecessary assignment of a value to 's' 4`
`IDE0059:Unnecessary assignment of a value to 'schema' 2`
`IDE0066:Use 'switch' expression 12`
`IDE0071:Interpolation can be simplified 10`
`IDE0076:Invalid or missing target for 'SuppressMessageAttribute' 2`
`IDE0078:Use pattern matching 2`
`IDE0079:Remove unnecessary suppression 52`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1073347928
What is the current state of the Intellisense warning and info messages? If there are still warnings and info messages, are you planning to leave them like that or override them in the styling definition files and address them in different tickets? e.g. each ticket for each code warning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1082636595
> What is the current state of the Intellisense warning and info messages? If there are still warnings and info messages, are you planning to leave them like that or override them in the styling definition files and address them in different tickets? e.g. each ticket for each code warning?
Let's talk about implementation on slack. This is just documentation and additions to the editorconfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040309725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: draft: AVRO-3384 Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
❌ Deploy Preview for *avro-website-preview* failed.
🔨 Explore the source changes: 2b25fed1fb0eddef472bae3bf3716a5b28cfc011
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/62058a1d62d5730007e85b55](https://app.netlify.com/sites/avro-website-preview/deploys/62058a1d62d5730007e85b55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1534: draft: AVRO-3384 Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035686406
I was debating the same thing. Let me think of reasons not to and if I don't come up with a good reason than yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040678358
This is probably the only rule I don't like
csharp_style_prefer_switch_expression = true:suggestion
All the other rules as they are set I agree with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: draft: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
👷 Deploy Preview for *avro-website-preview* processing.
🔨 Explore the source changes: c7535da091fe74e816f31928b76b9fd9c428c648
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/62069febf8b1a50008184bda](https://app.netlify.com/sites/avro-website-preview/deploys/62069febf8b1a50008184bda)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: draft: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
👷 Deploy Preview for *avro-website-preview* processing.
🔨 Explore the source changes: 62e05adcd84b2caacf6ae9aa8cfc0241542dca37
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206bee23ab8a60008caa258](https://app.netlify.com/sites/avro-website-preview/deploys/6206bee23ab8a60008caa258)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1043670337
This is what I have left in my local. Let me know when we are ready to move forward. I have everything up to date and ready for merge requests.
CS0618'SchemaNormalization.Empty64' is obsolete: 'This will be removed from the public API in a future version.' 6
IDE0001Name can be simplified. 2
IDE0002Name can be simplified. 1
IDE0004Cast is redundant. 2
IDE0036Modifiers are not ordered 1
IDE0045'if' statement can be simplified 4
IDE0046'if' statement can be simplified 4
IDE0054Use compound assignment 1
IDE0055Fix formatting 11
IDE0075Conditional expression can be simplified 6
IDE1006Naming rule violation: Missing prefix: 'I' 11
IDE1006Naming rule violation: These words must begin with upper case characters: addName 1
IDE1006Naming rule violation: These words must begin with upper case characters: addNamespace 1
IDE1006Naming rule violation: These words must begin with upper case characters: areEqual 3
IDE1006Naming rule violation: These words must begin with upper case characters: createDocComment 1
IDE1006Naming rule violation: These words must begin with upper case characters: createSchemaField 1
IDE1006Naming rule violation: These words must begin with upper case characters: findBranch 1
IDE1006Naming rule violation: These words must begin with upper case characters: generateNames 2
IDE1006Naming rule violation: These words must begin with upper case characters: getHashCode 2
IDE1006Naming rule violation: These words must begin with upper case characters: getNullableType 1
IDE1006Naming rule violation: These words must begin with upper case characters: getTargetType 1
IDE1006Naming rule violation: These words must begin with upper case characters: getType 1
IDE1006Naming rule violation: These words must begin with upper case characters: processEnum 1
IDE1006Naming rule violation: These words must begin with upper case characters: processFixed 1
IDE1006Naming rule violation: These words must begin with upper case characters: processInterface 1
IDE1006Naming rule violation: These words must begin with upper case characters: processProtocols 1
IDE1006Naming rule violation: These words must begin with upper case characters: processRecord 1
IDE1006Naming rule violation: These words must begin with upper case characters: processSchemas 1
IDE1006Naming rule violation: These words must begin with upper case characters: value 1
IDE1006Naming rule violation: These words must begin with upper case characters: writeIfNotNull 1
IDE1006Naming rule violation: These words must begin with upper case characters: writeIfNotNullOrEmpty 1
IDE1006Naming rule violation: These words must begin with upper case characters: writeJson 2
Grand Total 75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia edited a comment on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040542379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040309725
There are 2k+ warnings and messages caused by Intellisense (~~30 different compiler codes). IMO the next step in this ticket should be:
1. Identify which message codes should be ignored and which should be fixed
2. Identify the compiler messages which should be turned on (currently off) if any
3. Prioritize the compiler message codes selected in #1 and #2. Complexity, risk of breaking change, potential performance, better documentation, readablity and some others should be the factors when deciding about the priorities.
Discussing the items in #1 IMO is important, because a balance has to be found between having a mature codebase, personal preferences and best practices.
Since there are potentially a lot of code changes, a good initial strategy should be defined how the changes (PRs) are made (e.g. to ensure the review process is as easy as possible)
I dont think any of these changes are a amust have in any of the upcoming releases (unless some bugs are discovered during the changes and code reviews).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1044976823
I do not disagree on the fact that most likely (and I empasize most likely) are non-breaking changes adn the unit tests are passing asw ell. Which is great. However my personal view s that, since this is a mature library, the risk appetite for massive reworks are very low. That is the reason I my suggestion were focusing on "easy" and trivial changes.
However I dont think it is a reasonable expectation from a reviewer, that they should analyze the code and getting involved in it, simply because the massive size of the code base (in theory most likely I agree with you).
I think you need @martin-g or @RyanSkraba input on this, I feel we approach this from a totally different agle and of course I might be dead wrong ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1534: draft: AVRO-3384 Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035567056
@zcsizmadia @martin-g @RyanSkraba This is just an initial draft, but is this what you are looking for? And by no means is this complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: draft: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
👷 Deploy Preview for *avro-website-preview* processing.
🔨 Explore the source changes: 8057598beb9cd3aa6d8d37af4a7c0eff74e47cd7
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206b09f7891ed0008602ab7](https://app.netlify.com/sites/avro-website-preview/deploys/6206b09f7891ed0008602ab7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: draft: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
❌ Deploy Preview for *avro-website-preview* failed.
🔨 Explore the source changes: 9ffea5a098ac88f32fd19a335264a4697930d5e1
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206b013f442d4000749ee33](https://app.netlify.com/sites/avro-website-preview/deploys/6206b013f442d4000749ee33)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: draft: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
❌ Deploy Preview for *avro-website-preview* failed.
🔨 Explore the source changes: d3c7aa24a0ff1ee9b5dcaf2cdcb7ad0e7a9fdd4d
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206b850039f0b0008f76a56](https://app.netlify.com/sites/avro-website-preview/deploys/6206b850039f0b0008f76a56)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1036670522
It looks really nice:
1. How much is it aligned as of now with most of the formatting coding style?
2. I saw somewhere that `file_header_template` can be defined by a placeholder file. If that is possible it would be really sweet to have the license info in that file. I think the new file in VSCode honors it, so when you create a file, the header+template is added automatically, but not 100% sure about that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1036795014
1. We've still got a bunch of fixes, but all in all it's fairly minor since I started it.
2. I was actually planning on doing that. Just want to make sure it formats like how we want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1036798059
Also, I'm thinking Code Quality should be it's own thing, since it would involve implementing Code Analysis rules again. And we can call the rules out in the .editorconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: draft: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
👷 Deploy Preview for *avro-website-preview* processing.
🔨 Explore the source changes: 2190042cf59e8b889ce563f8405ca15794e31b86
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/62069d4be1de890008d57c9b](https://app.netlify.com/sites/avro-website-preview/deploys/62069d4be1de890008d57c9b)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia edited a comment on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040542379
My suggestion would be that PRs are grouped around the compiler warning. Eg. 1 PR fixes 1 particular compiler warning. In that case thereviewer has an easier job, just focusing one kind of change. If the PR is "too big" it might have to be split into multiple ones. I am not sure what is a too big PR btw.
Compiler codes to fix:
IDE0001
IDE0002
IDE0003
IDE0004
IDE0005
IDE0034
IDE0036
IDE0040
IDE0044
IDE0049
IDE0055
IDE0059
IDE0071
IDE0076
IDE0078
IDE0079
Compiler codes to turn off for now:
IDE0017
IDE0018
IDE0019
IDE0028
IDE0029
IDE0041
IDE0038
IDE0045
IDE0046
IDE0066
In the PRs the main objective should be that it is as reviewer friendly as possible, so the diff is as easily readable as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1036647057
@zcsizmadia I would call this the first stab. There are some additional miscellaneous things that I want to add, but this should allow us to quickly review a lot of the rules that we have the options to configure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
❌ Deploy Preview for *avro-website-preview* failed.
🔨 Explore the source changes: 99f596f9892772e581fc9eb955adfc2c9bd85a37
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206e7a0ed8d810008af9428](https://app.netlify.com/sites/avro-website-preview/deploys/6206e7a0ed8d810008af9428)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: draft: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
❌ Deploy Preview for *avro-website-preview* failed.
🔨 Explore the source changes: 62e05adcd84b2caacf6ae9aa8cfc0241542dca37
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206bee23ab8a60008caa258](https://app.netlify.com/sites/avro-website-preview/deploys/6206bee23ab8a60008caa258)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1083035821
Sounds good. My question was related to your question if the PR was ready for approval or not. SHould we convert this to draft?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia edited a comment on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040697094
The switch expression language feature is not supported, unless we override the language version in the csproj file. which IMO is not ideal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba closed pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
RyanSkraba closed pull request #1534:
URL: https://github.com/apache/avro/pull/1534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
👷 Deploy Preview for *avro-website-preview* processing.
🔨 Explore the source changes: 99f596f9892772e581fc9eb955adfc2c9bd85a37
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206e7a0ed8d810008af9428](https://app.netlify.com/sites/avro-website-preview/deploys/6206e7a0ed8d810008af9428)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: draft: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
👷 Deploy Preview for *avro-website-preview* processing.
🔨 Explore the source changes: d3c7aa24a0ff1ee9b5dcaf2cdcb7ad0e7a9fdd4d
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206b850039f0b0008f76a56](https://app.netlify.com/sites/avro-website-preview/deploys/6206b850039f0b0008f76a56)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
👷 Deploy Preview for *avro-website-preview* processing.
🔨 Explore the source changes: 8c9e9c3fdbc77df58007d723a651795b8ad789aa
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206fba5354aa30007d80d88](https://app.netlify.com/sites/avro-website-preview/deploys/6206fba5354aa30007d80d88)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: draft: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
❌ Deploy Preview for *avro-website-preview* failed.
🔨 Explore the source changes: c7535da091fe74e816f31928b76b9fd9c428c648
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/62069febf8b1a50008184bda](https://app.netlify.com/sites/avro-website-preview/deploys/62069febf8b1a50008184bda)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: draft: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
👷 Deploy Preview for *avro-website-preview* processing.
🔨 Explore the source changes: 9ffea5a098ac88f32fd19a335264a4697930d5e1
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206b013f442d4000749ee33](https://app.netlify.com/sites/avro-website-preview/deploys/6206b013f442d4000749ee33)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: draft: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
❌ Deploy Preview for *avro-website-preview* failed.
🔨 Explore the source changes: 8057598beb9cd3aa6d8d37af4a7c0eff74e47cd7
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206b09f7891ed0008602ab7](https://app.netlify.com/sites/avro-website-preview/deploys/6206b09f7891ed0008602ab7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1044959521
As for 1, 2 and 3 they are all defined in the editorconfig. Additionally, I only changed private name, which should affect nothing on the public API. To implement these styling guidelines I find it best to just get it over with. Otherwise you take something that can be done in a matter of days and drag it out for months. The local tests pass, as well as this code has been ported over to my companies version of the library and I get the same results on over 6000 schemas. These are all non breaking changes, and do not change the functionality of the library.
I find it best to treat these as if they were completely new files. Which should make those who review them more involved and informed what the code base does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035563861
❌ Deploy Preview for *avro-website-preview* failed.
🔨 Explore the source changes: 8c9e9c3fdbc77df58007d723a651795b8ad789aa
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206fba5354aa30007d80d88](https://app.netlify.com/sites/avro-website-preview/deploys/6206fba5354aa30007d80d88)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1534: draft: AVRO-3384 Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1035673294
Niiiice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1043765928
1. The pending PRs still have if statement changes, which I have concern about, since it complicates the review process
2. Expression bodied members are used for ne readablity gain. As I mentioned earlier we should discuss basic guidelines about that
3. I dont think the variables were supposed to be renamed, which causes the diffs being more complex.
4. ...
As I mentioned eearlier, createing the PRs should have been started after the guidelines are set and we agree how we proceed. This would make sure that we respect your time and the reviewers time as well. The concern is not that it cannot be reviewed, but the volume of the review will be significant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba closed pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
RyanSkraba closed pull request #1534:
URL: https://github.com/apache/avro/pull/1534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040096964
Hello, I just want to mention that I haven't had a lot of extra time recently, and I haven't been following this conversation closely! @zcsizmadia I saw you mentioned that we might be waiting on finalizing this specific PR. Are you both satisfied with these initial settings, and should it be cherry-picked to branch-1.11 or wait for the next major release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040616372
@KyleSchoonover I think the use of expression-bodied members should be discussed as well.
My suggestion would be to wait with any style related PRs until we discuss the guidelines first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba edited a comment on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
RyanSkraba edited a comment on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040096964
Hello, I just want to mention that I haven't had a lot of extra time recently, and I haven't been following this conversation closely! @zcsizmadia I saw you mentioned that we might be waiting on finalizing this specific PR. Are you both satisfied with these initial settings, and should it be cherry-picked to branch-1.11 or wait for the next major release?
(N.B. Misclicked for close/reopening! Sorry for the noise)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1040490847
Here's your list of things to fix.
`IDE0001:Name can be simplified. 74`
`IDE0002:Name can be simplified. 117`
`IDE0003:Name can be simplified. 262`
`IDE0004:Cast is redundant. 29`
`IDE0005:Using directive is unnecessary. 39`
`IDE0017:Object initialization can be simplified 44`
`IDE0018:Variable declaration can be inlined 42`
`IDE0019:Use pattern matching 46`
`IDE0020:Use pattern matching 6`
`IDE0028:Collection initialization can be simplified 15`
`IDE0029:Null check can be simplified 4`
`IDE0034:'default' expression can be simplified 2`
`IDE0036:Modifiers are not ordered 2`
`IDE0038:Use pattern matching 12`
`IDE0040:Accessibility modifiers required 35`
`IDE0041:Null check can be simplified 6`
`IDE0044:Make field readonly 48`
`IDE0045:'if' statement can be simplified 19`
`IDE0046:'if' statement can be simplified 100`
`IDE0049:Name can be simplified. 51`
`IDE0055:Fix formatting 1054`
`IDE0059:Unnecessary assignment of a value to 'enumType' 2`
`IDE0059:Unnecessary assignment of a value to 'obj' 2`
`IDE0059:Unnecessary assignment of a value to 'rc' 3`
`IDE0059:Unnecessary assignment of a value to 'reader' 2`
`IDE0059:Unnecessary assignment of a value to 'recordtype' 2`
`IDE0059:Unnecessary assignment of a value to 's' 4`
`IDE0059:Unnecessary assignment of a value to 'schema' 2`
`IDE0066:Use 'switch' expression 12`
`IDE0071:Interpolation can be simplified 10`
`IDE0076:Invalid or missing target for 'SuppressMessageAttribute' 2`
`IDE0078:Use pattern matching 2`
`IDE0079:Remove unnecessary suppression 52`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1534: AVRO-3384: Define C# Coding Style Guidelines
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1069596603
@martin-g and @zcsizmadia are there any changes that we want to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org