You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/01/09 08:35:19 UTC
[GitHub] [systemds] juulez opened a new pull request #1149: builtIn outlierByArima function
juulez opened a new pull request #1149:
URL: https://github.com/apache/systemds/pull/1149
added the builtIn outlierByArima function, which focuses on the AR part
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] asfgit closed pull request #1149: builtIn outlierByArima function
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1149:
URL: https://github.com/apache/systemds/pull/1149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1149: builtIn outlierByArima function
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1149:
URL: https://github.com/apache/systemds/pull/1149#issuecomment-757376808
LGTM. That's awesome - thanks for the patch @juulez. During the merge, I only made some minor tweaks regarding formatting and warnings, and changed `(rowMaxs(outlierFilter) == 0)` to `(outlierFilter == 0)` as this filter is always a column vector (just for readability as the compiler would anyway simplify this).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] asfgit closed pull request #1149: builtIn outlierByArima function
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1149:
URL: https://github.com/apache/systemds/pull/1149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1149: builtIn outlierByArima function
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1149:
URL: https://github.com/apache/systemds/pull/1149#issuecomment-757376808
LGTM. That's awesome - thanks for the patch @juulez. During the merge, I only made some minor tweaks regarding formatting and warnings, and changed `(rowMaxs(outlierFilter) == 0)` to `(outlierFilter == 0)` as this filter is always a column vector (just for readability as the compiler would anyway simplify this).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org