You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/08/14 18:41:29 UTC
[GitHub] [accumulo] milleruntime opened a new pull request #1687: Update commons-* libraries
milleruntime opened a new pull request #1687:
URL: https://github.com/apache/accumulo/pull/1687
* Update commons-cli to 1.4
* Update commons-codec to 1.14
* Update commons-io to 2.7
* Update commons-lang to 2.6
* Update commons-logging to 1.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1687: Update commons-* libraries
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1687:
URL: https://github.com/apache/accumulo/pull/1687#issuecomment-674222583
As a test, I'm trying a full IT build for this PR on the new ASF Jenkins server at https://ci-builds.apache.org/job/Accumulo/job/PR-builder/1/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1687: Update commons-* libraries
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1687:
URL: https://github.com/apache/accumulo/pull/1687#issuecomment-674215626
Some of this will apply to the 2.1/main branch, because that is currently using commons-io 2.6. Also, be careful in the merge forward, because commons-lang has been superseded by commons-lang3 in the main branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1687: Update commons-* libraries
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1687:
URL: https://github.com/apache/accumulo/pull/1687#issuecomment-675669983
As it turns out, I did not test these changes against our Hadoop 3 profile, and it looks like I'm going to have to revert some, or all, of these changes in 1.10. I'm working through this in #1688
At the core of the issue, is that we need commons-vfs2, guava, hadoop, and hadoop-minicluster to all be happy across both Hadoop 2 and Hadoop 3 profiles, as long as we support both. We should have more flexibility with Hadoop 3, because it has shaded deps. However, hadoop-minicluster isn't shaded, and requires a specific version of Guava, and changing that makes vfs2 unhappy, which needs to mesh with both hadoop-minicluster and vfs2.
I suspect that most of these are fine, except for `commons-io`, but will follow-up on #1688 once I get everything working there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii edited a comment on pull request #1687: Update commons-* libraries
Posted by GitBox <gi...@apache.org>.
ctubbsii edited a comment on pull request #1687:
URL: https://github.com/apache/accumulo/pull/1687#issuecomment-675669983
As it turns out, I did not test these changes against our Hadoop 3 profile, and it looks like I'm going to have to revert some, or all, of these changes in 1.10. I'm working through this in #1688
At the core of the issue, is that we need commons-vfs2, guava, hadoop, and hadoop-minicluster to all be happy across both Hadoop 2 and Hadoop 3 profiles, as long as we support both. We should have more flexibility with Hadoop 3, because it has shaded deps. However, hadoop-minicluster isn't shaded, and requires a specific version of Guava, and changing that makes vfs2 unhappy, and guava needs to mesh with both hadoop-minicluster and vfs2.
I think ultimately, it comes down to the fact that vfs2 is unhappy with one of the updates here, and that's cascading to the other stuff. I suspect it is `commons-io`, but will follow-up on #1688 once I get everything working there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #1687: Update commons-* libraries
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1687:
URL: https://github.com/apache/accumulo/pull/1687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org