You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/03/02 11:19:59 UTC
[GitHub] jixuan1989 commented on issue #83: [IOTDB-31] Set the float
precision of data in memtable
jixuan1989 commented on issue #83: [IOTDB-31] Set the float precision of data in memtable
URL: https://github.com/apache/incubator-iotdb/pull/83#issuecomment-468911521
In this PR, I replace many parameters' declaration `TimeValueSortor` with `ReadOnlyMemChunk`, because the owners of these parameters never receive a `TimeValueSortor` instance which is not `ReadOnlyMemChunk`.
At this time, using a parent interface is not quite good, because you will lose many features that a child class has.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services