You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by GitBox <gi...@apache.org> on 2020/01/07 14:27:57 UTC
[GitHub] [jena] afs opened a new pull request #666: JENA-1811: Diuspatch on
Content-type. Accumulated code and comment cleanup.
afs opened a new pull request #666: JENA-1811: Diuspatch on Content-type. Accumulated code and comment cleanup.
URL: https://github.com/apache/jena/pull/666
Deprecation of DatasetAccessor etc (Use RDFConnection).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] afs commented on a change in pull request #666: JENA-1811:
Dispatch on Content-Type. Accumulated code and comment cleanup.
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #666: JENA-1811: Dispatch on Content-Type. Accumulated code and comment cleanup.
URL: https://github.com/apache/jena/pull/666#discussion_r364143738
##########
File path: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/auth/Auth.java
##########
@@ -103,4 +104,20 @@ public static boolean allow(String user, AuthPolicy policy, Runnable notAllowed)
notAllowed.run();
return false;
}
+
+ /**
+ * Calculate the value of the "Authentication" HTTP header for basic auth. Basic
+ * auth is not secure when used over HTTP (the password can be extracted). Use
+ * with HTTPS is better.
+ * <p>
+ * Unlike digest auth, basic auth can be setup without an extra round trip to the
+ * server, making it easier for scripts where teh body is not replayable.
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] kinow commented on a change in pull request #666: JENA-1811:
Dispatch on Content-Type. Accumulated code and comment cleanup.
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #666: JENA-1811: Dispatch on Content-Type. Accumulated code and comment cleanup.
URL: https://github.com/apache/jena/pull/666#discussion_r364094754
##########
File path: jena-arq/src/main/java/org/apache/jena/atlas/web/TypedInputStream.java
##########
@@ -47,11 +43,11 @@ private TypedInputStream(InputStream in)
public TypedInputStream(InputStream in, String contentType)
{ this(in, ContentType.create(contentType), null) ; }
- public TypedInputStream(InputStream in, String mediaType, String charset)
- { this(in, mediaType, charset, null) ; }
-
- public TypedInputStream(InputStream in, String mediaType, String charset, String baseURI)
- { this(in, ContentType.create(mediaType, charset), baseURI) ; }
+// public TypedInputStream(InputStream in, String mediaType, String charset)
+// { this(in, mediaType, charset, null) ; }
+//
+// public TypedInputStream(InputStream in, String mediaType, String charset, String baseURI)
+// { this(in, ContentType.create(mediaType, charset), baseURI) ; }
Review comment:
Maybe we can delete this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] kinow commented on a change in pull request #666: JENA-1811:
Dispatch on Content-Type. Accumulated code and comment cleanup.
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #666: JENA-1811: Dispatch on Content-Type. Accumulated code and comment cleanup.
URL: https://github.com/apache/jena/pull/666#discussion_r364095472
##########
File path: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/auth/Auth.java
##########
@@ -103,4 +104,20 @@ public static boolean allow(String user, AuthPolicy policy, Runnable notAllowed)
notAllowed.run();
return false;
}
+
+ /**
+ * Calculate the value of the "Authentication" HTTP header for basic auth. Basic
+ * auth is not secure when used over HTTP (the password can be extracted). Use
+ * with HTTPS is better.
+ * <p>
+ * Unlike digest auth, basic auth can be setup without an extra round trip to the
+ * server, making it easier for scripts where teh body is not replayable.
Review comment:
s/teh/the (I think Java 8+ javadoc is stricter and requires the closing `</p>`, unless we are passing those args to reduce strictness during build)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] afs merged pull request #666: JENA-1811: Dispatch on
Content-Type. Accumulated code and comment cleanup.
Posted by GitBox <gi...@apache.org>.
afs merged pull request #666: JENA-1811: Dispatch on Content-Type. Accumulated code and comment cleanup.
URL: https://github.com/apache/jena/pull/666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] afs commented on a change in pull request #666: JENA-1811:
Dispatch on Content-Type. Accumulated code and comment cleanup.
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #666: JENA-1811: Dispatch on Content-Type. Accumulated code and comment cleanup.
URL: https://github.com/apache/jena/pull/666#discussion_r364143722
##########
File path: jena-rdfconnection/src/main/java/org/apache/jena/rdfconnection/examples/RDFConnectionExample6.java
##########
@@ -40,4 +40,3 @@ public static void main(String ...args) {
}
}
}
-
Review comment:
Git copes either way (I think). These example changes are removing an extra blank line. It was "}\n\n".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] afs commented on a change in pull request #666: JENA-1811:
Dispatch on Content-Type. Accumulated code and comment cleanup.
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #666: JENA-1811: Dispatch on Content-Type. Accumulated code and comment cleanup.
URL: https://github.com/apache/jena/pull/666#discussion_r364147314
##########
File path: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/auth/Auth.java
##########
@@ -103,4 +104,20 @@ public static boolean allow(String user, AuthPolicy policy, Runnable notAllowed)
notAllowed.run();
return false;
}
+
+ /**
+ * Calculate the value of the "Authentication" HTTP header for basic auth. Basic
+ * auth is not secure when used over HTTP (the password can be extracted). Use
+ * with HTTPS is better.
+ * <p>
+ * Unlike digest auth, basic auth can be setup without an extra round trip to the
+ * server, making it easier for scripts where teh body is not replayable.
Review comment:
Thanks for raising this. I can't find a definitive answer by searching the web.
Not sure about the `<p>`. It is legal HTML (not xHTML). I don't get a warning/error in Eclipse. The POM has `<doclint>none</doclint>` and given the scale and age of Jena, other places will have no closing `</p>`.
Elsewhere, I have projects using Java11 and no special configuration of the javadoc plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] kinow commented on a change in pull request #666: JENA-1811:
Dispatch on Content-Type. Accumulated code and comment cleanup.
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #666: JENA-1811: Dispatch on Content-Type. Accumulated code and comment cleanup.
URL: https://github.com/apache/jena/pull/666#discussion_r364096188
##########
File path: jena-rdfconnection/src/main/java/org/apache/jena/rdfconnection/examples/RDFConnectionExample6.java
##########
@@ -40,4 +40,3 @@ public static void main(String ...args) {
}
}
}
-
Review comment:
I thought git asked for this extra newline at the end of the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] afs commented on a change in pull request #666: JENA-1811:
Dispatch on Content-Type. Accumulated code and comment cleanup.
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #666: JENA-1811: Dispatch on Content-Type. Accumulated code and comment cleanup.
URL: https://github.com/apache/jena/pull/666#discussion_r364143752
##########
File path: jena-arq/src/main/java/org/apache/jena/atlas/web/TypedInputStream.java
##########
@@ -47,11 +43,11 @@ private TypedInputStream(InputStream in)
public TypedInputStream(InputStream in, String contentType)
{ this(in, ContentType.create(contentType), null) ; }
- public TypedInputStream(InputStream in, String mediaType, String charset)
- { this(in, mediaType, charset, null) ; }
-
- public TypedInputStream(InputStream in, String mediaType, String charset, String baseURI)
- { this(in, ContentType.create(mediaType, charset), baseURI) ; }
+// public TypedInputStream(InputStream in, String mediaType, String charset)
+// { this(in, mediaType, charset, null) ; }
+//
+// public TypedInputStream(InputStream in, String mediaType, String charset, String baseURI)
+// { this(in, ContentType.create(mediaType, charset), baseURI) ; }
Review comment:
Agreed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services