You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2007/10/26 14:40:50 UTC

[jira] Created: (JCR-1190) QValueFactory improvements

QValueFactory improvements
--------------------------

                 Key: JCR-1190
                 URL: https://issues.apache.org/jira/browse/JCR-1190
             Project: Jackrabbit
          Issue Type: Improvement
          Components: SPI
            Reporter: Julian Reschke
            Assignee: Julian Reschke
            Priority: Minor


1) Allow all create methods to throw RepositoryException.

2) Further document that create(value,type) can throw ValueFormatException.

3) Remove special case create(File)


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-1190) QValueFactory improvements

Posted by "angela (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela resolved JCR-1190.
-------------------------

    Resolution: Fixed
      Assignee: angela  (was: Julian Reschke)

won'tfix for issue #3.
apart from that the problems indicated in this issue are fixed.

> QValueFactory improvements
> --------------------------
>
>                 Key: JCR-1190
>                 URL: https://issues.apache.org/jira/browse/JCR-1190
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-spi, jackrabbit-spi-commons
>            Reporter: Julian Reschke
>            Assignee: angela
>            Priority: Minor
>             Fix For: 1.4
>
>
> 1) Allow all create methods to throw RepositoryException.
> 2) Further document that create(value,type) can throw ValueFormatException.
> 3) Remove special case create(File)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1190) QValueFactory improvements

Posted by "angela (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545865 ] 

angela commented on JCR-1190:
-----------------------------

4) the current implementation in jackrabbit-spi-commons is not consistent regarding ValueFormatException.
    It catches that NumberFormatException upon creating Double/Long values and upon getDouble/getLong converting
    it to ValueFormatException.
    However, it does not apply the same logic for PropertyType.NAME and PropertyType.PATH.



> QValueFactory improvements
> --------------------------
>
>                 Key: JCR-1190
>                 URL: https://issues.apache.org/jira/browse/JCR-1190
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-spi, jackrabbit-spi-commons
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>             Fix For: 1.4
>
>
> 1) Allow all create methods to throw RepositoryException.
> 2) Further document that create(value,type) can throw ValueFormatException.
> 3) Remove special case create(File)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1190) QValueFactory improvements

Posted by "angela (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545868 ] 

angela commented on JCR-1190:
-----------------------------

improve consistency of QValueFactory impl in spi-commons rev. 598665   (4)


> QValueFactory improvements
> --------------------------
>
>                 Key: JCR-1190
>                 URL: https://issues.apache.org/jira/browse/JCR-1190
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-spi, jackrabbit-spi-commons
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>             Fix For: 1.4
>
>
> 1) Allow all create methods to throw RepositoryException.
> 2) Further document that create(value,type) can throw ValueFormatException.
> 3) Remove special case create(File)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1190) QValueFactory improvements

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-1190:
-------------------------------

    Fix Version/s: 1.4

> QValueFactory improvements
> --------------------------
>
>                 Key: JCR-1190
>                 URL: https://issues.apache.org/jira/browse/JCR-1190
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: SPI
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>             Fix For: 1.4
>
>
> 1) Allow all create methods to throw RepositoryException.
> 2) Further document that create(value,type) can throw ValueFormatException.
> 3) Remove special case create(File)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1190) QValueFactory improvements

Posted by "angela (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela updated JCR-1190:
------------------------

    Component/s: jackrabbit-spi-commons

> QValueFactory improvements
> --------------------------
>
>                 Key: JCR-1190
>                 URL: https://issues.apache.org/jira/browse/JCR-1190
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-spi, jackrabbit-spi-commons
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>             Fix For: 1.4
>
>
> 1) Allow all create methods to throw RepositoryException.
> 2) Further document that create(value,type) can throw ValueFormatException.
> 3) Remove special case create(File)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1190) QValueFactory improvements

Posted by "angela (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545867 ] 

angela commented on JCR-1190:
-----------------------------

added javadoc for 2) rev. 598663  


> QValueFactory improvements
> --------------------------
>
>                 Key: JCR-1190
>                 URL: https://issues.apache.org/jira/browse/JCR-1190
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-spi, jackrabbit-spi-commons
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>             Fix For: 1.4
>
>
> 1) Allow all create methods to throw RepositoryException.
> 2) Further document that create(value,type) can throw ValueFormatException.
> 3) Remove special case create(File)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1190) QValueFactory improvements

Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537976 ] 

Julian Reschke commented on JCR-1190:
-------------------------------------

Added exceptions to method signatures in r588666.


> QValueFactory improvements
> --------------------------
>
>                 Key: JCR-1190
>                 URL: https://issues.apache.org/jira/browse/JCR-1190
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: SPI
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>
> 1) Allow all create methods to throw RepositoryException.
> 2) Further document that create(value,type) can throw ValueFormatException.
> 3) Remove special case create(File)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1190) QValueFactory improvements

Posted by "angela (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545870 ] 

angela commented on JCR-1190:
-----------------------------

julian, what is the problem with 3)?
i just saw, that the create(File) is used during Session.importXML.... so, I am inclined to keep that method.

apart from that this issue could be resolved fixed.
please comment.

> QValueFactory improvements
> --------------------------
>
>                 Key: JCR-1190
>                 URL: https://issues.apache.org/jira/browse/JCR-1190
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-spi, jackrabbit-spi-commons
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>             Fix For: 1.4
>
>
> 1) Allow all create methods to throw RepositoryException.
> 2) Further document that create(value,type) can throw ValueFormatException.
> 3) Remove special case create(File)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.