You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/26 10:42:31 UTC
[GitHub] [airflow] doiken opened a new pull request, #25979: SSHHook: Saving new host keys as described in docs
doiken opened a new pull request, #25979:
URL: https://github.com/apache/airflow/pull/25979
When `no_host_key_check` is true, new host keys are not added.
```
from airflow import DAG
from airflow.operators.python import PythonOperator
from airflow.providers.ssh.hooks.ssh import SSHHook
from airflow.utils.dates import days_ago
with DAG(dag_id="example_python", schedule_interval=None, start_date=days_ago(2)) as dag:
def f():
hook = SSHHook(ssh_conn_id="ssh_default")
hook.exec_ssh_client_command(hook.get_conn(), "grep localhost ~/.ssh/known_hosts", False, None, None)
# [2022-08-26, 09:52:15 UTC] {ssh.py:467} INFO - Running command: grep localhost ~/.ssh/known_hosts
# [2022-08-26, 09:52:15 UTC] {python.py:171} INFO - Done. Returned value was: None
t = PythonOperator(task_id="example", python_callable=f)
```
I hope that it works as the docs described bellow.
https://airflow.apache.org/docs/apache-airflow-providers-ssh/stable/connections/ssh.html
> no_host_key_check ... Default is true, ssh will automatically add new host keys to the user known hosts files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25979: SSHHook: Saving new host keys as described in docs
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25979:
URL: https://github.com/apache/airflow/pull/25979#issuecomment-1229098435
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25979: SSHHook: Saving new host keys as described in docs
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25979:
URL: https://github.com/apache/airflow/pull/25979#issuecomment-1228341393
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25979: SSHHook: Saving new host keys as described in docs
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25979:
URL: https://github.com/apache/airflow/pull/25979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org