You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/14 02:12:40 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #3712: sched: Don't include nuttx/sched.h inside sched.h
xiaoxiang781216 opened a new pull request #3712:
URL: https://github.com/apache/incubator-nuttx/pull/3712
## Summary
But let nuttx/sched.h include sched.h instead to avoid expose nuttx kernel API to userspace
## Impact
Minor, header file reorganize
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3712: sched: Don't include nuttx/sched.h inside sched.h
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3712:
URL: https://github.com/apache/incubator-nuttx/pull/3712#issuecomment-846671588
====================================================================================
> Configuration/Tool: same70-xplained/twm4nx,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
> ------------------------------------------------------------------------------------
> Cleaning...
> Configuring...
> Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
> Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
> Building NuttX...
> vnc/server/vnc_fbdev.c: In function 'up_getvideoinfo':
> Error: vnc/server/vnc_fbdev.c:164:3: error: implicit declaration of function 'DEBUGASSERT' [-Werror=implicit-function-declaration]
> 164 | DEBUGASSERT(fbinfo != NULL && vinfo != NULL);
> | ^~~~~~~~~~~
> ```
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 merged pull request #3712: sched: Don't include nuttx/sched.h inside sched.h
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #3712:
URL: https://github.com/apache/incubator-nuttx/pull/3712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3712: sched: Don't include nuttx/sched.h inside sched.h
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #3712:
URL: https://github.com/apache/incubator-nuttx/pull/3712#issuecomment-846652122
>Depends on
>apache/incubator-nuttx-apps#725
>apache/incubator-nuttx-apps#728
Both PRs were merged and I restarted the CI job but still failed.
```
====================================================================================
Configuration/Tool: same70-xplained/twm4nx,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Building NuttX...
vnc/server/vnc_fbdev.c: In function 'up_getvideoinfo':
Error: vnc/server/vnc_fbdev.c:164:3: error: implicit declaration of function 'DEBUGASSERT' [-Werror=implicit-function-declaration]
164 | DEBUGASSERT(fbinfo != NULL && vinfo != NULL);
| ^~~~~~~~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3712: sched: Don't include nuttx/sched.h inside sched.h
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #3712:
URL: https://github.com/apache/incubator-nuttx/pull/3712#issuecomment-846420678
Depends on
https://github.com/apache/incubator-nuttx-apps/pull/725
https://github.com/apache/incubator-nuttx-apps/pull/728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3712: sched: Don't include nuttx/sched.h inside sched.h
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #3712:
URL: https://github.com/apache/incubator-nuttx/pull/3712#issuecomment-846671588
>```
>====================================================================================
> Configuration/Tool: same70-xplained/twm4nx,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
> ------------------------------------------------------------------------------------
> Cleaning...
> Configuring...
> Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
> Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
> Building NuttX...
> vnc/server/vnc_fbdev.c: In function 'up_getvideoinfo':
> Error: vnc/server/vnc_fbdev.c:164:3: error: implicit declaration of function 'DEBUGASSERT' [-Werror=implicit-function-declaration]
> 164 | DEBUGASSERT(fbinfo != NULL && vinfo != NULL);
> | ^~~~~~~~~~~
> ```
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #3712: sched: Don't include nuttx/sched.h inside sched.h
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #3712:
URL: https://github.com/apache/incubator-nuttx/pull/3712#issuecomment-846701162
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3712: sched: Don't include nuttx/sched.h inside sched.h
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #3712:
URL: https://github.com/apache/incubator-nuttx/pull/3712#issuecomment-846420678
Depends on https://github.com/apache/incubator-nuttx-apps/pull/725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org