[jira] Created: (TS-168) LogBuffer.h/LogObject.h overload operator new and do object initialization there using iObject which is evil

["John Plevyak (JIRA)" <ji...@apache.org>]

LogBuffer.h/LogObject.h overload operator new and do object initialization there using iObject which is evil
------------------------------------------------------------------------------------------------------------

                 Key: TS-168
                 URL: https://issues.apache.org/jira/browse/TS-168
             Project: Traffic Server
          Issue Type: Improvement
          Components: Logging
            Reporter: John Plevyak
             Fix For: 2.1.0


In header LogBuffer.h the classes iObject/iObjectActivator/iLogBufferData
need to be cleaned up.

This code is terribly designed.  Nobody should ever do object initialization
in an overloaded new operator.   This caused TS-159.

The logging code was designed to be completely lockless on the critical path
and not to do any malloc/new (which typically involve locks) and this code
breaks that design.

Basically, this should be rewritten, perhaps someone for Y! could attach
the patch which added this junk so it can be backed out and whatever
real functionality it added, added in a reasonable way.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.