[GitHub] [superset] rwspielman commented on issue #12907: [table] Total Row for Table Charts

[GitBox <gi...@apache.org>]

rwspielman commented on issue #12907:
URL: https://github.com/apache/superset/issues/12907#issuecomment-773850365


   Junlin (@junlincc), confirming that your second screenshot is the end result I'm looking for. We are coming from excel reporting mostly so the parallel in excel looks like this: 
   <img width="266" alt="Screen Shot 2021-02-05 at 1 04 40 AM" src="https://user-images.githubusercontent.com/20442310/107000837-2c1adc80-674e-11eb-8fe8-70810811b6e9.png">
   
   To opine on your second design consideration of where to add the switch, I think that for the case of `Query Mode: Aggregate` it should be placed in the `Group By` section of the control panel. From a user standpoint, it would be like unioning an additional row where we are grouping by `True` (i.e. `SELECT "Grand Total" as <groupby>, <metrics> FROM <table> GROUP BY True ...`)
   
   Additionally, our use case is for table viz `Query Mode: Aggregate`. For this case, it should carry over the metrics defined in the query section of the control panel and not require the user to define an aggregating function.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org