You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org> on 2024/08/15 09:57:59 UTC

[Impala-ASF-CR] IMPALA-12850: Add better error message for REFRESH iceberg tbl PARTITION(...)

Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21594


Change subject: IMPALA-12850: Add better error message for REFRESH iceberg_tbl PARTITION(...)
......................................................................

IMPALA-12850: Add better error message for REFRESH iceberg_tbl PARTITION(...)

Iceberg table partition keys are not recorded in HMS, because
of the various partition transforms that the Iceberg spec makes
possible. Therefore Iceberg tables do not support partition-grained
refresh.
The previous error message was not descriptive; it originated from
the different partition handling logic that Impala has for Iceberg
tables compared to HDFS tables.
Added a more user-friendly, Iceberg-specific error message.

Testing:
 - AnalyzerTest

Change-Id: Id4bccf3eac533a00c156d2a5631523684b5e5b9c
---
M fe/src/main/java/org/apache/impala/analysis/PartitionSpec.java
M fe/src/main/java/org/apache/impala/analysis/PartitionSpecBase.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
3 files changed, 11 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/21594/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4bccf3eac533a00c156d2a5631523684b5e5b9c
Gerrit-Change-Number: 21594
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12850: Add better error message for REFRESH iceberg tbl PARTITION(...)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21594 )

Change subject: IMPALA-12850: Add better error message for REFRESH iceberg_tbl PARTITION(...)
......................................................................

IMPALA-12850: Add better error message for REFRESH iceberg_tbl PARTITION(...)

Iceberg table partition keys are not recorded in HMS, because
of the various partition transforms that the Iceberg spec makes
possible. Therefore Iceberg tables do not support partition-grained
refresh.
The previous error message was not descriptive; it originated from
the different partition handling logic that Impala has for Iceberg
tables compared to HDFS tables.
Added a more user-friendly, Iceberg-specific error message.

Testing:
 - AnalyzerTest

Change-Id: Id4bccf3eac533a00c156d2a5631523684b5e5b9c
Reviewed-on: http://gerrit.cloudera.org:8080/21594
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/PartitionSpec.java
M fe/src/main/java/org/apache/impala/analysis/PartitionSpecBase.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
3 files changed, 11 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4bccf3eac533a00c156d2a5631523684b5e5b9c
Gerrit-Change-Number: 21594
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12850: Add better error message for REFRESH iceberg tbl PARTITION(...)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21594 )

Change subject: IMPALA-12850: Add better error message for REFRESH iceberg_tbl PARTITION(...)
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10863/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/21594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4bccf3eac533a00c156d2a5631523684b5e5b9c
Gerrit-Change-Number: 21594
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 10:19:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12850: Add better error message for REFRESH iceberg tbl PARTITION(...)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21594 )

Change subject: IMPALA-12850: Add better error message for REFRESH iceberg_tbl PARTITION(...)
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/16697/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/21594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4bccf3eac533a00c156d2a5631523684b5e5b9c
Gerrit-Change-Number: 21594
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 10:25:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12850: Add better error message for REFRESH iceberg tbl PARTITION(...)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21594 )

Change subject: IMPALA-12850: Add better error message for REFRESH iceberg_tbl PARTITION(...)
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4bccf3eac533a00c156d2a5631523684b5e5b9c
Gerrit-Change-Number: 21594
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 15:34:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12850: Add better error message for REFRESH iceberg tbl PARTITION(...)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21594 )

Change subject: IMPALA-12850: Add better error message for REFRESH iceberg_tbl PARTITION(...)
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4bccf3eac533a00c156d2a5631523684b5e5b9c
Gerrit-Change-Number: 21594
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 10:19:04 +0000
Gerrit-HasComments: No