[GitHub] [dubbo] CodePlayer commented on pull request #12258: fix generic type deserialize bug ( #12257 )

["CodePlayer (via GitHub)" <gi...@apache.org>]

CodePlayer commented on PR #12258:
URL: https://github.com/apache/dubbo/pull/12258#issuecomment-1541397852

   > Dubbo already use `ContextAutoTypeBeforeHandler` to indicate which classes can be deserialized. SupportAutoType should not be enabled.
   
   
   @AlbumenJ 
   But, it **still has bugs**. Same code, using Hessian2 it works, switch to fastjson2 it goes wrong。
   
   I think, Dubbo should remove `JSONReader.Feature.IgnoreAutoTypeNotMatch`, instead of `JSONReader.Feature.SupportAutoType`.
   
   Because Dubbo is based on **interfaces** and is **strongly typed**, fastjson2 will judge whether the types match, and throw an exception if they do not match.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org