You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/12/04 06:45:20 UTC

[GitHub] [couchdb] nickva commented on pull request #4287: Allow = in config key names

nickva commented on PR #4287:
URL: https://github.com/apache/couchdb/pull/4287#issuecomment-1336334575

   > Just a couple nits: First, the title of the PR "Allow = in config key values" makes it sound like we're allowing the `=` character in the _values_, but I think you mean "key names"?
   > 
   
   Good catch. Yeah that is ambiguous, I meant "key names".
   
   > > There are allowed only for the `k = v` form and not `k=v`.
   > 
   > Do you mean "They are allowed ..."?
   >
   
   Yup! Silly mistake. Thanks for noticing!
   
   > > The idea is to split on `=` first, and if that fails to produce a valid kv pair we split on `=` as before.
   > 
   > Should the first one contain spaces on either side of the equal sign, like `=`?
   > 
   
   I had it in the commit comment but then tried to make prettier in the PR comment messed it up instead. I'll return back to using quotes.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org