You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pdfbox.apache.org by "Tilman Hausherr (Jira)" <ji...@apache.org> on 2020/02/06 03:57:00 UTC

[jira] [Resolved] (PDFBOX-4767) getFilters() methods should return an empty list instead of null when possible

     [ https://issues.apache.org/jira/browse/PDFBOX-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tilman Hausherr resolved PDFBOX-4767.
-------------------------------------
    Resolution: Fixed

> getFilters() methods should return an empty list instead of null when possible
> ------------------------------------------------------------------------------
>
>                 Key: PDFBOX-4767
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-4767
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: PDModel
>    Affects Versions: 2.0.18
>            Reporter: Tilman Hausherr
>            Assignee: Tilman Hausherr
>            Priority: Minor
>             Fix For: 3.0.0 PDFBox
>
>
> "Clean code" teaches to favor returning an empty lists instead of null.
> This is a breaking change because some may check for null to confirm the lack of a filter key. Preflight does this in {{MetadataValidationProcess.getXpacket()}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org