You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/01/24 18:37:28 UTC

[GitHub] [commons-io] garydgregory commented on issue #101: IO-649 - Improve the performance of the contentEquals() methods.

garydgregory commented on issue #101: IO-649 - Improve the performance of the contentEquals() methods.
URL: https://github.com/apache/commons-io/pull/101#issuecomment-578249246
 
 
   Hi @brettlounsbury.
   
   Thank you for your PR and updates. I've sprinkled comments throughout.
   
   Performance claims must be backed up somehow, please add a JMH benchmark to the test so myself and others can compare mileage. 
   
   For examples of JMH usage, please see other Apache Commons components like Commons BCEL, Commons Crypto, Commons CSV, Commons Lang, Commons Math, and Commons RNG.
   
   Thank you!
   Gary

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services