You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/22 13:58:34 UTC
[GitHub] [airflow] mik-laj opened a new pull request #7501: [AIRFLOW-6880]
Do not check task instances for new DAGRuns
mik-laj opened a new pull request #7501: [AIRFLOW-6880] Do not check task instances for new DAGRuns
URL: https://github.com/apache/airflow/pull/7501
When I have the following DAG:
```
dag = DAG(dag_id="test_dag", schedule_interval="@once", start_date=days_ago(2))
DummyOperator(task_id=f"task", dag=dag)
dag.sync_to_db()
```
and executes the following code:
```
for i in range(1, 1000+1):
dag.create_dagrun(
run_id=f"dag-{i}",
state=State.RUNNING
)
```
I got the following results
Before:
Query count: 4000
Average time 13983.817 ms
After:
Query count: 3000
Average time: 11499.290 ms
Diff:
Query count: -1000 (-25%)
Average time: 2.484 (-17%)
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj closed pull request #7501:
[AIRFLOW-6880][DONT-MERGE] Do not check task instances for new DAGRuns
Posted by GitBox <gi...@apache.org>.
mik-laj closed pull request #7501: [AIRFLOW-6880][DONT-MERGE] Do not check task instances for new DAGRuns
URL: https://github.com/apache/airflow/pull/7501
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7501: [AIRFLOW-6880][WIP]
Do not check task instances for new DAGRuns
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7501: [AIRFLOW-6880][WIP] Do not check task instances for new DAGRuns
URL: https://github.com/apache/airflow/pull/7501#issuecomment-589972021
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7501?src=pr&el=h1) Report
> Merging [#7501](https://codecov.io/gh/apache/airflow/pull/7501?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4e0e2f0da39626c1bc8026a33c2080a6b11f2c41?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7501?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7501 +/- ##
==========================================
- Coverage 86.79% 86.54% -0.26%
==========================================
Files 887 891 +4
Lines 41976 42095 +119
==========================================
- Hits 36432 36430 -2
- Misses 5544 5665 +121
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7501?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7501/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `91.29% <ø> (ø)` | :arrow_up: |
| [airflow/models/dagrun.py](https://codecov.io/gh/apache/airflow/pull/7501/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFncnVuLnB5) | `96.56% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7501/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7501/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7501/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7501/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.38% <0%> (-25.52%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7501/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [airflow/utils/file.py](https://codecov.io/gh/apache/airflow/pull/7501/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9maWxlLnB5) | `87.83% <0%> (-1.36%)` | :arrow_down: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7501/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.93% <0%> (-0.2%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/airflow/pull/7501/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7501?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7501?src=pr&el=footer). Last update [4e0e2f0...8e30621](https://codecov.io/gh/apache/airflow/pull/7501?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7501: [AIRFLOW-6880][WIP] Do
not check task instances for new DAGRuns
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7501: [AIRFLOW-6880][WIP] Do not check task instances for new DAGRuns
URL: https://github.com/apache/airflow/pull/7501#issuecomment-589994328
It won't work, but we need to add tests to detect these situations. TaskInstance can have several related DAGRuns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services