You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Bilwa S T (JIRA)" <ji...@apache.org> on 2019/04/26 06:09:00 UTC
[jira] [Commented] (MAPREDUCE-7199) HsJobsBlock reuse
JobACLsManager for checkAccess
[ https://issues.apache.org/jira/browse/MAPREDUCE-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826671#comment-16826671 ]
Bilwa S T commented on MAPREDUCE-7199:
--------------------------------------
Hi [~bibinchundatt] i have attached patch. Please review
> HsJobsBlock reuse JobACLsManager for checkAccess
> ------------------------------------------------
>
> Key: MAPREDUCE-7199
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7199
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Bibin A Chundatt
> Assignee: Bilwa S T
> Priority: Minor
> Attachments: MAPREDUCE-7199-001.patch
>
>
> Reuse JobAclManager.checkAccess
> {code}
> private boolean checkAccess(String userName) {
> if(!areAclsEnabled) {
> return true;
> }
> // User could see its own job.
> if (ugi.getShortUserName().equals(userName)) {
> return true;
> }
> // Admin could also see all jobs
> if (adminAclList != null && adminAclList.isUserAllowed(ugi)) {
> return true;
> }
> return false;
> }
> {code}
> {code}
> jobACLsManager
> .checkAccess(ugi, JobACL.VIEW_JOB, ..
> new AccessControlList()))
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org