[jira] [Comment Edited] (ZOOKEEPER-2901) Session ID that is negative causes mis-calculation of Ephemeral Type

["Patrick Hunt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204369#comment-16204369 ] 

Patrick Hunt edited comment on ZOOKEEPER-2901 at 10/13/17 11:58 PM:
--------------------------------------------------------------------

Jordan, given the lack of feedback on my earlier question/suggestion it seems like the prudent thing to do would be to go ahead with your original proposal - turn if off by default. (please resubmit that PR) I think we could have a separate jira to "deprecate" the use of the high order server id (please enter a jira for this if you agree), and then in a future version of ZK turn this feature on by default. The "deprecation" would allow folks time to address.

I basically have zero time to look at this, but given the lack of anyone else having time to look at this I will try to make some time next week. Thanks for hanging in there.


was (Author: phunt):
Jordan, given the lack of feedback on my earlier question/suggestion it seems like the prudent thing to do would be to go ahead with your original proposal - turn if off by default. I think we could have a separate jira to "deprecate" the use of the high order server id (please enter a jira for this if you agree), and then in a future version of ZK turn this feature on by default. The "deprecation" would allow folks time to address.

I basically have zero time to look at this, but given the lack of anyone else having time to look at this I will try to make some time next week. Thanks for hanging in there.

> Session ID that is negative causes mis-calculation of Ephemeral Type
> --------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2901
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2901
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.3
>         Environment: Running 3.5.3-beta in Docker container
>            Reporter: Mark Johnson
>            Assignee: Jordan Zimmerman
>            Priority: Blocker
>
> In the code that determines the EphemeralType it is looking at the owner (which is the client ID or connection ID):
> EphemeralType.java:
>    public static EphemeralType get(long ephemeralOwner) {
>        if (ephemeralOwner == CONTAINER_EPHEMERAL_OWNER) {
>            return CONTAINER;
>        }
>        if (ephemeralOwner < 0) {
>            return TTL;
>        }
>        return (ephemeralOwner == 0) ? VOID : NORMAL;
>    }
> However my connection ID is:
> header.getClientId(): -720548323429908480
> This causes the code to think this is a TTL Ephemeral node instead of a
> NORMAL Ephemeral node.
> This also explains why this is random - if my client ID is non-negative
> then the node gets added correctly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)