You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/18 03:14:04 UTC

[GitHub] [flink] libenchao commented on a change in pull request #11512: [FLINK-16589][table-planner-blink] Split code for AggsHandlerCodeGene…

libenchao commented on a change in pull request #11512:
URL: https://github.com/apache/flink/pull/11512#discussion_r441944295



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/AggregateITCase.scala
##########
@@ -1334,4 +1334,32 @@ class AggregateITCase(
     val expected = Seq("3,29.39,tom123@gmail.com")
     assertEquals(expected.sorted, sink.getRetractResults.sorted)
   }
+
+  @Test
+  def testSplitAggsHandler(): Unit = {
+
+    val t = env.fromCollection(TestData.smallTupleData3)
+      .toTable(tEnv, 'a, 'b, 'c)
+    tEnv.createTemporaryView("MyTable", t)
+
+    tEnv.getConfig.setMaxGeneratedCodeLength(1)
+
+    val columnNumber = 100

Review comment:
       OK, will change it. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org