You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/22 09:49:34 UTC

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1097: feat: "upstream" i18n

guoqqqi opened a new pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   resolve #1094 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1097: feat: improve upstream i18n

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r549169518



##########
File path: web/src/pages/Upstream/locales/zh-CN.ts
##########
@@ -15,80 +15,89 @@
  * limitations under the License.
  */
 export default {
-  'upstream.step.backend.server.domain.or.ip': '后端服务域名/IP',
-  'upstream.step.domain.name.default.analysis':
+  'page.upstream.step.select.upstream': '选择上游',
+  'page.upstream.step.select.upstream.select.option': '手动填写',
+  'page.upstream.form.item-label.node.domain.or.ip': '节点域名/IP',
+  'page.upstream.step.backend.server.domain.or.ip': '后端服务域名/IP',
+  'page.upstream.form.item.extra-message.node.domain.or.ip':
     '使用域名时，默认解析本地 /etc/resolv.conf；权重为0则熔断该节点',
-  'upstream.step.input.domain.name.or.ip': '请输入域名/IP',
-  'upstream.step.domain.name.or.ip.rule': '仅支持字母、数字和 . ',
-  'upstream.step.domain.name.or.ip': '域名/IP',
-  'upstream.step.input.port': '请输入端口号',
-  'upstream.step.port': '端口号',
-  'upstream.step.input.weight': '请输入权重',
-  'upstream.step.weight': '权重',
-  'upstream.step.create': '创建',
-  'upstream.step.name': '名称',
-  'upstream.step.name.should.unique': '名称需全局唯一',
-  'upstream.step.input.upstream.name': '请输入上游名称',
-  'upstream.step.description': '描述',
-  'upstream.step.input.description': '请输入描述',
-  'upstream.step.type': '类型',
-  'upstream.step.pass-host': '传递域名',
-  'upstream.step.pass-host.tips': '当选择节点时，节点域名只能有一条数据。',
-  'upstream.step.pass-host.pass': '透传',
-  'upstream.step.pass-host.node': '节点',
-  'upstream.step.pass-host.rewrite': '重写',
-  'upstream.step.pass-host.upstream_host': '上游域名',
-  'upstream.step.connect.timeout': '连接超时',
-  'upstream.step.input.connect.timeout': '请输入连接超时时间',
-  'upstream.step.send.timeout': '发送超时',
-  'upstream.step.input.send.timeout': '请输入发送超时时间',
-  'upstream.step.read.timeout': '接收超时',
-  'upstream.step.input.read.timeout': '请输入接收超时时间',
-  'upstream.step.healthy.check': '上游健康检查',
-  'upstream.step.healthy.checks.healthy': '健康',
-  'upstream.step.healthy.checks.unhealthy': '不健康',
-  'upstream.step.healthy.checks.active': '探活健康检查',
-  'upstream.step.healthy.checks.active.timeout': '超时时间',
-  'upstream.step.input.healthy.checks.active.timeout': '请输入超时时间',
-  'upstream.step.healthy.checks.active.http_path': '路径',
-  'upstream.step.input.healthy.checks.active.http_path': '请输入路径',
-  'upstream.step.healthy.checks.active.port': "端口",
-  'upstream.step.input.healthy.checks.active.port': '请输入端口',
-  'upstream.step.healthy.checks.active.host': '域名',
-  'upstream.step.input.healthy.checks.active.host': '请输入域名',
-  'upstream.step.healthy.checks.active.interval': '间隔',
-  'upstream.step.input.healthy.checks.active.interval': '请输入间隔',
-  'upstream.step.healthy.checks.successes': '成功次数',
-  'upstream.step.input.healthy.checks.successes': '请输入成功次数',
-  'upstream.step.healthy.checks.http_failures': '失败次数',
-  'upstream.step.input.healthy.checks.http_failures': '请输入失败次数',
-  'upstream.step.healthy.checks.active.req_headers': '请求头',
-  'upstream.step.input.healthy.checks.active.req_headers': '请输入请求头',
-  'upstream.step.healthy.checks.passive': '被动健康检查',
-  'upstream.step.healthy.checks.passive.http_statuses': '状态码',
-  'upstream.step.input.healthy.checks.passive.http_statuses': '请输入状态码',
-  'upstream.step.healthy.checks.passive.tcp_failures': 'tcp失败次数',
-  'upstream.step.input.healthy.checks.passive.tcp_failures': '请输入tcp失败次数',
-  'upstream.notificationMessage.enableHealthCheckFirst': '请先启用探活健康检查。',
+  'page.upstream.step.input.domain.name.or.ip': '请输入域名/IP',
+  'page.upstream.step.domain.name.or.ip.rule': '仅支持字母、数字和 . ',
+  'page.upstream.step.domain.name.or.ip': '域名/IP',
+  'page.upstream.step.input.port': '请输入端口号',
+  'page.upstream.step.port': '端口号',
+  'page.upstream.step.input.weight': '请输入权重',
+  'page.upstream.step.weight': '权重',
+  'page.upstream.step.create': '创建',
+  'page.upstream.step.name': '名称',
+  'page.upstream.step.name.should.unique': '名称需全局唯一',
+  'page.upstream.step.input.upstream.name': '请输入上游名称',
+  'page.upstream.step.description': '描述',
+  'page.upstream.step.input.description': '请输入描述',
+  'page.upstream.step.type': '类型',
+  'page.upstream.step.create.node': '创建节点',
+  'page.upstream.step.pass-host': '传递域名',
+  'page.upstream.step.pass-host.tips': '当选择节点时，节点域名只能有一条数据。',
+  'page.upstream.step.pass-host.pass': '透传',
+  'page.upstream.step.pass-host.node': '节点',
+  'page.upstream.step.pass-host.rewrite': '重写',
+  'page.upstream.step.pass-host.upstream_host': '上游域名',
+  'page.upstream.step.connect.timeout': '连接超时',
+  'page.upstream.step.input.connect.timeout': '请输入连接超时时间',
+  'page.upstream.step.send.timeout': '发送超时',
+  'page.upstream.step.input.send.timeout': '请输入发送超时时间',
+  'page.upstream.step.read.timeout': '接收超时',
+  'page.upstream.step.input.read.timeout': '请输入接收超时时间',
+  'page.upstream.step.healthy.checks.healthy.check': '健康检查',
+  'page.upstream.step.healthy.check': '上游健康检查',
+  'page.upstream.step.healthy.checks.healthy': '健康',
+  'page.upstream.step.healthy.checks.unhealthy': '不健康',
+  'page.upstream.step.healthy.checks.healthy.status': '健康状态',
+  'page.upstream.step.healthy.checks.unhealthy.status': '不健康状态',
+  'page.upstream.step.healthy.checks.active': '探活健康检查',
+  'page.upstream.step.healthy.checks.active.timeout': '超时时间',
+  'page.upstream.step.input.healthy.checks.active.timeout': '请输入超时时间',
+  'page.upstream.step.healthy.checks.active.http_path': '路径',
+  'page.upstream.step.input.healthy.checks.active.http_path': '请输入路径',
+  'page.upstream.step.healthy.checks.active.port': "端口",
+  'page.upstream.step.input.healthy.checks.active.port': '请输入端口',
+  'page.upstream.step.healthy.checks.active.host': '域名',
+  'page.upstream.step.input.healthy.checks.active.host': '请输入域名',
+  'page.upstream.step.healthy.checks.active.interval': '间隔',
+  'page.upstream.step.input.healthy.checks.active.interval': '请输入间隔',
+  'page.upstream.step.healthy.checks.successes': '成功次数',
+  'page.upstream.step.input.healthy.checks.successes': '请输入成功次数',
+  'page.upstream.step.healthy.checks.http_failures': '失败次数',
+  'page.upstream.step.healthy.checks.active.create.req_headers': '创建请求头',
+  'page.upstream.step.input.healthy.checks.http_failures': '请输入失败次数',
+  'page.upstream.step.healthy.checks.active.req_headers': '请求头',
+  'page.upstream.step.input.healthy.checks.active.req_headers': '请输入请求头',
+  'page.upstream.step.healthy.checks.passive': '被动健康检查',
+  'page.upstream.step.healthy.checks.passive.create.http_statuses': '创建状态码',
+  'page.upstream.step.healthy.checks.passive.http_statuses': '状态码',
+  'page.upstream.step.input.healthy.checks.passive.http_statuses': '请输入状态码',
+  'page.upstream.step.healthy.checks.passive.tcp_failures': 'tcp失败次数',
+  'page.upstream.step.input.healthy.checks.passive.tcp_failures': '请输入tcp失败次数',
+  'page.upstream.notificationMessage.enableHealthCheckFirst': '请先启用探活健康检查。',
 
-  'upstream.create.edit': '编辑',
-  'upstream.create.create': '创建',
-  'upstream.create.upstream.successfully': '上游成功',
-  'upstream.create.basic.info': '基础信息',
-  'upstream.create.preview': '预览',
+  'page.upstream.create.edit': '编辑',
+  'page.upstream.create.create': '创建',
+  'page.upstream.create.upstream.successfully': '上游成功',
+  'page.upstream.create.basic.info': '基础信息',
+  'page.upstream.create.preview': '预览',
 
-  'upstream.list.name': '名称',
-  'upstream.list.type': '类型',
-  'upstream.list.description': '描述',
-  'upstream.list.edit.time': '编辑时间',
-  'upstream.list.operation': '操作',
-  'upstream.list.edit': '编辑',
-  'upstream.list.confirm.delete': '确定删除该条记录吗？',
-  'upstream.list.confirm': '确定',
-  'upstream.list.cancel': '取消',
-  'upstream.list.delete.successfully': '删除记录成功',
-  'upstream.list.delete': '删除',
-  'upstream.list': '上游列表',
-  'upstream.list.input': '请输入',
-  'upstream.list.create': '创建',
+  'page.upstream.list.name': '名称',
+  'page.upstream.list.type': '类型',
+  'page.upstream.list.description': '描述',
+  'page.upstream.list.edit.time': '编辑时间',
+  'page.upstream.list.operation': '操作',
+  'page.upstream.list.edit': '编辑',
+  'page.upstream.list.confirm.delete': '确定删除该条记录吗？',
+  'page.upstream.list.confirm': '确定',
+  'page.upstream.list.cancel': '取消',
+  'page.upstream.list.delete.successfully': '删除记录成功',
+  'page.upstream.list.delete': '删除',
+  'page.upstream.list': '上游列表',
+  'page.upstream.list.input': '请输入',
+  'page.upstream.list.create': '创建',

Review comment:
       We have global keys  `component.global.delete` `component.global.operation` `component.global.name` `component.global.pleaseEnter` `component.global.edit` `component.global.cancel` `component.global.create` etc. we can consider simplifying some definitions ^^




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-751464111


   most texts are updated, we could merge this one first IMO.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r549108676



##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -136,9 +136,9 @@ const UpstreamForm: React.FC<Props> = forwardRef(
               <Form.Item
                 required
                 key={field.key}
-                label={index === 0 && '节点域名/IP'}
+                label={index === 0 && formatMessage({ id: 'page.upstream.form.item-label.node.domain.or.ip' })}

Review comment:
       ```suggestion
                   label={index === 0 && formatMessage({ id: 'page.upstream.form.item-label.nodeDomainOrIp' })}
   ```

##########
File path: web/src/locales/zh-CN/menu.ts
##########
@@ -58,6 +58,7 @@ export default {
   'menu.account': '个人页',
   'menu.account.center': '个人中心',
   'menu.account.settings': '个人设置',
+  'menu.account.modify-settings': '修改设置',

Review comment:
       ```suggestion
     'menu.account.settings': '修改设置',
   ```

##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -136,9 +136,9 @@ const UpstreamForm: React.FC<Props> = forwardRef(
               <Form.Item
                 required
                 key={field.key}
-                label={index === 0 && '节点域名/IP'}
+                label={index === 0 && formatMessage({ id: 'page.upstream.form.item-label.node.domain.or.ip' })}
                 extra={
-                  index === 0 && '使用域名时，默认解析本地 /etc/resolv.conf；权重为0则熔断该节点'
+                  index === 0 && formatMessage({ id: 'page.upstream.form.item.extra-message.node.domain.or.ip' })

Review comment:
       ```suggestion
                     index === 0 && formatMessage({ id: 'page.upstream.form.item.extra-message.nodeDomainOrIp' })
   ```

##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -231,35 +244,35 @@ const UpstreamForm: React.FC<Props> = forwardRef(
             rules={[
               {
                 required: true,
-                message: formatMessage({ id: 'upstream.step.input.healthy.checks.active.host' }),
+                message: formatMessage({ id: 'page.upstream.step.input.healthy.checks.active.host' }),
               },
               {
                 pattern: new RegExp(
                   /(^([1-9]?\d|1\d{2}|2[0-4]\d|25[0-5])(\.(25[0-5]|1\d{2}|2[0-4]\d|[1-9]?\d)){3}$|^(?![0-9.]+$)([a-zA-Z0-9_-]+)(\.[a-zA-Z0-9_-]+){0,}$)/,
                   'g',
                 ),
-                message: formatMessage({ id: 'upstream.step.domain.name.or.ip.rule' }),
+                message: formatMessage({ id: 'page.upstream.step.domain.name.or.ip.rule' }),

Review comment:
       ```suggestion
                   message: formatMessage({ id: 'page.upstream.step.domainNameOrIpRule' }),
   ```

##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -161,7 +161,10 @@ const UpstreamForm: React.FC<Props> = forwardRef(
                         },
                       ]}
                     >
-                      <Input placeholder="域名/IP" disabled={readonly} />
+                      <Input
+                        placeholder={formatMessage({ id: 'page.upstream.step.domain.name.or.ip' })}

Review comment:
       ```suggestion
                           placeholder={formatMessage({ id: 'page.upstream.step.domainNameOrIp' })}
   ```

##########
File path: web/src/locales/en-US/menu.ts
##########
@@ -58,6 +58,7 @@ export default {
   'menu.account': 'Account',
   'menu.account.center': 'Account Center',
   'menu.account.settings': 'Account Settings',
+  'menu.account.modify-settings': 'Settings',

Review comment:
       ```suggestion
     'menu.account.settings': 'Settings',
   ```

##########
File path: web/src/components/RightContent/AvatarDropdown.tsx
##########
@@ -97,25 +98,25 @@ const AvatarDropdown: React.FC<GlobalHeaderRightProps> = ({ menu }) => {
       {menu && (
         <Menu.Item key="center">
           <UserOutlined />
-          个人中心
+          {formatMessage({ id: 'menu.account.center' })}
         </Menu.Item>
       )}
       {menu && (
         <Menu.Item key="settings">
           <SettingOutlined />
-          个人设置
+          {formatMessage({ id: 'menu.account.settings' })}
         </Menu.Item>
       )}
       {menu && <Menu.Divider />}
 
       <Menu.Item key="settings">
         <SettingFilled />
-        修改设置
+        {formatMessage({ id: 'menu.account.modify-settings' })}

Review comment:
       ```suggestion
           {formatMessage({ id: 'menu.account.settings' })}
   ```

##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -151,7 +151,7 @@ const UpstreamForm: React.FC<Props> = forwardRef(
                       rules={[
                         {
                           required: true,
-                          message: formatMessage({ id: 'upstream.step.input.domain.name.or.ip' }),
+                          message: formatMessage({ id: 'page.upstream.step.input.domain.name.or.ip' }),

Review comment:
       ```suggestion
                             message: formatMessage({ id: 'page.upstream.step.input.domainNameOrIp' }),
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r548837674



##########
File path: web/src/locales/en-US/menu.ts
##########
@@ -58,6 +58,7 @@ export default {
   'menu.account': 'Account',
   'menu.account.center': 'Account Center',
   'menu.account.settings': 'Account Settings',
+  'menu.account.setting.modify.settings': 'Settings',

Review comment:
       Please keep using `Settings` here, for most dashboards, `Setting` is used universally.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1097: feat: improve upstream i18n

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-751629750


   I just did those things for this PR:
   1. Update some i18n keys and values;
   2. Format all web codes;


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-751151198


   LGTM except for name style of the i18n key, it would be better to use a unified, meaningful and readable way. 
   
   maybe #331 is a good reference ^^


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1097: feat: improve upstream i18n

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r548778152



##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -133,9 +133,9 @@ const UpstreamForm: React.FC<Props> = forwardRef(
               <Form.Item
                 required
                 key={field.key}
-                label={index === 0 && '节点域名/IP'}
+                label={index === 0 && formatMessage({ id: 'upstream.step.node.domain.or.ip' })}

Review comment:
       I recommend to name the key refer to:  [basicModule].[moduleName].[elementName].[...desc], that would be more readable
   
   ```suggestion
                   label={index === 0 && formatMessage({ id: 'page.upstream.form.itemLabel.nodeDomainOrIp' })}
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1097: feat: improve upstream i18n

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=h1) Report
   > Merging [#1097](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=desc) (eeb5d75) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/14da383518a5942b8a027e8bbb306988aa5dcacc?el=desc) (14da383) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1097/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1097   +/-   ##
   =======================================
     Coverage   42.07%   42.07%           
   =======================================
     Files          30       30           
     Lines        1856     1856           
   =======================================
     Hits          781      781           
     Misses        965      965           
     Partials      110      110           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=footer). Last update [14da383...eeb5d75](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749609081


   ![image](https://user-images.githubusercontent.com/2106987/102906504-adc0ee80-44af-11eb-9e38-0f6674754ba0.png)
   
   @guoqqqi After you update the i18n, you need to update test cases in `/cypress` directory, please see snapshot.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=h1) Report
   > Merging [#1097](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=desc) (b835cbe) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/aca192c4f352aa7bcc9b88ac52da9ff3cc498271?el=desc) (aca192c) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1097/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1097   +/-   ##
   =======================================
     Coverage   41.06%   41.06%           
   =======================================
     Files          28       28           
     Lines        1773     1773           
   =======================================
     Hits          728      728           
     Misses        939      939           
     Partials      106      106           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=footer). Last update [aca192c...b835cbe](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r548775768



##########
File path: web/src/locales/en-US/menu.ts
##########
@@ -58,6 +58,7 @@ export default {
   'menu.account': 'Account',
   'menu.account.center': 'Account Center',
   'menu.account.settings': 'Account Settings',
+  'menu.account.setting.modify.settings': 'Settings',

Review comment:
       ```suggestion
     'menu.account.modifySettings': 'Modify Settings',
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r548782425



##########
File path: web/src/pages/Upstream/locales/en-US.ts
##########
@@ -61,10 +68,12 @@ export default {
   'upstream.step.healthy.checks.successes': 'Successes',
   'upstream.step.input.healthy.checks.successes': 'Please input successes',
   'upstream.step.healthy.checks.http_failures': 'HttpFailures',
+  'upstream.step.healthy.checks.active.create.req_headers': 'Creat req_headers',
   'upstream.step.input.healthy.checks.http_failures': 'Please input httpFailures',
   'upstream.step.healthy.checks.active.req_headers': 'req_headers',
   'upstream.step.input.healthy.checks.active.req_headers': 'Please input req_headers',
   'upstream.step.healthy.checks.passive': 'Passive',
+  'upstream.step.healthy.checks.passive.create.http_statuses': 'Creat http_statuses',

Review comment:
       ditto

##########
File path: web/src/pages/Upstream/locales/en-US.ts
##########
@@ -61,10 +68,12 @@ export default {
   'upstream.step.healthy.checks.successes': 'Successes',
   'upstream.step.input.healthy.checks.successes': 'Please input successes',
   'upstream.step.healthy.checks.http_failures': 'HttpFailures',
+  'upstream.step.healthy.checks.active.create.req_headers': 'Creat req_headers',

Review comment:
       ```suggestion
     'upstream.step.healthy.checks.active.create.req_headers': 'Create req_headers',
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1097: feat: improve upstream i18n

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r549168850



##########
File path: web/src/components/RightContent/AvatarDropdown.tsx
##########
@@ -97,25 +98,25 @@ const AvatarDropdown: React.FC<GlobalHeaderRightProps> = ({ menu }) => {
       {menu && (
         <Menu.Item key="center">
           <UserOutlined />
-          个人中心
+          {formatMessage({ id: 'menu.account.center' })}
         </Menu.Item>
       )}
       {menu && (
         <Menu.Item key="settings">
           <SettingOutlined />
-          个人设置
+          {formatMessage({ id: 'menu.account.settings' })}
         </Menu.Item>
       )}
       {menu && <Menu.Divider />}
 
       <Menu.Item key="settings">
         <SettingFilled />
-        修改设置
+        {formatMessage({ id: 'menu.account.settings' })}
       </Menu.Item>

Review comment:
       duplicate `settings`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r547286743



##########
File path: web/src/pages/Upstream/locales/en-US.ts
##########
@@ -61,10 +68,12 @@ export default {
   'upstream.step.healthy.checks.successes': 'Successes',
   'upstream.step.input.healthy.checks.successes': 'Please input successes',
   'upstream.step.healthy.checks.http_failures': 'HttpFailures',
+  'upstream.step.healthy.checks.active.create.req_headers': 'Creat req_headers',

Review comment:
       Hi @LiteSun, please help @guoqqqi to update those i18n values when you are free 💯 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1097: feat: improve upstream i18n

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r549272308



##########
File path: web/src/pages/Upstream/locales/zh-CN.ts
##########
@@ -15,80 +15,89 @@
  * limitations under the License.
  */
 export default {
-  'upstream.step.backend.server.domain.or.ip': '后端服务域名/IP',
-  'upstream.step.domain.name.default.analysis':
+  'page.upstream.step.select.upstream': '选择上游',
+  'page.upstream.step.select.upstream.select.option': '手动填写',
+  'page.upstream.form.item-label.node.domain.or.ip': '节点域名/IP',
+  'page.upstream.step.backend.server.domain.or.ip': '后端服务域名/IP',
+  'page.upstream.form.item.extra-message.node.domain.or.ip':
     '使用域名时，默认解析本地 /etc/resolv.conf；权重为0则熔断该节点',
-  'upstream.step.input.domain.name.or.ip': '请输入域名/IP',
-  'upstream.step.domain.name.or.ip.rule': '仅支持字母、数字和 . ',
-  'upstream.step.domain.name.or.ip': '域名/IP',
-  'upstream.step.input.port': '请输入端口号',
-  'upstream.step.port': '端口号',
-  'upstream.step.input.weight': '请输入权重',
-  'upstream.step.weight': '权重',
-  'upstream.step.create': '创建',
-  'upstream.step.name': '名称',
-  'upstream.step.name.should.unique': '名称需全局唯一',
-  'upstream.step.input.upstream.name': '请输入上游名称',
-  'upstream.step.description': '描述',
-  'upstream.step.input.description': '请输入描述',
-  'upstream.step.type': '类型',
-  'upstream.step.pass-host': '传递域名',
-  'upstream.step.pass-host.tips': '当选择节点时，节点域名只能有一条数据。',
-  'upstream.step.pass-host.pass': '透传',
-  'upstream.step.pass-host.node': '节点',
-  'upstream.step.pass-host.rewrite': '重写',
-  'upstream.step.pass-host.upstream_host': '上游域名',
-  'upstream.step.connect.timeout': '连接超时',
-  'upstream.step.input.connect.timeout': '请输入连接超时时间',
-  'upstream.step.send.timeout': '发送超时',
-  'upstream.step.input.send.timeout': '请输入发送超时时间',
-  'upstream.step.read.timeout': '接收超时',
-  'upstream.step.input.read.timeout': '请输入接收超时时间',
-  'upstream.step.healthy.check': '上游健康检查',
-  'upstream.step.healthy.checks.healthy': '健康',
-  'upstream.step.healthy.checks.unhealthy': '不健康',
-  'upstream.step.healthy.checks.active': '探活健康检查',
-  'upstream.step.healthy.checks.active.timeout': '超时时间',
-  'upstream.step.input.healthy.checks.active.timeout': '请输入超时时间',
-  'upstream.step.healthy.checks.active.http_path': '路径',
-  'upstream.step.input.healthy.checks.active.http_path': '请输入路径',
-  'upstream.step.healthy.checks.active.port': "端口",
-  'upstream.step.input.healthy.checks.active.port': '请输入端口',
-  'upstream.step.healthy.checks.active.host': '域名',
-  'upstream.step.input.healthy.checks.active.host': '请输入域名',
-  'upstream.step.healthy.checks.active.interval': '间隔',
-  'upstream.step.input.healthy.checks.active.interval': '请输入间隔',
-  'upstream.step.healthy.checks.successes': '成功次数',
-  'upstream.step.input.healthy.checks.successes': '请输入成功次数',
-  'upstream.step.healthy.checks.http_failures': '失败次数',
-  'upstream.step.input.healthy.checks.http_failures': '请输入失败次数',
-  'upstream.step.healthy.checks.active.req_headers': '请求头',
-  'upstream.step.input.healthy.checks.active.req_headers': '请输入请求头',
-  'upstream.step.healthy.checks.passive': '被动健康检查',
-  'upstream.step.healthy.checks.passive.http_statuses': '状态码',
-  'upstream.step.input.healthy.checks.passive.http_statuses': '请输入状态码',
-  'upstream.step.healthy.checks.passive.tcp_failures': 'tcp失败次数',
-  'upstream.step.input.healthy.checks.passive.tcp_failures': '请输入tcp失败次数',
-  'upstream.notificationMessage.enableHealthCheckFirst': '请先启用探活健康检查。',
+  'page.upstream.step.input.domain.name.or.ip': '请输入域名/IP',
+  'page.upstream.step.domain.name.or.ip.rule': '仅支持字母、数字和 . ',
+  'page.upstream.step.domain.name.or.ip': '域名/IP',
+  'page.upstream.step.input.port': '请输入端口号',
+  'page.upstream.step.port': '端口号',
+  'page.upstream.step.input.weight': '请输入权重',
+  'page.upstream.step.weight': '权重',
+  'page.upstream.step.create': '创建',
+  'page.upstream.step.name': '名称',
+  'page.upstream.step.name.should.unique': '名称需全局唯一',
+  'page.upstream.step.input.upstream.name': '请输入上游名称',
+  'page.upstream.step.description': '描述',
+  'page.upstream.step.input.description': '请输入描述',
+  'page.upstream.step.type': '类型',
+  'page.upstream.step.create.node': '创建节点',
+  'page.upstream.step.pass-host': '传递域名',
+  'page.upstream.step.pass-host.tips': '当选择节点时，节点域名只能有一条数据。',
+  'page.upstream.step.pass-host.pass': '透传',
+  'page.upstream.step.pass-host.node': '节点',
+  'page.upstream.step.pass-host.rewrite': '重写',
+  'page.upstream.step.pass-host.upstream_host': '上游域名',
+  'page.upstream.step.connect.timeout': '连接超时',
+  'page.upstream.step.input.connect.timeout': '请输入连接超时时间',
+  'page.upstream.step.send.timeout': '发送超时',
+  'page.upstream.step.input.send.timeout': '请输入发送超时时间',
+  'page.upstream.step.read.timeout': '接收超时',
+  'page.upstream.step.input.read.timeout': '请输入接收超时时间',
+  'page.upstream.step.healthy.checks.healthy.check': '健康检查',
+  'page.upstream.step.healthy.check': '上游健康检查',
+  'page.upstream.step.healthy.checks.healthy': '健康',
+  'page.upstream.step.healthy.checks.unhealthy': '不健康',
+  'page.upstream.step.healthy.checks.healthy.status': '健康状态',
+  'page.upstream.step.healthy.checks.unhealthy.status': '不健康状态',
+  'page.upstream.step.healthy.checks.active': '探活健康检查',
+  'page.upstream.step.healthy.checks.active.timeout': '超时时间',
+  'page.upstream.step.input.healthy.checks.active.timeout': '请输入超时时间',
+  'page.upstream.step.healthy.checks.active.http_path': '路径',
+  'page.upstream.step.input.healthy.checks.active.http_path': '请输入路径',
+  'page.upstream.step.healthy.checks.active.port': "端口",
+  'page.upstream.step.input.healthy.checks.active.port': '请输入端口',
+  'page.upstream.step.healthy.checks.active.host': '域名',
+  'page.upstream.step.input.healthy.checks.active.host': '请输入域名',
+  'page.upstream.step.healthy.checks.active.interval': '间隔',
+  'page.upstream.step.input.healthy.checks.active.interval': '请输入间隔',
+  'page.upstream.step.healthy.checks.successes': '成功次数',
+  'page.upstream.step.input.healthy.checks.successes': '请输入成功次数',
+  'page.upstream.step.healthy.checks.http_failures': '失败次数',
+  'page.upstream.step.healthy.checks.active.create.req_headers': '创建请求头',
+  'page.upstream.step.input.healthy.checks.http_failures': '请输入失败次数',
+  'page.upstream.step.healthy.checks.active.req_headers': '请求头',
+  'page.upstream.step.input.healthy.checks.active.req_headers': '请输入请求头',
+  'page.upstream.step.healthy.checks.passive': '被动健康检查',
+  'page.upstream.step.healthy.checks.passive.create.http_statuses': '创建状态码',
+  'page.upstream.step.healthy.checks.passive.http_statuses': '状态码',
+  'page.upstream.step.input.healthy.checks.passive.http_statuses': '请输入状态码',
+  'page.upstream.step.healthy.checks.passive.tcp_failures': 'tcp失败次数',
+  'page.upstream.step.input.healthy.checks.passive.tcp_failures': '请输入tcp失败次数',
+  'page.upstream.notificationMessage.enableHealthCheckFirst': '请先启用探活健康检查。',
 
-  'upstream.create.edit': '编辑',
-  'upstream.create.create': '创建',
-  'upstream.create.upstream.successfully': '上游成功',
-  'upstream.create.basic.info': '基础信息',
-  'upstream.create.preview': '预览',
+  'page.upstream.create.edit': '编辑',
+  'page.upstream.create.create': '创建',
+  'page.upstream.create.upstream.successfully': '上游成功',
+  'page.upstream.create.basic.info': '基础信息',
+  'page.upstream.create.preview': '预览',
 
-  'upstream.list.name': '名称',
-  'upstream.list.type': '类型',
-  'upstream.list.description': '描述',
-  'upstream.list.edit.time': '编辑时间',
-  'upstream.list.operation': '操作',
-  'upstream.list.edit': '编辑',
-  'upstream.list.confirm.delete': '确定删除该条记录吗？',
-  'upstream.list.confirm': '确定',
-  'upstream.list.cancel': '取消',
-  'upstream.list.delete.successfully': '删除记录成功',
-  'upstream.list.delete': '删除',
-  'upstream.list': '上游列表',
-  'upstream.list.input': '请输入',
-  'upstream.list.create': '创建',
+  'page.upstream.list.name': '名称',
+  'page.upstream.list.type': '类型',
+  'page.upstream.list.description': '描述',
+  'page.upstream.list.edit.time': '编辑时间',
+  'page.upstream.list.operation': '操作',
+  'page.upstream.list.edit': '编辑',
+  'page.upstream.list.confirm.delete': '确定删除该条记录吗？',
+  'page.upstream.list.confirm': '确定',
+  'page.upstream.list.cancel': '取消',
+  'page.upstream.list.delete.successfully': '删除记录成功',
+  'page.upstream.list.delete': '删除',
+  'page.upstream.list': '上游列表',
+  'page.upstream.list.input': '请输入',
+  'page.upstream.list.create': '创建',

Review comment:
       @guoqqqi Please file a new PR after this PR is merged.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=h1) Report
   > Merging [#1097](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=desc) (047bfcb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/46bf1ef9cfe4f4c659752176424151bb4fc4952f?el=desc) (46bf1ef) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1097/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1097      +/-   ##
   ==========================================
   - Coverage   41.06%   41.00%   -0.06%     
   ==========================================
     Files          28       28              
     Lines        1773     1773              
   ==========================================
   - Hits          728      727       -1     
   - Misses        939      940       +1     
     Partials      106      106              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1097/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.57% <0.00%> (-0.65%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=footer). Last update [46bf1ef...047bfcb](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r548778152



##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -133,9 +133,9 @@ const UpstreamForm: React.FC<Props> = forwardRef(
               <Form.Item
                 required
                 key={field.key}
-                label={index === 0 && '节点域名/IP'}
+                label={index === 0 && formatMessage({ id: 'upstream.step.node.domain.or.ip' })}

Review comment:
       I recommend to name the key refer to:  [basicModule].[moduleName].[elementName].[...desc]
   
   ```suggestion
                   label={index === 0 && formatMessage({ id: 'page.upstream.form.itemLabel.nodeDomainOrIp' })}
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-751172123


   ping @guoqqqi 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749908753


   ![image](https://user-images.githubusercontent.com/2106987/102956161-9b2bd100-4512-11eb-8f32-657a4bf5f95a.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r548833278



##########
File path: web/src/locales/en-US/menu.ts
##########
@@ -58,6 +58,7 @@ export default {
   'menu.account': 'Account',
   'menu.account.center': 'Account Center',
   'menu.account.settings': 'Account Settings',
+  'menu.account.setting.modify.settings': 'Settings',

Review comment:
       The little hump writing style doesn't seem to fit here, so I changed it to ‘menu.account.modify-settings': 'Modify Settings'




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=h1) Report
   > Merging [#1097](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=desc) (c26a720) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/46bf1ef9cfe4f4c659752176424151bb4fc4952f?el=desc) (46bf1ef) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1097/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1097      +/-   ##
   ==========================================
   - Coverage   41.06%   41.00%   -0.06%     
   ==========================================
     Files          28       28              
     Lines        1773     1773              
   ==========================================
   - Hits          728      727       -1     
   - Misses        939      940       +1     
     Partials      106      106              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1097/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.57% <0.00%> (-0.65%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=footer). Last update [46bf1ef...c26a720](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1097: feat: improve upstream i18n

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=h1) Report
   > Merging [#1097](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=desc) (5b1aa30) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/822aa6d1f40c5eb5bfef00030304eb5b619a9eea?el=desc) (822aa6d) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1097/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1097   +/-   ##
   =======================================
     Coverage   42.30%   42.30%           
   =======================================
     Files          31       31           
     Lines        1924     1924           
   =======================================
     Hits          814      814           
     Misses       1000     1000           
     Partials      110      110           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=footer). Last update [822aa6d...5b1aa30](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1097: feat: improve upstream i18n

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=h1) Report
   > Merging [#1097](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=desc) (71d930b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b194c6181c5c2be4d12b5d3e9648b68217c146f4?el=desc) (b194c61) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1097/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1097   +/-   ##
   =======================================
     Coverage   42.07%   42.07%           
   =======================================
     Files          30       30           
     Lines        1856     1856           
   =======================================
     Hits          781      781           
     Misses        965      965           
     Partials      110      110           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=footer). Last update [b194c61...71d930b](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1097: feat: improve upstream i18n

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=h1) Report
   > Merging [#1097](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=desc) (e83c236) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b194c6181c5c2be4d12b5d3e9648b68217c146f4?el=desc) (b194c61) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1097/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1097   +/-   ##
   =======================================
     Coverage   42.07%   42.07%           
   =======================================
     Files          30       30           
     Lines        1856     1856           
   =======================================
     Hits          781      781           
     Misses        965      965           
     Partials      110      110           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=footer). Last update [b194c61...e83c236](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r548837674



##########
File path: web/src/locales/en-US/menu.ts
##########
@@ -58,6 +58,7 @@ export default {
   'menu.account': 'Account',
   'menu.account.center': 'Account Center',
   'menu.account.settings': 'Account Settings',
+  'menu.account.setting.modify.settings': 'Settings',

Review comment:
       Please keep using `Settings` here, for most dashboards, `Setting` is used universal.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=h1) Report
   > Merging [#1097](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=desc) (283fc41) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6fa6a16559a1c1d0e90de4a3277a3db6e73cb9fc?el=desc) (6fa6a16) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1097/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1097   +/-   ##
   =======================================
     Coverage   42.12%   42.12%           
   =======================================
     Files          29       29           
     Lines        1816     1816           
   =======================================
     Hits          765      765           
     Misses        943      943           
     Partials      108      108           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=footer). Last update [6fa6a16...283fc41](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r548778970



##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -133,9 +133,9 @@ const UpstreamForm: React.FC<Props> = forwardRef(
               <Form.Item
                 required
                 key={field.key}
-                label={index === 0 && '节点域名/IP'}
+                label={index === 0 && formatMessage({ id: 'upstream.step.node.domain.or.ip' })}
                 extra={
-                  index === 0 && '使用域名时，默认解析本地 /etc/resolv.conf；权重为0则熔断该节点'
+                  index === 0 && formatMessage({ id: 'upstream.step.domain.name.default.analysis' })

Review comment:
       ```suggestion
                     index === 0 && formatMessage({ id: 'page.upstream.form.itemExtraMesage.nodeDomainOrIp' })
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r548776156



##########
File path: web/src/locales/zh-CN/menu.ts
##########
@@ -58,6 +58,7 @@ export default {
   'menu.account': '个人页',
   'menu.account.center': '个人中心',
   'menu.account.settings': '个人设置',
+  'menu.account.setting.modify.settings': '修改设置',

Review comment:
       ```suggestion
     'menu.account.modifySettings': '修改设置',
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=h1) Report
   > Merging [#1097](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=desc) (047025d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/46bf1ef9cfe4f4c659752176424151bb4fc4952f?el=desc) (46bf1ef) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1097/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1097   +/-   ##
   =======================================
     Coverage   41.06%   41.06%           
   =======================================
     Files          28       28           
     Lines        1773     1773           
   =======================================
     Hits          728      728           
     Misses        939      939           
     Partials      106      106           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=footer). Last update [46bf1ef...047025d](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=h1) Report
   > Merging [#1097](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=desc) (8853afd) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0e6e2805362a8dc9b83f56f53be17f12a8ddbacf?el=desc) (0e6e280) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1097/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1097   +/-   ##
   =======================================
     Coverage   41.94%   41.94%           
   =======================================
     Files          29       29           
     Lines        1824     1824           
   =======================================
     Hits          765      765           
     Misses        951      951           
     Partials      108      108           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=footer). Last update [0e6e280...8853afd](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#discussion_r548778970



##########
File path: web/src/components/Upstream/UpstreamForm.tsx
##########
@@ -133,9 +133,9 @@ const UpstreamForm: React.FC<Props> = forwardRef(
               <Form.Item
                 required
                 key={field.key}
-                label={index === 0 && '节点域名/IP'}
+                label={index === 0 && formatMessage({ id: 'upstream.step.node.domain.or.ip' })}
                 extra={
-                  index === 0 && '使用域名时，默认解析本地 /etc/resolv.conf；权重为0则熔断该节点'
+                  index === 0 && formatMessage({ id: 'upstream.step.domain.name.default.analysis' })

Review comment:
       ```suggestion
                     index === 0 && formatMessage({ id: 'page.upstream.form.itemExtraMessage.nodeDomainOrIp' })
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1097: feat: "upstream" i18n

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1097:
URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-751136291


   ping @LiteSun @liuxiran 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org