You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by duncangrant <gi...@git.apache.org> on 2017/03/24 09:17:51 UTC
[GitHub] brooklyn-server pull request #609: HttpCommandEffector allows string payload
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-server/pull/609
HttpCommandEffector allows string payload
Also fixed integration tests that failing due to https://httpbin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/duncangrant/brooklyn-server command-effector-handle-strings
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/609.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #609
----
commit 1c064b284757ed0c794cbf8f3a6d65e34564af3a
Author: Duncan Grant <du...@cloudsoftcorp.com>
Date: 2017-03-24T09:15:47Z
HttpCommandEffector allows string payload
Also fixed integration tests that failing due to https://httpbin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #609: HttpCommandEffector allows string payload
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/609
@duncangrant You beat me to fixing the integration tests. I went for replacing `httpbin.org` with a local server, changing the integration tests to unit tests. See https://github.com/apache/brooklyn-server/pull/610.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #609: HttpCommandEffector allows string payload
Posted by duncangrant <gi...@git.apache.org>.
Github user duncangrant commented on the issue:
https://github.com/apache/brooklyn-server/pull/609
@neykov I thought about doing something similar but it looked too much like hard work. Agreed that you approach is the way to go especially as it allows more of those tests to be run as unit tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #609: HttpCommandEffector allows string payload
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/609
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---