You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Pil0tXia (via GitHub)" <gi...@apache.org> on 2023/10/16 09:42:13 UTC
[PR] [ISSUE #4489] Migrate eventmesh-admin module (eventmesh)
Pil0tXia opened a new pull request, #4490:
URL: https://github.com/apache/eventmesh/pull/4490
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #4489.
### Motivation
The `/topicManage` endpoint in the old admin module, which is not implemented and not used in the dashboard, has the same function as the `/topic` endpoint in `runtime.admin`. Therefore, it will be replaced by the new admin module.
### Modifications
Replace `eventmesh-admin` module with the `eventmesh-console` module.
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4489] Migrate eventmesh-admin module (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo merged PR #4490:
URL: https://github.com/apache/eventmesh/pull/4490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4489] Migrate eventmesh-admin module (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4490:
URL: https://github.com/apache/eventmesh/pull/4490#issuecomment-1765600707
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4490?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4490](https://app.codecov.io/gh/apache/eventmesh/pull/4490?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d97b4e2) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/093fb6b3c5eaf25509ad8ca2f003dd0e58d0257d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (093fb6b) will **decrease** coverage by `0.12%`.
> Report is 1 commits behind head on master.
> The diff coverage is `0.00%`.
> :exclamation: Current head d97b4e2 differs from pull request most recent head c047820. Consider uploading reports for the commit c047820 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4490 +/- ##
============================================
- Coverage 15.59% 15.47% -0.12%
+ Complexity 1476 1453 -23
============================================
Files 698 691 -7
Lines 28205 28094 -111
Branches 2633 2624 -9
============================================
- Hits 4398 4347 -51
+ Misses 23360 23301 -59
+ Partials 447 446 -1
```
| [Files](https://app.codecov.io/gh/apache/eventmesh/pull/4490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ntime/admin/controller/ClientManageController.java](https://app.codecov.io/gh/apache/eventmesh/pull/4490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2NvbnRyb2xsZXIvQ2xpZW50TWFuYWdlQ29udHJvbGxlci5qYXZh) | `97.77% <ø> (-0.10%)` | :arrow_down: |
| [...che/eventmesh/runtime/boot/AbstractHTTPServer.java](https://app.codecov.io/gh/apache/eventmesh/pull/4490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvQWJzdHJhY3RIVFRQU2VydmVyLmphdmE=) | `1.53% <ø> (ø)` | |
| [...he/eventmesh/runtime/boot/EventMeshHTTPServer.java](https://app.codecov.io/gh/apache/eventmesh/pull/4490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoSFRUUFNlcnZlci5qYXZh) | `0.68% <0.00%> (ø)` | |
| [...he/eventmesh/runtime/boot/HTTPThreadPoolGroup.java](https://app.codecov.io/gh/apache/eventmesh/pull/4490?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvSFRUUFRocmVhZFBvb2xHcm91cC5qYXZh) | `0.00% <0.00%> (ø)` | |
... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4490/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org