You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2017/12/03 18:48:47 UTC

[GitHub] sungjunyoung commented on issue #2927: bash kind action

sungjunyoung commented on issue #2927: bash kind action
URL: https://github.com/apache/incubator-openwhisk/issues/2927#issuecomment-348804845
 
 
   @rabbah Can I get some information about discussion of this issue? The use of `jq` and the use of `recursively registered env vars` each seem to have pros and cons. 
   
   1. use of `jq`
   	 * pros
   		 * Users who are familiar with `jq` are easy to use.
   		 * Not need to touch the `dockerskeleton` unless to install `jq` on the docker.
   	 * cons
   		 * Users who are unfamiliar with `jq` are hard to use
   		 * `jq` can parse deep depth `JSON`, But  users who want to use the `bash action` do not usually request complex parameters.
   
   2. use of `recursively registered env vars` with `auto boxing`
   	* pros
   		* Users do not have to think about `JSON` parsing in the bash script.
   		* If users want to return simple string (ok / fail), Also Users do not have to think about `JSON` formatting to response
   		* Not need to install `jq` in docker
   	* cons
   		* New docker image should be pushed to [openwhisk dockerhub repository](https://hub.docker.com/search/?isAutomated=0&isOfficial=0&page=1&pullCount=0&q=openwhisk&starCount=0) for support `kind ?-bash` in the following way [that commented](https://github.com/apache/incubator-openwhisk/issues/2927#issuecomment-347018584)
   
   If `dockerfile` that I modified pushed to [openwhisk dockerhub repository](https://hub.docker.com/search/?isAutomated=0&isOfficial=0&page=1&pullCount=0&q=openwhisk&starCount=0), I think I can test and send PR for more discussion. What do you think about this?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services