You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/01 00:33:54 UTC

[kudu-CR] [clock] add unit tests for FindIntersection() function

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14327


Change subject: [clock] add unit tests for FindIntersection() function
......................................................................

[clock] add unit tests for FindIntersection() function

This patch factors out the FindIntersection() function from the
BuiltInNtp class and adds unit tests to cover its functionality.

The FindIntersection() algorithm implements a version of the Marzullo's
algorithm:
  https://www.eecis.udel.edu/~mills/ntp/html/select.html

Change-Id: I7ba41889360f55320631d24ec8d0a65ba657ef40
---
M src/kudu/clock/CMakeLists.txt
A src/kudu/clock/builtin_ntp-internal.cc
A src/kudu/clock/builtin_ntp-internal.h
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/builtin_ntp.h
M src/kudu/clock/ntp-test.cc
6 files changed, 461 insertions(+), 84 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/14327/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ba41889360f55320631d24ec8d0a65ba657ef40
Gerrit-Change-Number: 14327
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [clock] add unit tests for FindIntersection() function

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14327

to look at the new patch set (#2).

Change subject: [clock] add unit tests for FindIntersection() function
......................................................................

[clock] add unit tests for FindIntersection() function

This patch factors out the FindIntersection() function from the
BuiltInNtp class and adds unit tests to cover its functionality.

The FindIntersection() algorithm implements a version of the Marzullo's
algorithm:
  https://www.eecis.udel.edu/~mills/ntp/html/select.html

Change-Id: I7ba41889360f55320631d24ec8d0a65ba657ef40
---
M src/kudu/clock/CMakeLists.txt
A src/kudu/clock/builtin_ntp-internal.cc
A src/kudu/clock/builtin_ntp-internal.h
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/builtin_ntp.h
M src/kudu/clock/ntp-test.cc
6 files changed, 511 insertions(+), 84 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/14327/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ba41889360f55320631d24ec8d0a65ba657ef40
Gerrit-Change-Number: 14327
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [clock] add unit tests for FindIntersection() function

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14327 )

Change subject: [clock] add unit tests for FindIntersection() function
......................................................................


Patch Set 2: Verified+1

Unrelated test failure:
  * TableLocationsTest.GetTableLocationsBenchmark


-- 
To view, visit http://gerrit.cloudera.org:8080/14327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ba41889360f55320631d24ec8d0a65ba657ef40
Gerrit-Change-Number: 14327
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 01:48:36 +0000
Gerrit-HasComments: No

[kudu-CR] [clock] add unit tests for FindIntersection() function

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14327 )

Change subject: [clock] add unit tests for FindIntersection() function
......................................................................

[clock] add unit tests for FindIntersection() function

This patch factors out the FindIntersection() function from the
BuiltInNtp class and adds unit tests to cover its functionality.

The FindIntersection() algorithm implements a version of the Marzullo's
algorithm:
  https://www.eecis.udel.edu/~mills/ntp/html/select.html

Change-Id: I7ba41889360f55320631d24ec8d0a65ba657ef40
Reviewed-on: http://gerrit.cloudera.org:8080/14327
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/clock/CMakeLists.txt
A src/kudu/clock/builtin_ntp-internal.cc
A src/kudu/clock/builtin_ntp-internal.h
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/builtin_ntp.h
M src/kudu/clock/ntp-test.cc
6 files changed, 511 insertions(+), 84 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ba41889360f55320631d24ec8d0a65ba657ef40
Gerrit-Change-Number: 14327
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [clock] add unit tests for FindIntersection() function

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14327 )

Change subject: [clock] add unit tests for FindIntersection() function
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ba41889360f55320631d24ec8d0a65ba657ef40
Gerrit-Change-Number: 14327
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2019 04:04:51 +0000
Gerrit-HasComments: No

[kudu-CR] [clock] add unit tests for FindIntersection() function

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/14327 )

Change subject: [clock] add unit tests for FindIntersection() function
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/14327
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I7ba41889360f55320631d24ec8d0a65ba657ef40
Gerrit-Change-Number: 14327
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>