You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Steven Gill <st...@gmail.com> on 2014/04/04 10:00:09 UTC
[VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Please review and vote on the release of this cordova-cli, cordova-plugman
and cordova-ios release.
cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1 have
been published here:
*https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
<https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
The packages were published from their corresponding git tags:
cordova-cli: 3.4.1-0.1.0 (b769a304be)
cordova-plugman: 0.21.0 (b2f3a130d3)
cordova-ios: 3.4.1 (a96d2360fa)
Upon a successful vote I will upload the cli & plugman archives to dist/
and publish them to npm. Cordova-ios will be uploaded to dist/platforms. I
will then post the corresponding blog post.
Voting will go on for a minimum of 24 hours.
I vote +1.
If people want individual vote threads for each item, let me know and I
will create them instead of this thread.
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Ian Clelland <ic...@chromium.org>.
Okay, that makes sense :)
I figured it would work if we changed both of those manually, and it's good
to have confirmation of that. Thanks
Ian
On Fri, Apr 4, 2014 at 11:40 AM, Marc Weiner <mh...@gmail.com> wrote:
> Sorry, it's early :-/ I meant the declared dependency in the cli's package
> and npm-shrinkwrap files.
>
>
> On Fri, Apr 4, 2014 at 11:40 AM, Marc Weiner <mh...@gmail.com>
> wrote:
>
> > Sorry for not specifying. I was getting a 404 during the install, so I
> > changed the version of plugman in the package.json and
> npm-shrinkwrap.json
> > files.
> >
> > Marc
> >
> >
> > On Fri, Apr 4, 2014 at 11:28 AM, Ian Clelland <iclelland@chromium.org
> >wrote:
> >
> >> Marc, was that change to the actual version of plugman, in plugman's
> >> package.json file? Or the declared dependency in cli's package.json?
> >>
> >>
> >>
> >> On Fri, Apr 4, 2014 at 11:25 AM, Marc Weiner <mh...@gmail.com>
> >> wrote:
> >>
> >> > I was able to get npm install to work by changing the version of
> plugman
> >> > from 0.21.0 to 0.21.2.
> >> >
> >> > Marc
> >> >
> >> >
> >> > On Fri, Apr 4, 2014 at 11:19 AM, Ian Clelland <iclelland@chromium.org
> >> > >wrote:
> >> >
> >> > > After some heated discussion here, we're pretty sure that that's the
> >> > > problem with the CI, and that it's not going to work if we release
> it
> >> > > as-is. :(
> >> > >
> >> > > The really awful thing is that it doesn't look like it's possible to
> >> use
> >> > > package.json and npm-shrinkwrap.json properly, and end up with a
> >> release
> >> > > candidate that works *now*, and also works when the packages are
> >> actually
> >> > > released to npm.
> >> > >
> >> > > (If npm-shrinkwrap.json properly points to v0.21.0, then it won't
> >> install
> >> > > until that gets released. If we release v0.21.0-rc1, and point
> >> shrinkwrap
> >> > > to that, then it won't download 0.21.0 when we release it. And if we
> >> > > release 0.21.0 on npm before the vote, and it gets voted down, then
> we
> >> > > start burning through version numbers until the vote passes)
> >> > >
> >> > > However, we do need to produce *something* that we can vote on, and
> I
> >> > think
> >> > > it needs to be the version that works after the packages are
> released,
> >> > even
> >> > > if it requires some hackery to test it before then.
> >> > >
> >> > > I think the best thing that we can do in the situation is this:
> >> > > * Make CLI's npm-shrinkwrap.json point to the version that doesn't
> >> > exist
> >> > > yet on npm -- {"version": "0.21.0", "from": "cordova-plugman@0.21.0
> "}
> >> > > * Make CLI's package.json depend on any version of plugman
> >> > ">=0.21.0-rc"
> >> > > * Sign and release that for a vote.
> >> > > * Everyone can download it, and just remove npm-shrinkwrap.json
> >> before
> >> > > running npm-install. That should install correctly, and we can test
> >> the
> >> > > tools.
> >> > > * Once it passes, we publish cli and plugman to npm with the
> correct
> >> > > version numbers, and it will install correctly for end users.
> >> > >
> >> > >
> >> > >
> >> > >
> >> > > On Fri, Apr 4, 2014 at 10:47 AM, Ian Clelland <
> iclelland@chromium.org
> >> > > >wrote:
> >> > >
> >> > > > There may be a packaging error with cli -- the npm-shrinkwrap.json
> >> file
> >> > > > specifies a relative file path, that I think will stop "npm
> install"
> >> > from
> >> > > > working on cli:
> >> > > >
> >> > > > ...
> >> > > > "plugman": {
> >> > > > "version": "0.21.0",
> >> > > > "from": "../cordova-plugman",
> >> > > > ...
> >> > > >
> >> > > > (It doesn't stop it from working completely; it actually did work
> >> for
> >> > me
> >> > > > the first time, but that's just because I actually *had* a
> >> > > cordova-plugman
> >> > > > directory right beside my cordova-cli directory, and I had
> >> specifically
> >> > > > checked out the 0.21.0 tag. It has been failing the CI tests,
> >> though,
> >> > and
> >> > > > we haven't been able to get it to install correctly when checked
> out
> >> > > into a
> >> > > > new directory)
> >> > > >
> >> > > > I'm -1 until we can fix that, sorry. :(
> >> > > >
> >> > > > (Or until we determine that it's not actually the problem)
> >> > > >
> >> > > >
> >> > > >
> >> > > > On Fri, Apr 4, 2014 at 4:05 AM, Sebastien Blanc <
> >> scm.blanc@gmail.com
> >> > > >wrote:
> >> > > >
> >> > > >> +1
> >> > > >>
> >> > > >>
> >> > > >> On Fri, Apr 4, 2014 at 10:00 AM, Steven Gill <
> >> stevengill97@gmail.com>
> >> > > >> wrote:
> >> > > >>
> >> > > >> > Please review and vote on the release of this cordova-cli,
> >> > > >> cordova-plugman
> >> > > >> > and cordova-ios release.
> >> > > >> >
> >> > > >> > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
> >> > > cordova-ios@3.4.1have
> >> > > >> > been published here:
> >> > > >> > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> >> > > >> > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
> >> > > >> >
> >> > > >> >
> >> > > >> > The packages were published from their corresponding git tags:
> >> > > >> > cordova-cli: 3.4.1-0.1.0 (b769a304be)
> >> > > >> > cordova-plugman: 0.21.0 (b2f3a130d3)
> >> > > >> > cordova-ios: 3.4.1 (a96d2360fa)
> >> > > >> >
> >> > > >> > Upon a successful vote I will upload the cli & plugman archives
> >> to
> >> > > dist/
> >> > > >> > and publish them to npm. Cordova-ios will be uploaded to
> >> > > >> dist/platforms. I
> >> > > >> > will then post the corresponding blog post.
> >> > > >> >
> >> > > >> > Voting will go on for a minimum of 24 hours.
> >> > > >> >
> >> > > >> > I vote +1.
> >> > > >> >
> >> > > >> > If people want individual vote threads for each item, let me
> know
> >> > and
> >> > > I
> >> > > >> > will create them instead of this thread.
> >> > > >> >
> >> > > >>
> >> > > >
> >> > > >
> >> > >
> >> >
> >>
> >
> >
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Marc Weiner <mh...@gmail.com>.
Sorry, it's early :-/ I meant the declared dependency in the cli's package
and npm-shrinkwrap files.
On Fri, Apr 4, 2014 at 11:40 AM, Marc Weiner <mh...@gmail.com> wrote:
> Sorry for not specifying. I was getting a 404 during the install, so I
> changed the version of plugman in the package.json and npm-shrinkwrap.json
> files.
>
> Marc
>
>
> On Fri, Apr 4, 2014 at 11:28 AM, Ian Clelland <ic...@chromium.org>wrote:
>
>> Marc, was that change to the actual version of plugman, in plugman's
>> package.json file? Or the declared dependency in cli's package.json?
>>
>>
>>
>> On Fri, Apr 4, 2014 at 11:25 AM, Marc Weiner <mh...@gmail.com>
>> wrote:
>>
>> > I was able to get npm install to work by changing the version of plugman
>> > from 0.21.0 to 0.21.2.
>> >
>> > Marc
>> >
>> >
>> > On Fri, Apr 4, 2014 at 11:19 AM, Ian Clelland <iclelland@chromium.org
>> > >wrote:
>> >
>> > > After some heated discussion here, we're pretty sure that that's the
>> > > problem with the CI, and that it's not going to work if we release it
>> > > as-is. :(
>> > >
>> > > The really awful thing is that it doesn't look like it's possible to
>> use
>> > > package.json and npm-shrinkwrap.json properly, and end up with a
>> release
>> > > candidate that works *now*, and also works when the packages are
>> actually
>> > > released to npm.
>> > >
>> > > (If npm-shrinkwrap.json properly points to v0.21.0, then it won't
>> install
>> > > until that gets released. If we release v0.21.0-rc1, and point
>> shrinkwrap
>> > > to that, then it won't download 0.21.0 when we release it. And if we
>> > > release 0.21.0 on npm before the vote, and it gets voted down, then we
>> > > start burning through version numbers until the vote passes)
>> > >
>> > > However, we do need to produce *something* that we can vote on, and I
>> > think
>> > > it needs to be the version that works after the packages are released,
>> > even
>> > > if it requires some hackery to test it before then.
>> > >
>> > > I think the best thing that we can do in the situation is this:
>> > > * Make CLI's npm-shrinkwrap.json point to the version that doesn't
>> > exist
>> > > yet on npm -- {"version": "0.21.0", "from": "cordova-plugman@0.21.0"}
>> > > * Make CLI's package.json depend on any version of plugman
>> > ">=0.21.0-rc"
>> > > * Sign and release that for a vote.
>> > > * Everyone can download it, and just remove npm-shrinkwrap.json
>> before
>> > > running npm-install. That should install correctly, and we can test
>> the
>> > > tools.
>> > > * Once it passes, we publish cli and plugman to npm with the correct
>> > > version numbers, and it will install correctly for end users.
>> > >
>> > >
>> > >
>> > >
>> > > On Fri, Apr 4, 2014 at 10:47 AM, Ian Clelland <iclelland@chromium.org
>> > > >wrote:
>> > >
>> > > > There may be a packaging error with cli -- the npm-shrinkwrap.json
>> file
>> > > > specifies a relative file path, that I think will stop "npm install"
>> > from
>> > > > working on cli:
>> > > >
>> > > > ...
>> > > > "plugman": {
>> > > > "version": "0.21.0",
>> > > > "from": "../cordova-plugman",
>> > > > ...
>> > > >
>> > > > (It doesn't stop it from working completely; it actually did work
>> for
>> > me
>> > > > the first time, but that's just because I actually *had* a
>> > > cordova-plugman
>> > > > directory right beside my cordova-cli directory, and I had
>> specifically
>> > > > checked out the 0.21.0 tag. It has been failing the CI tests,
>> though,
>> > and
>> > > > we haven't been able to get it to install correctly when checked out
>> > > into a
>> > > > new directory)
>> > > >
>> > > > I'm -1 until we can fix that, sorry. :(
>> > > >
>> > > > (Or until we determine that it's not actually the problem)
>> > > >
>> > > >
>> > > >
>> > > > On Fri, Apr 4, 2014 at 4:05 AM, Sebastien Blanc <
>> scm.blanc@gmail.com
>> > > >wrote:
>> > > >
>> > > >> +1
>> > > >>
>> > > >>
>> > > >> On Fri, Apr 4, 2014 at 10:00 AM, Steven Gill <
>> stevengill97@gmail.com>
>> > > >> wrote:
>> > > >>
>> > > >> > Please review and vote on the release of this cordova-cli,
>> > > >> cordova-plugman
>> > > >> > and cordova-ios release.
>> > > >> >
>> > > >> > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
>> > > cordova-ios@3.4.1have
>> > > >> > been published here:
>> > > >> > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
>> > > >> > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
>> > > >> >
>> > > >> >
>> > > >> > The packages were published from their corresponding git tags:
>> > > >> > cordova-cli: 3.4.1-0.1.0 (b769a304be)
>> > > >> > cordova-plugman: 0.21.0 (b2f3a130d3)
>> > > >> > cordova-ios: 3.4.1 (a96d2360fa)
>> > > >> >
>> > > >> > Upon a successful vote I will upload the cli & plugman archives
>> to
>> > > dist/
>> > > >> > and publish them to npm. Cordova-ios will be uploaded to
>> > > >> dist/platforms. I
>> > > >> > will then post the corresponding blog post.
>> > > >> >
>> > > >> > Voting will go on for a minimum of 24 hours.
>> > > >> >
>> > > >> > I vote +1.
>> > > >> >
>> > > >> > If people want individual vote threads for each item, let me know
>> > and
>> > > I
>> > > >> > will create them instead of this thread.
>> > > >> >
>> > > >>
>> > > >
>> > > >
>> > >
>> >
>>
>
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Marc Weiner <mh...@gmail.com>.
Sorry for not specifying. I was getting a 404 during the install, so I
changed the version of plugman in the package.json and npm-shrinkwrap.json
files.
Marc
On Fri, Apr 4, 2014 at 11:28 AM, Ian Clelland <ic...@chromium.org>wrote:
> Marc, was that change to the actual version of plugman, in plugman's
> package.json file? Or the declared dependency in cli's package.json?
>
>
>
> On Fri, Apr 4, 2014 at 11:25 AM, Marc Weiner <mh...@gmail.com>
> wrote:
>
> > I was able to get npm install to work by changing the version of plugman
> > from 0.21.0 to 0.21.2.
> >
> > Marc
> >
> >
> > On Fri, Apr 4, 2014 at 11:19 AM, Ian Clelland <iclelland@chromium.org
> > >wrote:
> >
> > > After some heated discussion here, we're pretty sure that that's the
> > > problem with the CI, and that it's not going to work if we release it
> > > as-is. :(
> > >
> > > The really awful thing is that it doesn't look like it's possible to
> use
> > > package.json and npm-shrinkwrap.json properly, and end up with a
> release
> > > candidate that works *now*, and also works when the packages are
> actually
> > > released to npm.
> > >
> > > (If npm-shrinkwrap.json properly points to v0.21.0, then it won't
> install
> > > until that gets released. If we release v0.21.0-rc1, and point
> shrinkwrap
> > > to that, then it won't download 0.21.0 when we release it. And if we
> > > release 0.21.0 on npm before the vote, and it gets voted down, then we
> > > start burning through version numbers until the vote passes)
> > >
> > > However, we do need to produce *something* that we can vote on, and I
> > think
> > > it needs to be the version that works after the packages are released,
> > even
> > > if it requires some hackery to test it before then.
> > >
> > > I think the best thing that we can do in the situation is this:
> > > * Make CLI's npm-shrinkwrap.json point to the version that doesn't
> > exist
> > > yet on npm -- {"version": "0.21.0", "from": "cordova-plugman@0.21.0"}
> > > * Make CLI's package.json depend on any version of plugman
> > ">=0.21.0-rc"
> > > * Sign and release that for a vote.
> > > * Everyone can download it, and just remove npm-shrinkwrap.json
> before
> > > running npm-install. That should install correctly, and we can test the
> > > tools.
> > > * Once it passes, we publish cli and plugman to npm with the correct
> > > version numbers, and it will install correctly for end users.
> > >
> > >
> > >
> > >
> > > On Fri, Apr 4, 2014 at 10:47 AM, Ian Clelland <iclelland@chromium.org
> > > >wrote:
> > >
> > > > There may be a packaging error with cli -- the npm-shrinkwrap.json
> file
> > > > specifies a relative file path, that I think will stop "npm install"
> > from
> > > > working on cli:
> > > >
> > > > ...
> > > > "plugman": {
> > > > "version": "0.21.0",
> > > > "from": "../cordova-plugman",
> > > > ...
> > > >
> > > > (It doesn't stop it from working completely; it actually did work for
> > me
> > > > the first time, but that's just because I actually *had* a
> > > cordova-plugman
> > > > directory right beside my cordova-cli directory, and I had
> specifically
> > > > checked out the 0.21.0 tag. It has been failing the CI tests, though,
> > and
> > > > we haven't been able to get it to install correctly when checked out
> > > into a
> > > > new directory)
> > > >
> > > > I'm -1 until we can fix that, sorry. :(
> > > >
> > > > (Or until we determine that it's not actually the problem)
> > > >
> > > >
> > > >
> > > > On Fri, Apr 4, 2014 at 4:05 AM, Sebastien Blanc <scm.blanc@gmail.com
> > > >wrote:
> > > >
> > > >> +1
> > > >>
> > > >>
> > > >> On Fri, Apr 4, 2014 at 10:00 AM, Steven Gill <
> stevengill97@gmail.com>
> > > >> wrote:
> > > >>
> > > >> > Please review and vote on the release of this cordova-cli,
> > > >> cordova-plugman
> > > >> > and cordova-ios release.
> > > >> >
> > > >> > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
> > > cordova-ios@3.4.1have
> > > >> > been published here:
> > > >> > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> > > >> > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
> > > >> >
> > > >> >
> > > >> > The packages were published from their corresponding git tags:
> > > >> > cordova-cli: 3.4.1-0.1.0 (b769a304be)
> > > >> > cordova-plugman: 0.21.0 (b2f3a130d3)
> > > >> > cordova-ios: 3.4.1 (a96d2360fa)
> > > >> >
> > > >> > Upon a successful vote I will upload the cli & plugman archives to
> > > dist/
> > > >> > and publish them to npm. Cordova-ios will be uploaded to
> > > >> dist/platforms. I
> > > >> > will then post the corresponding blog post.
> > > >> >
> > > >> > Voting will go on for a minimum of 24 hours.
> > > >> >
> > > >> > I vote +1.
> > > >> >
> > > >> > If people want individual vote threads for each item, let me know
> > and
> > > I
> > > >> > will create them instead of this thread.
> > > >> >
> > > >>
> > > >
> > > >
> > >
> >
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Ian Clelland <ic...@chromium.org>.
Marc, was that change to the actual version of plugman, in plugman's
package.json file? Or the declared dependency in cli's package.json?
On Fri, Apr 4, 2014 at 11:25 AM, Marc Weiner <mh...@gmail.com> wrote:
> I was able to get npm install to work by changing the version of plugman
> from 0.21.0 to 0.21.2.
>
> Marc
>
>
> On Fri, Apr 4, 2014 at 11:19 AM, Ian Clelland <iclelland@chromium.org
> >wrote:
>
> > After some heated discussion here, we're pretty sure that that's the
> > problem with the CI, and that it's not going to work if we release it
> > as-is. :(
> >
> > The really awful thing is that it doesn't look like it's possible to use
> > package.json and npm-shrinkwrap.json properly, and end up with a release
> > candidate that works *now*, and also works when the packages are actually
> > released to npm.
> >
> > (If npm-shrinkwrap.json properly points to v0.21.0, then it won't install
> > until that gets released. If we release v0.21.0-rc1, and point shrinkwrap
> > to that, then it won't download 0.21.0 when we release it. And if we
> > release 0.21.0 on npm before the vote, and it gets voted down, then we
> > start burning through version numbers until the vote passes)
> >
> > However, we do need to produce *something* that we can vote on, and I
> think
> > it needs to be the version that works after the packages are released,
> even
> > if it requires some hackery to test it before then.
> >
> > I think the best thing that we can do in the situation is this:
> > * Make CLI's npm-shrinkwrap.json point to the version that doesn't
> exist
> > yet on npm -- {"version": "0.21.0", "from": "cordova-plugman@0.21.0"}
> > * Make CLI's package.json depend on any version of plugman
> ">=0.21.0-rc"
> > * Sign and release that for a vote.
> > * Everyone can download it, and just remove npm-shrinkwrap.json before
> > running npm-install. That should install correctly, and we can test the
> > tools.
> > * Once it passes, we publish cli and plugman to npm with the correct
> > version numbers, and it will install correctly for end users.
> >
> >
> >
> >
> > On Fri, Apr 4, 2014 at 10:47 AM, Ian Clelland <iclelland@chromium.org
> > >wrote:
> >
> > > There may be a packaging error with cli -- the npm-shrinkwrap.json file
> > > specifies a relative file path, that I think will stop "npm install"
> from
> > > working on cli:
> > >
> > > ...
> > > "plugman": {
> > > "version": "0.21.0",
> > > "from": "../cordova-plugman",
> > > ...
> > >
> > > (It doesn't stop it from working completely; it actually did work for
> me
> > > the first time, but that's just because I actually *had* a
> > cordova-plugman
> > > directory right beside my cordova-cli directory, and I had specifically
> > > checked out the 0.21.0 tag. It has been failing the CI tests, though,
> and
> > > we haven't been able to get it to install correctly when checked out
> > into a
> > > new directory)
> > >
> > > I'm -1 until we can fix that, sorry. :(
> > >
> > > (Or until we determine that it's not actually the problem)
> > >
> > >
> > >
> > > On Fri, Apr 4, 2014 at 4:05 AM, Sebastien Blanc <scm.blanc@gmail.com
> > >wrote:
> > >
> > >> +1
> > >>
> > >>
> > >> On Fri, Apr 4, 2014 at 10:00 AM, Steven Gill <st...@gmail.com>
> > >> wrote:
> > >>
> > >> > Please review and vote on the release of this cordova-cli,
> > >> cordova-plugman
> > >> > and cordova-ios release.
> > >> >
> > >> > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
> > cordova-ios@3.4.1have
> > >> > been published here:
> > >> > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> > >> > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
> > >> >
> > >> >
> > >> > The packages were published from their corresponding git tags:
> > >> > cordova-cli: 3.4.1-0.1.0 (b769a304be)
> > >> > cordova-plugman: 0.21.0 (b2f3a130d3)
> > >> > cordova-ios: 3.4.1 (a96d2360fa)
> > >> >
> > >> > Upon a successful vote I will upload the cli & plugman archives to
> > dist/
> > >> > and publish them to npm. Cordova-ios will be uploaded to
> > >> dist/platforms. I
> > >> > will then post the corresponding blog post.
> > >> >
> > >> > Voting will go on for a minimum of 24 hours.
> > >> >
> > >> > I vote +1.
> > >> >
> > >> > If people want individual vote threads for each item, let me know
> and
> > I
> > >> > will create them instead of this thread.
> > >> >
> > >>
> > >
> > >
> >
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Marc Weiner <mh...@gmail.com>.
I was able to get npm install to work by changing the version of plugman
from 0.21.0 to 0.21.2.
Marc
On Fri, Apr 4, 2014 at 11:19 AM, Ian Clelland <ic...@chromium.org>wrote:
> After some heated discussion here, we're pretty sure that that's the
> problem with the CI, and that it's not going to work if we release it
> as-is. :(
>
> The really awful thing is that it doesn't look like it's possible to use
> package.json and npm-shrinkwrap.json properly, and end up with a release
> candidate that works *now*, and also works when the packages are actually
> released to npm.
>
> (If npm-shrinkwrap.json properly points to v0.21.0, then it won't install
> until that gets released. If we release v0.21.0-rc1, and point shrinkwrap
> to that, then it won't download 0.21.0 when we release it. And if we
> release 0.21.0 on npm before the vote, and it gets voted down, then we
> start burning through version numbers until the vote passes)
>
> However, we do need to produce *something* that we can vote on, and I think
> it needs to be the version that works after the packages are released, even
> if it requires some hackery to test it before then.
>
> I think the best thing that we can do in the situation is this:
> * Make CLI's npm-shrinkwrap.json point to the version that doesn't exist
> yet on npm -- {"version": "0.21.0", "from": "cordova-plugman@0.21.0"}
> * Make CLI's package.json depend on any version of plugman ">=0.21.0-rc"
> * Sign and release that for a vote.
> * Everyone can download it, and just remove npm-shrinkwrap.json before
> running npm-install. That should install correctly, and we can test the
> tools.
> * Once it passes, we publish cli and plugman to npm with the correct
> version numbers, and it will install correctly for end users.
>
>
>
>
> On Fri, Apr 4, 2014 at 10:47 AM, Ian Clelland <iclelland@chromium.org
> >wrote:
>
> > There may be a packaging error with cli -- the npm-shrinkwrap.json file
> > specifies a relative file path, that I think will stop "npm install" from
> > working on cli:
> >
> > ...
> > "plugman": {
> > "version": "0.21.0",
> > "from": "../cordova-plugman",
> > ...
> >
> > (It doesn't stop it from working completely; it actually did work for me
> > the first time, but that's just because I actually *had* a
> cordova-plugman
> > directory right beside my cordova-cli directory, and I had specifically
> > checked out the 0.21.0 tag. It has been failing the CI tests, though, and
> > we haven't been able to get it to install correctly when checked out
> into a
> > new directory)
> >
> > I'm -1 until we can fix that, sorry. :(
> >
> > (Or until we determine that it's not actually the problem)
> >
> >
> >
> > On Fri, Apr 4, 2014 at 4:05 AM, Sebastien Blanc <scm.blanc@gmail.com
> >wrote:
> >
> >> +1
> >>
> >>
> >> On Fri, Apr 4, 2014 at 10:00 AM, Steven Gill <st...@gmail.com>
> >> wrote:
> >>
> >> > Please review and vote on the release of this cordova-cli,
> >> cordova-plugman
> >> > and cordova-ios release.
> >> >
> >> > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
> cordova-ios@3.4.1have
> >> > been published here:
> >> > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> >> > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
> >> >
> >> >
> >> > The packages were published from their corresponding git tags:
> >> > cordova-cli: 3.4.1-0.1.0 (b769a304be)
> >> > cordova-plugman: 0.21.0 (b2f3a130d3)
> >> > cordova-ios: 3.4.1 (a96d2360fa)
> >> >
> >> > Upon a successful vote I will upload the cli & plugman archives to
> dist/
> >> > and publish them to npm. Cordova-ios will be uploaded to
> >> dist/platforms. I
> >> > will then post the corresponding blog post.
> >> >
> >> > Voting will go on for a minimum of 24 hours.
> >> >
> >> > I vote +1.
> >> >
> >> > If people want individual vote threads for each item, let me know and
> I
> >> > will create them instead of this thread.
> >> >
> >>
> >
> >
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Ian Clelland <ic...@chromium.org>.
After some heated discussion here, we're pretty sure that that's the
problem with the CI, and that it's not going to work if we release it
as-is. :(
The really awful thing is that it doesn't look like it's possible to use
package.json and npm-shrinkwrap.json properly, and end up with a release
candidate that works *now*, and also works when the packages are actually
released to npm.
(If npm-shrinkwrap.json properly points to v0.21.0, then it won't install
until that gets released. If we release v0.21.0-rc1, and point shrinkwrap
to that, then it won't download 0.21.0 when we release it. And if we
release 0.21.0 on npm before the vote, and it gets voted down, then we
start burning through version numbers until the vote passes)
However, we do need to produce *something* that we can vote on, and I think
it needs to be the version that works after the packages are released, even
if it requires some hackery to test it before then.
I think the best thing that we can do in the situation is this:
* Make CLI's npm-shrinkwrap.json point to the version that doesn't exist
yet on npm -- {"version": "0.21.0", "from": "cordova-plugman@0.21.0"}
* Make CLI's package.json depend on any version of plugman ">=0.21.0-rc"
* Sign and release that for a vote.
* Everyone can download it, and just remove npm-shrinkwrap.json before
running npm-install. That should install correctly, and we can test the
tools.
* Once it passes, we publish cli and plugman to npm with the correct
version numbers, and it will install correctly for end users.
On Fri, Apr 4, 2014 at 10:47 AM, Ian Clelland <ic...@chromium.org>wrote:
> There may be a packaging error with cli -- the npm-shrinkwrap.json file
> specifies a relative file path, that I think will stop "npm install" from
> working on cli:
>
> ...
> "plugman": {
> "version": "0.21.0",
> "from": "../cordova-plugman",
> ...
>
> (It doesn't stop it from working completely; it actually did work for me
> the first time, but that's just because I actually *had* a cordova-plugman
> directory right beside my cordova-cli directory, and I had specifically
> checked out the 0.21.0 tag. It has been failing the CI tests, though, and
> we haven't been able to get it to install correctly when checked out into a
> new directory)
>
> I'm -1 until we can fix that, sorry. :(
>
> (Or until we determine that it's not actually the problem)
>
>
>
> On Fri, Apr 4, 2014 at 4:05 AM, Sebastien Blanc <sc...@gmail.com>wrote:
>
>> +1
>>
>>
>> On Fri, Apr 4, 2014 at 10:00 AM, Steven Gill <st...@gmail.com>
>> wrote:
>>
>> > Please review and vote on the release of this cordova-cli,
>> cordova-plugman
>> > and cordova-ios release.
>> >
>> > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1have
>> > been published here:
>> > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
>> > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
>> >
>> >
>> > The packages were published from their corresponding git tags:
>> > cordova-cli: 3.4.1-0.1.0 (b769a304be)
>> > cordova-plugman: 0.21.0 (b2f3a130d3)
>> > cordova-ios: 3.4.1 (a96d2360fa)
>> >
>> > Upon a successful vote I will upload the cli & plugman archives to dist/
>> > and publish them to npm. Cordova-ios will be uploaded to
>> dist/platforms. I
>> > will then post the corresponding blog post.
>> >
>> > Voting will go on for a minimum of 24 hours.
>> >
>> > I vote +1.
>> >
>> > If people want individual vote threads for each item, let me know and I
>> > will create them instead of this thread.
>> >
>>
>
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Ian Clelland <ic...@chromium.org>.
There may be a packaging error with cli -- the npm-shrinkwrap.json file
specifies a relative file path, that I think will stop "npm install" from
working on cli:
...
"plugman": {
"version": "0.21.0",
"from": "../cordova-plugman",
...
(It doesn't stop it from working completely; it actually did work for me
the first time, but that's just because I actually *had* a cordova-plugman
directory right beside my cordova-cli directory, and I had specifically
checked out the 0.21.0 tag. It has been failing the CI tests, though, and
we haven't been able to get it to install correctly when checked out into a
new directory)
I'm -1 until we can fix that, sorry. :(
(Or until we determine that it's not actually the problem)
On Fri, Apr 4, 2014 at 4:05 AM, Sebastien Blanc <sc...@gmail.com> wrote:
> +1
>
>
> On Fri, Apr 4, 2014 at 10:00 AM, Steven Gill <st...@gmail.com>
> wrote:
>
> > Please review and vote on the release of this cordova-cli,
> cordova-plugman
> > and cordova-ios release.
> >
> > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1have
> > been published here:
> > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
> >
> >
> > The packages were published from their corresponding git tags:
> > cordova-cli: 3.4.1-0.1.0 (b769a304be)
> > cordova-plugman: 0.21.0 (b2f3a130d3)
> > cordova-ios: 3.4.1 (a96d2360fa)
> >
> > Upon a successful vote I will upload the cli & plugman archives to dist/
> > and publish them to npm. Cordova-ios will be uploaded to dist/platforms.
> I
> > will then post the corresponding blog post.
> >
> > Voting will go on for a minimum of 24 hours.
> >
> > I vote +1.
> >
> > If people want individual vote threads for each item, let me know and I
> > will create them instead of this thread.
> >
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Steven Gill <st...@gmail.com>.
Good points everyone.
So what should my next steps be?
Do I do the plugman release first and then the CLI release?
Or do we add instructions here on how to test these and continue the vote?
Axel & Parashuram, I think we should wait to add those pull requests until
this release gets out. I would have to redo the testing if I include any
new code in. I won't have anytime to do this until after apachecon (delay
the release by 1 week). It would be better to get this out and do another
release in a week with those included.
On Fri, Apr 4, 2014 at 10:07 AM, Naik, Archana <na...@lab126.com> wrote:
> +1
>
> On 4/4/14 1:05 AM, "Sebastien Blanc" <sc...@gmail.com> wrote:
>
> >+1
> >
> >
> >On Fri, Apr 4, 2014 at 10:00 AM, Steven Gill <st...@gmail.com>
> >wrote:
> >
> >> Please review and vote on the release of this cordova-cli,
> >>cordova-plugman
> >> and cordova-ios release.
> >>
> >> cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
> >>have
> >> been published here:
> >> *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> >> <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
> >>
> >>
> >> The packages were published from their corresponding git tags:
> >> cordova-cli: 3.4.1-0.1.0 (b769a304be)
> >> cordova-plugman: 0.21.0 (b2f3a130d3)
> >> cordova-ios: 3.4.1 (a96d2360fa)
> >>
> >> Upon a successful vote I will upload the cli & plugman archives to dist/
> >> and publish them to npm. Cordova-ios will be uploaded to
> >>dist/platforms. I
> >> will then post the corresponding blog post.
> >>
> >> Voting will go on for a minimum of 24 hours.
> >>
> >> I vote +1.
> >>
> >> If people want individual vote threads for each item, let me know and I
> >> will create them instead of this thread.
> >>
>
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
cordova-ios@3.4.1
Posted by "Naik, Archana" <na...@lab126.com>.
+1
On 4/4/14 1:05 AM, "Sebastien Blanc" <sc...@gmail.com> wrote:
>+1
>
>
>On Fri, Apr 4, 2014 at 10:00 AM, Steven Gill <st...@gmail.com>
>wrote:
>
>> Please review and vote on the release of this cordova-cli,
>>cordova-plugman
>> and cordova-ios release.
>>
>> cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
>>have
>> been published here:
>> *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
>> <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
>>
>>
>> The packages were published from their corresponding git tags:
>> cordova-cli: 3.4.1-0.1.0 (b769a304be)
>> cordova-plugman: 0.21.0 (b2f3a130d3)
>> cordova-ios: 3.4.1 (a96d2360fa)
>>
>> Upon a successful vote I will upload the cli & plugman archives to dist/
>> and publish them to npm. Cordova-ios will be uploaded to
>>dist/platforms. I
>> will then post the corresponding blog post.
>>
>> Voting will go on for a minimum of 24 hours.
>>
>> I vote +1.
>>
>> If people want individual vote threads for each item, let me know and I
>> will create them instead of this thread.
>>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Sebastien Blanc <sc...@gmail.com>.
+1
On Fri, Apr 4, 2014 at 10:00 AM, Steven Gill <st...@gmail.com> wrote:
> Please review and vote on the release of this cordova-cli, cordova-plugman
> and cordova-ios release.
>
> cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1 have
> been published here:
> *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
>
>
> The packages were published from their corresponding git tags:
> cordova-cli: 3.4.1-0.1.0 (b769a304be)
> cordova-plugman: 0.21.0 (b2f3a130d3)
> cordova-ios: 3.4.1 (a96d2360fa)
>
> Upon a successful vote I will upload the cli & plugman archives to dist/
> and publish them to npm. Cordova-ios will be uploaded to dist/platforms. I
> will then post the corresponding blog post.
>
> Voting will go on for a minimum of 24 hours.
>
> I vote +1.
>
> If people want individual vote threads for each item, let me know and I
> will create them instead of this thread.
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Carlos Santana <cs...@gmail.com>.
Deleting shrinkwrap.json to do testing is a bad practice.
One of the main reasons for testing with shrinkwrap.json is to make sure
everyone test the same dependencies version for the whole dependency graph.
and users get what we tested.
I think it's OK to manually edit the package.json and shrinkwrap.json to
update only the plugman version to a different one or local one, but do not
delete the shrinkwrap.json so the other dependencies get tested as intended
to be release.
This was the agreement from the discussion here:
http://markmail.org/thread/j6bv5bk5ndlokobj
--Carlos
On Tue, Apr 8, 2014 at 3:51 PM, Steven Gill <st...@gmail.com> wrote:
> This vote has failed and has been broken into separate vote threads.
>
>
> On Sun, Apr 6, 2014 at 10:44 PM, Steven Gill <st...@gmail.com>
> wrote:
>
> > Just chatted with Ian at the bar about this.
> >
> > I think the best way to move forward is to vote on plugman first, release
> > it and then make sure cli has proper references and vote on that.
> >
> > I'll send out a thread now
> >
> >
> > On Sun, Apr 6, 2014 at 9:39 PM, Shazron <sh...@gmail.com> wrote:
> >
> >> Hi Steve,
> >> Not sure what the next steps are -- are the -1s being resolved so we can
> >> get this out? Let me know how I can help.
> >>
> >>
> >> On Fri, Apr 4, 2014 at 10:45 AM, Steven Gill <st...@gmail.com>
> >> wrote:
> >>
> >> > Sorry, didn't mean to hit send on that last message quite so quickly.
> >> >
> >> > We could add release branches but it would require us to change our
> >> release
> >> > process for them.
> >> >
> >> > Isn't master only broken until we release. If the process is completed
> >> > within 24hours, is having master broken a huge deal? Most people will
> >> use
> >> > npm to install cordova anyways.
> >> >
> >> >
> >> >
> >> > On Fri, Apr 4, 2014 at 10:43 AM, Steven Gill <st...@gmail.com>
> >> > wrote:
> >> >
> >> > > We don't have release branches for CLI + Plugman.
> >> > >
> >> > >
> >> > > On Fri, Apr 4, 2014 at 10:40 AM, Bryan Higgins <
> >> bryan@bryanhiggins.net
> >> > >wrote:
> >> > >
> >> > >> SGTM
> >> > >>
> >> > >>
> >> > >> On Fri, Apr 4, 2014 at 1:38 PM, Ian Clelland <
> iclelland@chromium.org
> >> >
> >> > >> wrote:
> >> > >>
> >> > >> > What about only adding the shrinkwrap file to git just before
> >> release,
> >> > >> on
> >> > >> > the release branch? Then only published releases on npm (and on
> >> > >> > dist.apache.org) will include that file, and the only people who
> >> have
> >> > >> to
> >> > >> > delete it manually are those people testing the release
> candidate.
> >> > >> Anyone
> >> > >> > getting master from git will not have that file.
> >> > >> >
> >> > >> >
> >> > >> > On Fri, Apr 4, 2014 at 1:25 PM, Bryan Higgins <
> >> bryan@bryanhiggins.net
> >> > >> > >wrote:
> >> > >> >
> >> > >> > > Right, but someone outside of this group stumbling upon the
> repo
> >> on
> >> > >> > GitHub
> >> > >> > > won't be able to use it unless they know to delete the
> shrinkwrap
> >> > >> file.
> >> > >> > I'd
> >> > >> > > rather the process be a bit more cumbersome for us and preserve
> >> the
> >> > >> > > integrity of repo.
> >> > >> > >
> >> > >> > >
> >> > >> > > On Fri, Apr 4, 2014 at 1:11 PM, David Kemp <
> drkemp@chromium.org>
> >> > >> wrote:
> >> > >> > >
> >> > >> > > > If we make the proposed change to the CLI package.json
> (change
> >> the
> >> > >> > > plugman
> >> > >> > > > dependency to ">=0.21.0-rc"),
> >> > >> > > > then all that is required for testing is to delete the
> >> shrinkwrap
> >> > >> file.
> >> > >> > > >
> >> > >> > > > That means a little less hackery to test the package that is
> >> being
> >> > >> > voted
> >> > >> > > > on.
> >> > >> > > >
> >> > >> > > > We have currently made those changes on the fly in the CI to
> >> get
> >> > it
> >> > >> > > working
> >> > >> > > > again.
> >> > >> > > >
> >> > >> > > >
> >> > >> > > >
> >> > >> > > > On Fri, Apr 4, 2014 at 12:57 PM, Bryan Higgins <
> >> > >> bryan@bryanhiggins.net
> >> > >> > > > >wrote:
> >> > >> > > >
> >> > >> > > > > The other problem we face is the actual repo being unusable
> >> for
> >> > a
> >> > >> > > period
> >> > >> > > > of
> >> > >> > > > > time unless you know how to fiddle with package.json /
> >> > >> > > > npm-shrinkwrap.json.
> >> > >> > > > >
> >> > >> > > > > At the very least this should be pointed out on the README,
> >> but
> >> > >> even
> >> > >> > > that
> >> > >> > > > > doesn't seem friendly to potential contributors.
> >> > >> > > > >
> >> > >> > > > > I'm in favour of bumping the version number in CLI after
> the
> >> > vote
> >> > >> for
> >> > >> > > > cases
> >> > >> > > > > like this where we're releasing tools together. Those
> testing
> >> > the
> >> > >> CLI
> >> > >> > > for
> >> > >> > > > > release can bump up the plugman version locally.
> >> > >> > > > >
> >> > >> > > > > Otherwise we should vote on plugman first, then update CLI
> >> and
> >> > >> vote
> >> > >> > on
> >> > >> > > > > that...
> >> > >> > > > >
> >> > >> > > > >
> >> > >> > > > > On Fri, Apr 4, 2014 at 12:33 PM, Parashuram Narasimhan (MS
> >> OPEN
> >> > >> > TECH) <
> >> > >> > > > > panarasi@microsoft.com> wrote:
> >> > >> > > > >
> >> > >> > > > > > Can we also include the Windows Phone and Windows
> Platform,
> >> > >> > > > specifically
> >> > >> > > > > > for the following bugs/pull requests
> >> > >> > > > > >
> >> > >> > > > > > 1. Windows 8 -
> >> > >> > > https://github.com/apache/cordova-windows/pull/20-
> >> > >> > > > > > This is more of a regression in case VS2013 is installed.
> >> With
> >> > >> the
> >> > >> > > > build
> >> > >> > > > > > announcement yesterday, this could be higher priority.
> Note
> >> > that
> >> > >> > this
> >> > >> > > > is
> >> > >> > > > > > not yet merged in.
> >> > >> > > > > > 2. Windows Phone 8 -
> >> > >> > > > https://github.com/apache/cordova-wp8/pull/28-
> >> > >> > > > > > This could affect the users using the emulator.
> >> > >> > > > > >
> >> > >> > > > > > -----Original Message-----
> >> > >> > > > > > From: Axel Nennker [mailto:ignisvulpis@gmail.com]
> >> > >> > > > > > Sent: Friday, April 4, 2014 9:21 AM
> >> > >> > > > > > To: dev
> >> > >> > > > > > Subject: Re: [VOTE] cordoav-cli@3.4.1-0.1.0,
> >> > >> > > cordova-plugman@0.21.0and
> >> > >> > > > > > cordova-ios@3.4.1
> >> > >> > > > > >
> >> > >> > > > > > Is there a chance to get the cb-2606 patch for launcer
> icon
> >> > >> support
> >> > >> > > > into
> >> > >> > > > > a
> >> > >> > > > > > release some time no too far?
> >> > >> > > > > >
> >> > >> > > > > > Axel
> >> > >> > > > > > Am 04.04.2014 10:01 schrieb "Steven Gill" <
> >> > >> stevengill97@gmail.com
> >> > >> > >:
> >> > >> > > > > >
> >> > >> > > > > > > Please review and vote on the release of this
> >> cordova-cli,
> >> > >> > > > > > > cordova-plugman and cordova-ios release.
> >> > >> > > > > > >
> >> > >> > > > > > > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
> >> > >> > > > cordova-ios@3.4.1
> >> > >> > > > > > > have been published here:
> >> > >> > > > > > > *
> https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> >> > >> > > > > > > <
> https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> >> >*
> >> > >> > > > > > >
> >> > >> > > > > > >
> >> > >> > > > > > > The packages were published from their corresponding
> git
> >> > tags:
> >> > >> > > > > > > cordova-cli: 3.4.1-0.1.0 (b769a304be)
> >> > >> > > > > > > cordova-plugman: 0.21.0 (b2f3a130d3)
> >> > >> > > > > > > cordova-ios: 3.4.1 (a96d2360fa)
> >> > >> > > > > > >
> >> > >> > > > > > > Upon a successful vote I will upload the cli & plugman
> >> > >> archives
> >> > >> > to
> >> > >> > > > > > > dist/ and publish them to npm. Cordova-ios will be
> >> uploaded
> >> > to
> >> > >> > > > > > > dist/platforms. I will then post the corresponding blog
> >> > post.
> >> > >> > > > > > >
> >> > >> > > > > > > Voting will go on for a minimum of 24 hours.
> >> > >> > > > > > >
> >> > >> > > > > > > I vote +1.
> >> > >> > > > > > >
> >> > >> > > > > > > If people want individual vote threads for each item,
> >> let me
> >> > >> know
> >> > >> > > and
> >> > >> > > > > > > I will create them instead of this thread.
> >> > >> > > > > > >
> >> > >> > > > > >
> >> > >> > > > >
> >> > >> > > >
> >> > >> > >
> >> > >> >
> >> > >>
> >> > >
> >> > >
> >> >
> >>
> >
> >
>
--
Carlos Santana
<cs...@gmail.com>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Steven Gill <st...@gmail.com>.
This vote has failed and has been broken into separate vote threads.
On Sun, Apr 6, 2014 at 10:44 PM, Steven Gill <st...@gmail.com> wrote:
> Just chatted with Ian at the bar about this.
>
> I think the best way to move forward is to vote on plugman first, release
> it and then make sure cli has proper references and vote on that.
>
> I'll send out a thread now
>
>
> On Sun, Apr 6, 2014 at 9:39 PM, Shazron <sh...@gmail.com> wrote:
>
>> Hi Steve,
>> Not sure what the next steps are -- are the -1s being resolved so we can
>> get this out? Let me know how I can help.
>>
>>
>> On Fri, Apr 4, 2014 at 10:45 AM, Steven Gill <st...@gmail.com>
>> wrote:
>>
>> > Sorry, didn't mean to hit send on that last message quite so quickly.
>> >
>> > We could add release branches but it would require us to change our
>> release
>> > process for them.
>> >
>> > Isn't master only broken until we release. If the process is completed
>> > within 24hours, is having master broken a huge deal? Most people will
>> use
>> > npm to install cordova anyways.
>> >
>> >
>> >
>> > On Fri, Apr 4, 2014 at 10:43 AM, Steven Gill <st...@gmail.com>
>> > wrote:
>> >
>> > > We don't have release branches for CLI + Plugman.
>> > >
>> > >
>> > > On Fri, Apr 4, 2014 at 10:40 AM, Bryan Higgins <
>> bryan@bryanhiggins.net
>> > >wrote:
>> > >
>> > >> SGTM
>> > >>
>> > >>
>> > >> On Fri, Apr 4, 2014 at 1:38 PM, Ian Clelland <iclelland@chromium.org
>> >
>> > >> wrote:
>> > >>
>> > >> > What about only adding the shrinkwrap file to git just before
>> release,
>> > >> on
>> > >> > the release branch? Then only published releases on npm (and on
>> > >> > dist.apache.org) will include that file, and the only people who
>> have
>> > >> to
>> > >> > delete it manually are those people testing the release candidate.
>> > >> Anyone
>> > >> > getting master from git will not have that file.
>> > >> >
>> > >> >
>> > >> > On Fri, Apr 4, 2014 at 1:25 PM, Bryan Higgins <
>> bryan@bryanhiggins.net
>> > >> > >wrote:
>> > >> >
>> > >> > > Right, but someone outside of this group stumbling upon the repo
>> on
>> > >> > GitHub
>> > >> > > won't be able to use it unless they know to delete the shrinkwrap
>> > >> file.
>> > >> > I'd
>> > >> > > rather the process be a bit more cumbersome for us and preserve
>> the
>> > >> > > integrity of repo.
>> > >> > >
>> > >> > >
>> > >> > > On Fri, Apr 4, 2014 at 1:11 PM, David Kemp <dr...@chromium.org>
>> > >> wrote:
>> > >> > >
>> > >> > > > If we make the proposed change to the CLI package.json (change
>> the
>> > >> > > plugman
>> > >> > > > dependency to ">=0.21.0-rc"),
>> > >> > > > then all that is required for testing is to delete the
>> shrinkwrap
>> > >> file.
>> > >> > > >
>> > >> > > > That means a little less hackery to test the package that is
>> being
>> > >> > voted
>> > >> > > > on.
>> > >> > > >
>> > >> > > > We have currently made those changes on the fly in the CI to
>> get
>> > it
>> > >> > > working
>> > >> > > > again.
>> > >> > > >
>> > >> > > >
>> > >> > > >
>> > >> > > > On Fri, Apr 4, 2014 at 12:57 PM, Bryan Higgins <
>> > >> bryan@bryanhiggins.net
>> > >> > > > >wrote:
>> > >> > > >
>> > >> > > > > The other problem we face is the actual repo being unusable
>> for
>> > a
>> > >> > > period
>> > >> > > > of
>> > >> > > > > time unless you know how to fiddle with package.json /
>> > >> > > > npm-shrinkwrap.json.
>> > >> > > > >
>> > >> > > > > At the very least this should be pointed out on the README,
>> but
>> > >> even
>> > >> > > that
>> > >> > > > > doesn't seem friendly to potential contributors.
>> > >> > > > >
>> > >> > > > > I'm in favour of bumping the version number in CLI after the
>> > vote
>> > >> for
>> > >> > > > cases
>> > >> > > > > like this where we're releasing tools together. Those testing
>> > the
>> > >> CLI
>> > >> > > for
>> > >> > > > > release can bump up the plugman version locally.
>> > >> > > > >
>> > >> > > > > Otherwise we should vote on plugman first, then update CLI
>> and
>> > >> vote
>> > >> > on
>> > >> > > > > that...
>> > >> > > > >
>> > >> > > > >
>> > >> > > > > On Fri, Apr 4, 2014 at 12:33 PM, Parashuram Narasimhan (MS
>> OPEN
>> > >> > TECH) <
>> > >> > > > > panarasi@microsoft.com> wrote:
>> > >> > > > >
>> > >> > > > > > Can we also include the Windows Phone and Windows Platform,
>> > >> > > > specifically
>> > >> > > > > > for the following bugs/pull requests
>> > >> > > > > >
>> > >> > > > > > 1. Windows 8 -
>> > >> > > https://github.com/apache/cordova-windows/pull/20-
>> > >> > > > > > This is more of a regression in case VS2013 is installed.
>> With
>> > >> the
>> > >> > > > build
>> > >> > > > > > announcement yesterday, this could be higher priority. Note
>> > that
>> > >> > this
>> > >> > > > is
>> > >> > > > > > not yet merged in.
>> > >> > > > > > 2. Windows Phone 8 -
>> > >> > > > https://github.com/apache/cordova-wp8/pull/28-
>> > >> > > > > > This could affect the users using the emulator.
>> > >> > > > > >
>> > >> > > > > > -----Original Message-----
>> > >> > > > > > From: Axel Nennker [mailto:ignisvulpis@gmail.com]
>> > >> > > > > > Sent: Friday, April 4, 2014 9:21 AM
>> > >> > > > > > To: dev
>> > >> > > > > > Subject: Re: [VOTE] cordoav-cli@3.4.1-0.1.0,
>> > >> > > cordova-plugman@0.21.0and
>> > >> > > > > > cordova-ios@3.4.1
>> > >> > > > > >
>> > >> > > > > > Is there a chance to get the cb-2606 patch for launcer icon
>> > >> support
>> > >> > > > into
>> > >> > > > > a
>> > >> > > > > > release some time no too far?
>> > >> > > > > >
>> > >> > > > > > Axel
>> > >> > > > > > Am 04.04.2014 10:01 schrieb "Steven Gill" <
>> > >> stevengill97@gmail.com
>> > >> > >:
>> > >> > > > > >
>> > >> > > > > > > Please review and vote on the release of this
>> cordova-cli,
>> > >> > > > > > > cordova-plugman and cordova-ios release.
>> > >> > > > > > >
>> > >> > > > > > > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
>> > >> > > > cordova-ios@3.4.1
>> > >> > > > > > > have been published here:
>> > >> > > > > > > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
>> > >> > > > > > > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
>> >*
>> > >> > > > > > >
>> > >> > > > > > >
>> > >> > > > > > > The packages were published from their corresponding git
>> > tags:
>> > >> > > > > > > cordova-cli: 3.4.1-0.1.0 (b769a304be)
>> > >> > > > > > > cordova-plugman: 0.21.0 (b2f3a130d3)
>> > >> > > > > > > cordova-ios: 3.4.1 (a96d2360fa)
>> > >> > > > > > >
>> > >> > > > > > > Upon a successful vote I will upload the cli & plugman
>> > >> archives
>> > >> > to
>> > >> > > > > > > dist/ and publish them to npm. Cordova-ios will be
>> uploaded
>> > to
>> > >> > > > > > > dist/platforms. I will then post the corresponding blog
>> > post.
>> > >> > > > > > >
>> > >> > > > > > > Voting will go on for a minimum of 24 hours.
>> > >> > > > > > >
>> > >> > > > > > > I vote +1.
>> > >> > > > > > >
>> > >> > > > > > > If people want individual vote threads for each item,
>> let me
>> > >> know
>> > >> > > and
>> > >> > > > > > > I will create them instead of this thread.
>> > >> > > > > > >
>> > >> > > > > >
>> > >> > > > >
>> > >> > > >
>> > >> > >
>> > >> >
>> > >>
>> > >
>> > >
>> >
>>
>
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Steven Gill <st...@gmail.com>.
Just chatted with Ian at the bar about this.
I think the best way to move forward is to vote on plugman first, release
it and then make sure cli has proper references and vote on that.
I'll send out a thread now
On Sun, Apr 6, 2014 at 9:39 PM, Shazron <sh...@gmail.com> wrote:
> Hi Steve,
> Not sure what the next steps are -- are the -1s being resolved so we can
> get this out? Let me know how I can help.
>
>
> On Fri, Apr 4, 2014 at 10:45 AM, Steven Gill <st...@gmail.com>
> wrote:
>
> > Sorry, didn't mean to hit send on that last message quite so quickly.
> >
> > We could add release branches but it would require us to change our
> release
> > process for them.
> >
> > Isn't master only broken until we release. If the process is completed
> > within 24hours, is having master broken a huge deal? Most people will use
> > npm to install cordova anyways.
> >
> >
> >
> > On Fri, Apr 4, 2014 at 10:43 AM, Steven Gill <st...@gmail.com>
> > wrote:
> >
> > > We don't have release branches for CLI + Plugman.
> > >
> > >
> > > On Fri, Apr 4, 2014 at 10:40 AM, Bryan Higgins <bryan@bryanhiggins.net
> > >wrote:
> > >
> > >> SGTM
> > >>
> > >>
> > >> On Fri, Apr 4, 2014 at 1:38 PM, Ian Clelland <ic...@chromium.org>
> > >> wrote:
> > >>
> > >> > What about only adding the shrinkwrap file to git just before
> release,
> > >> on
> > >> > the release branch? Then only published releases on npm (and on
> > >> > dist.apache.org) will include that file, and the only people who
> have
> > >> to
> > >> > delete it manually are those people testing the release candidate.
> > >> Anyone
> > >> > getting master from git will not have that file.
> > >> >
> > >> >
> > >> > On Fri, Apr 4, 2014 at 1:25 PM, Bryan Higgins <
> bryan@bryanhiggins.net
> > >> > >wrote:
> > >> >
> > >> > > Right, but someone outside of this group stumbling upon the repo
> on
> > >> > GitHub
> > >> > > won't be able to use it unless they know to delete the shrinkwrap
> > >> file.
> > >> > I'd
> > >> > > rather the process be a bit more cumbersome for us and preserve
> the
> > >> > > integrity of repo.
> > >> > >
> > >> > >
> > >> > > On Fri, Apr 4, 2014 at 1:11 PM, David Kemp <dr...@chromium.org>
> > >> wrote:
> > >> > >
> > >> > > > If we make the proposed change to the CLI package.json (change
> the
> > >> > > plugman
> > >> > > > dependency to ">=0.21.0-rc"),
> > >> > > > then all that is required for testing is to delete the
> shrinkwrap
> > >> file.
> > >> > > >
> > >> > > > That means a little less hackery to test the package that is
> being
> > >> > voted
> > >> > > > on.
> > >> > > >
> > >> > > > We have currently made those changes on the fly in the CI to get
> > it
> > >> > > working
> > >> > > > again.
> > >> > > >
> > >> > > >
> > >> > > >
> > >> > > > On Fri, Apr 4, 2014 at 12:57 PM, Bryan Higgins <
> > >> bryan@bryanhiggins.net
> > >> > > > >wrote:
> > >> > > >
> > >> > > > > The other problem we face is the actual repo being unusable
> for
> > a
> > >> > > period
> > >> > > > of
> > >> > > > > time unless you know how to fiddle with package.json /
> > >> > > > npm-shrinkwrap.json.
> > >> > > > >
> > >> > > > > At the very least this should be pointed out on the README,
> but
> > >> even
> > >> > > that
> > >> > > > > doesn't seem friendly to potential contributors.
> > >> > > > >
> > >> > > > > I'm in favour of bumping the version number in CLI after the
> > vote
> > >> for
> > >> > > > cases
> > >> > > > > like this where we're releasing tools together. Those testing
> > the
> > >> CLI
> > >> > > for
> > >> > > > > release can bump up the plugman version locally.
> > >> > > > >
> > >> > > > > Otherwise we should vote on plugman first, then update CLI and
> > >> vote
> > >> > on
> > >> > > > > that...
> > >> > > > >
> > >> > > > >
> > >> > > > > On Fri, Apr 4, 2014 at 12:33 PM, Parashuram Narasimhan (MS
> OPEN
> > >> > TECH) <
> > >> > > > > panarasi@microsoft.com> wrote:
> > >> > > > >
> > >> > > > > > Can we also include the Windows Phone and Windows Platform,
> > >> > > > specifically
> > >> > > > > > for the following bugs/pull requests
> > >> > > > > >
> > >> > > > > > 1. Windows 8 -
> > >> > > https://github.com/apache/cordova-windows/pull/20-
> > >> > > > > > This is more of a regression in case VS2013 is installed.
> With
> > >> the
> > >> > > > build
> > >> > > > > > announcement yesterday, this could be higher priority. Note
> > that
> > >> > this
> > >> > > > is
> > >> > > > > > not yet merged in.
> > >> > > > > > 2. Windows Phone 8 -
> > >> > > > https://github.com/apache/cordova-wp8/pull/28-
> > >> > > > > > This could affect the users using the emulator.
> > >> > > > > >
> > >> > > > > > -----Original Message-----
> > >> > > > > > From: Axel Nennker [mailto:ignisvulpis@gmail.com]
> > >> > > > > > Sent: Friday, April 4, 2014 9:21 AM
> > >> > > > > > To: dev
> > >> > > > > > Subject: Re: [VOTE] cordoav-cli@3.4.1-0.1.0,
> > >> > > cordova-plugman@0.21.0and
> > >> > > > > > cordova-ios@3.4.1
> > >> > > > > >
> > >> > > > > > Is there a chance to get the cb-2606 patch for launcer icon
> > >> support
> > >> > > > into
> > >> > > > > a
> > >> > > > > > release some time no too far?
> > >> > > > > >
> > >> > > > > > Axel
> > >> > > > > > Am 04.04.2014 10:01 schrieb "Steven Gill" <
> > >> stevengill97@gmail.com
> > >> > >:
> > >> > > > > >
> > >> > > > > > > Please review and vote on the release of this cordova-cli,
> > >> > > > > > > cordova-plugman and cordova-ios release.
> > >> > > > > > >
> > >> > > > > > > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
> > >> > > > cordova-ios@3.4.1
> > >> > > > > > > have been published here:
> > >> > > > > > > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> > >> > > > > > > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> >*
> > >> > > > > > >
> > >> > > > > > >
> > >> > > > > > > The packages were published from their corresponding git
> > tags:
> > >> > > > > > > cordova-cli: 3.4.1-0.1.0 (b769a304be)
> > >> > > > > > > cordova-plugman: 0.21.0 (b2f3a130d3)
> > >> > > > > > > cordova-ios: 3.4.1 (a96d2360fa)
> > >> > > > > > >
> > >> > > > > > > Upon a successful vote I will upload the cli & plugman
> > >> archives
> > >> > to
> > >> > > > > > > dist/ and publish them to npm. Cordova-ios will be
> uploaded
> > to
> > >> > > > > > > dist/platforms. I will then post the corresponding blog
> > post.
> > >> > > > > > >
> > >> > > > > > > Voting will go on for a minimum of 24 hours.
> > >> > > > > > >
> > >> > > > > > > I vote +1.
> > >> > > > > > >
> > >> > > > > > > If people want individual vote threads for each item, let
> me
> > >> know
> > >> > > and
> > >> > > > > > > I will create them instead of this thread.
> > >> > > > > > >
> > >> > > > > >
> > >> > > > >
> > >> > > >
> > >> > >
> > >> >
> > >>
> > >
> > >
> >
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Shazron <sh...@gmail.com>.
Hi Steve,
Not sure what the next steps are -- are the -1s being resolved so we can
get this out? Let me know how I can help.
On Fri, Apr 4, 2014 at 10:45 AM, Steven Gill <st...@gmail.com> wrote:
> Sorry, didn't mean to hit send on that last message quite so quickly.
>
> We could add release branches but it would require us to change our release
> process for them.
>
> Isn't master only broken until we release. If the process is completed
> within 24hours, is having master broken a huge deal? Most people will use
> npm to install cordova anyways.
>
>
>
> On Fri, Apr 4, 2014 at 10:43 AM, Steven Gill <st...@gmail.com>
> wrote:
>
> > We don't have release branches for CLI + Plugman.
> >
> >
> > On Fri, Apr 4, 2014 at 10:40 AM, Bryan Higgins <bryan@bryanhiggins.net
> >wrote:
> >
> >> SGTM
> >>
> >>
> >> On Fri, Apr 4, 2014 at 1:38 PM, Ian Clelland <ic...@chromium.org>
> >> wrote:
> >>
> >> > What about only adding the shrinkwrap file to git just before release,
> >> on
> >> > the release branch? Then only published releases on npm (and on
> >> > dist.apache.org) will include that file, and the only people who have
> >> to
> >> > delete it manually are those people testing the release candidate.
> >> Anyone
> >> > getting master from git will not have that file.
> >> >
> >> >
> >> > On Fri, Apr 4, 2014 at 1:25 PM, Bryan Higgins <bryan@bryanhiggins.net
> >> > >wrote:
> >> >
> >> > > Right, but someone outside of this group stumbling upon the repo on
> >> > GitHub
> >> > > won't be able to use it unless they know to delete the shrinkwrap
> >> file.
> >> > I'd
> >> > > rather the process be a bit more cumbersome for us and preserve the
> >> > > integrity of repo.
> >> > >
> >> > >
> >> > > On Fri, Apr 4, 2014 at 1:11 PM, David Kemp <dr...@chromium.org>
> >> wrote:
> >> > >
> >> > > > If we make the proposed change to the CLI package.json (change the
> >> > > plugman
> >> > > > dependency to ">=0.21.0-rc"),
> >> > > > then all that is required for testing is to delete the shrinkwrap
> >> file.
> >> > > >
> >> > > > That means a little less hackery to test the package that is being
> >> > voted
> >> > > > on.
> >> > > >
> >> > > > We have currently made those changes on the fly in the CI to get
> it
> >> > > working
> >> > > > again.
> >> > > >
> >> > > >
> >> > > >
> >> > > > On Fri, Apr 4, 2014 at 12:57 PM, Bryan Higgins <
> >> bryan@bryanhiggins.net
> >> > > > >wrote:
> >> > > >
> >> > > > > The other problem we face is the actual repo being unusable for
> a
> >> > > period
> >> > > > of
> >> > > > > time unless you know how to fiddle with package.json /
> >> > > > npm-shrinkwrap.json.
> >> > > > >
> >> > > > > At the very least this should be pointed out on the README, but
> >> even
> >> > > that
> >> > > > > doesn't seem friendly to potential contributors.
> >> > > > >
> >> > > > > I'm in favour of bumping the version number in CLI after the
> vote
> >> for
> >> > > > cases
> >> > > > > like this where we're releasing tools together. Those testing
> the
> >> CLI
> >> > > for
> >> > > > > release can bump up the plugman version locally.
> >> > > > >
> >> > > > > Otherwise we should vote on plugman first, then update CLI and
> >> vote
> >> > on
> >> > > > > that...
> >> > > > >
> >> > > > >
> >> > > > > On Fri, Apr 4, 2014 at 12:33 PM, Parashuram Narasimhan (MS OPEN
> >> > TECH) <
> >> > > > > panarasi@microsoft.com> wrote:
> >> > > > >
> >> > > > > > Can we also include the Windows Phone and Windows Platform,
> >> > > > specifically
> >> > > > > > for the following bugs/pull requests
> >> > > > > >
> >> > > > > > 1. Windows 8 -
> >> > > https://github.com/apache/cordova-windows/pull/20-
> >> > > > > > This is more of a regression in case VS2013 is installed. With
> >> the
> >> > > > build
> >> > > > > > announcement yesterday, this could be higher priority. Note
> that
> >> > this
> >> > > > is
> >> > > > > > not yet merged in.
> >> > > > > > 2. Windows Phone 8 -
> >> > > > https://github.com/apache/cordova-wp8/pull/28-
> >> > > > > > This could affect the users using the emulator.
> >> > > > > >
> >> > > > > > -----Original Message-----
> >> > > > > > From: Axel Nennker [mailto:ignisvulpis@gmail.com]
> >> > > > > > Sent: Friday, April 4, 2014 9:21 AM
> >> > > > > > To: dev
> >> > > > > > Subject: Re: [VOTE] cordoav-cli@3.4.1-0.1.0,
> >> > > cordova-plugman@0.21.0and
> >> > > > > > cordova-ios@3.4.1
> >> > > > > >
> >> > > > > > Is there a chance to get the cb-2606 patch for launcer icon
> >> support
> >> > > > into
> >> > > > > a
> >> > > > > > release some time no too far?
> >> > > > > >
> >> > > > > > Axel
> >> > > > > > Am 04.04.2014 10:01 schrieb "Steven Gill" <
> >> stevengill97@gmail.com
> >> > >:
> >> > > > > >
> >> > > > > > > Please review and vote on the release of this cordova-cli,
> >> > > > > > > cordova-plugman and cordova-ios release.
> >> > > > > > >
> >> > > > > > > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
> >> > > > cordova-ios@3.4.1
> >> > > > > > > have been published here:
> >> > > > > > > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> >> > > > > > > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
> >> > > > > > >
> >> > > > > > >
> >> > > > > > > The packages were published from their corresponding git
> tags:
> >> > > > > > > cordova-cli: 3.4.1-0.1.0 (b769a304be)
> >> > > > > > > cordova-plugman: 0.21.0 (b2f3a130d3)
> >> > > > > > > cordova-ios: 3.4.1 (a96d2360fa)
> >> > > > > > >
> >> > > > > > > Upon a successful vote I will upload the cli & plugman
> >> archives
> >> > to
> >> > > > > > > dist/ and publish them to npm. Cordova-ios will be uploaded
> to
> >> > > > > > > dist/platforms. I will then post the corresponding blog
> post.
> >> > > > > > >
> >> > > > > > > Voting will go on for a minimum of 24 hours.
> >> > > > > > >
> >> > > > > > > I vote +1.
> >> > > > > > >
> >> > > > > > > If people want individual vote threads for each item, let me
> >> know
> >> > > and
> >> > > > > > > I will create them instead of this thread.
> >> > > > > > >
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> >
> >
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Bryan Higgins <br...@bryanhiggins.net>.
No, it's not a huge deal. I was only suggesting we avoid it if possible,
otherwise update the README.
Our internal CI starting failing as soon as that commit was made as well.
Anyone using this downstream will need to make changes.
On Fri, Apr 4, 2014 at 1:45 PM, Steven Gill <st...@gmail.com> wrote:
> Sorry, didn't mean to hit send on that last message quite so quickly.
>
> We could add release branches but it would require us to change our release
> process for them.
>
> Isn't master only broken until we release. If the process is completed
> within 24hours, is having master broken a huge deal? Most people will use
> npm to install cordova anyways.
>
>
>
> On Fri, Apr 4, 2014 at 10:43 AM, Steven Gill <st...@gmail.com>
> wrote:
>
> > We don't have release branches for CLI + Plugman.
> >
> >
> > On Fri, Apr 4, 2014 at 10:40 AM, Bryan Higgins <bryan@bryanhiggins.net
> >wrote:
> >
> >> SGTM
> >>
> >>
> >> On Fri, Apr 4, 2014 at 1:38 PM, Ian Clelland <ic...@chromium.org>
> >> wrote:
> >>
> >> > What about only adding the shrinkwrap file to git just before release,
> >> on
> >> > the release branch? Then only published releases on npm (and on
> >> > dist.apache.org) will include that file, and the only people who have
> >> to
> >> > delete it manually are those people testing the release candidate.
> >> Anyone
> >> > getting master from git will not have that file.
> >> >
> >> >
> >> > On Fri, Apr 4, 2014 at 1:25 PM, Bryan Higgins <bryan@bryanhiggins.net
> >> > >wrote:
> >> >
> >> > > Right, but someone outside of this group stumbling upon the repo on
> >> > GitHub
> >> > > won't be able to use it unless they know to delete the shrinkwrap
> >> file.
> >> > I'd
> >> > > rather the process be a bit more cumbersome for us and preserve the
> >> > > integrity of repo.
> >> > >
> >> > >
> >> > > On Fri, Apr 4, 2014 at 1:11 PM, David Kemp <dr...@chromium.org>
> >> wrote:
> >> > >
> >> > > > If we make the proposed change to the CLI package.json (change the
> >> > > plugman
> >> > > > dependency to ">=0.21.0-rc"),
> >> > > > then all that is required for testing is to delete the shrinkwrap
> >> file.
> >> > > >
> >> > > > That means a little less hackery to test the package that is being
> >> > voted
> >> > > > on.
> >> > > >
> >> > > > We have currently made those changes on the fly in the CI to get
> it
> >> > > working
> >> > > > again.
> >> > > >
> >> > > >
> >> > > >
> >> > > > On Fri, Apr 4, 2014 at 12:57 PM, Bryan Higgins <
> >> bryan@bryanhiggins.net
> >> > > > >wrote:
> >> > > >
> >> > > > > The other problem we face is the actual repo being unusable for
> a
> >> > > period
> >> > > > of
> >> > > > > time unless you know how to fiddle with package.json /
> >> > > > npm-shrinkwrap.json.
> >> > > > >
> >> > > > > At the very least this should be pointed out on the README, but
> >> even
> >> > > that
> >> > > > > doesn't seem friendly to potential contributors.
> >> > > > >
> >> > > > > I'm in favour of bumping the version number in CLI after the
> vote
> >> for
> >> > > > cases
> >> > > > > like this where we're releasing tools together. Those testing
> the
> >> CLI
> >> > > for
> >> > > > > release can bump up the plugman version locally.
> >> > > > >
> >> > > > > Otherwise we should vote on plugman first, then update CLI and
> >> vote
> >> > on
> >> > > > > that...
> >> > > > >
> >> > > > >
> >> > > > > On Fri, Apr 4, 2014 at 12:33 PM, Parashuram Narasimhan (MS OPEN
> >> > TECH) <
> >> > > > > panarasi@microsoft.com> wrote:
> >> > > > >
> >> > > > > > Can we also include the Windows Phone and Windows Platform,
> >> > > > specifically
> >> > > > > > for the following bugs/pull requests
> >> > > > > >
> >> > > > > > 1. Windows 8 -
> >> > > https://github.com/apache/cordova-windows/pull/20-
> >> > > > > > This is more of a regression in case VS2013 is installed. With
> >> the
> >> > > > build
> >> > > > > > announcement yesterday, this could be higher priority. Note
> that
> >> > this
> >> > > > is
> >> > > > > > not yet merged in.
> >> > > > > > 2. Windows Phone 8 -
> >> > > > https://github.com/apache/cordova-wp8/pull/28-
> >> > > > > > This could affect the users using the emulator.
> >> > > > > >
> >> > > > > > -----Original Message-----
> >> > > > > > From: Axel Nennker [mailto:ignisvulpis@gmail.com]
> >> > > > > > Sent: Friday, April 4, 2014 9:21 AM
> >> > > > > > To: dev
> >> > > > > > Subject: Re: [VOTE] cordoav-cli@3.4.1-0.1.0,
> >> > > cordova-plugman@0.21.0and
> >> > > > > > cordova-ios@3.4.1
> >> > > > > >
> >> > > > > > Is there a chance to get the cb-2606 patch for launcer icon
> >> support
> >> > > > into
> >> > > > > a
> >> > > > > > release some time no too far?
> >> > > > > >
> >> > > > > > Axel
> >> > > > > > Am 04.04.2014 10:01 schrieb "Steven Gill" <
> >> stevengill97@gmail.com
> >> > >:
> >> > > > > >
> >> > > > > > > Please review and vote on the release of this cordova-cli,
> >> > > > > > > cordova-plugman and cordova-ios release.
> >> > > > > > >
> >> > > > > > > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
> >> > > > cordova-ios@3.4.1
> >> > > > > > > have been published here:
> >> > > > > > > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> >> > > > > > > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
> >> > > > > > >
> >> > > > > > >
> >> > > > > > > The packages were published from their corresponding git
> tags:
> >> > > > > > > cordova-cli: 3.4.1-0.1.0 (b769a304be)
> >> > > > > > > cordova-plugman: 0.21.0 (b2f3a130d3)
> >> > > > > > > cordova-ios: 3.4.1 (a96d2360fa)
> >> > > > > > >
> >> > > > > > > Upon a successful vote I will upload the cli & plugman
> >> archives
> >> > to
> >> > > > > > > dist/ and publish them to npm. Cordova-ios will be uploaded
> to
> >> > > > > > > dist/platforms. I will then post the corresponding blog
> post.
> >> > > > > > >
> >> > > > > > > Voting will go on for a minimum of 24 hours.
> >> > > > > > >
> >> > > > > > > I vote +1.
> >> > > > > > >
> >> > > > > > > If people want individual vote threads for each item, let me
> >> know
> >> > > and
> >> > > > > > > I will create them instead of this thread.
> >> > > > > > >
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> >
> >
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Steven Gill <st...@gmail.com>.
Sorry, didn't mean to hit send on that last message quite so quickly.
We could add release branches but it would require us to change our release
process for them.
Isn't master only broken until we release. If the process is completed
within 24hours, is having master broken a huge deal? Most people will use
npm to install cordova anyways.
On Fri, Apr 4, 2014 at 10:43 AM, Steven Gill <st...@gmail.com> wrote:
> We don't have release branches for CLI + Plugman.
>
>
> On Fri, Apr 4, 2014 at 10:40 AM, Bryan Higgins <br...@bryanhiggins.net>wrote:
>
>> SGTM
>>
>>
>> On Fri, Apr 4, 2014 at 1:38 PM, Ian Clelland <ic...@chromium.org>
>> wrote:
>>
>> > What about only adding the shrinkwrap file to git just before release,
>> on
>> > the release branch? Then only published releases on npm (and on
>> > dist.apache.org) will include that file, and the only people who have
>> to
>> > delete it manually are those people testing the release candidate.
>> Anyone
>> > getting master from git will not have that file.
>> >
>> >
>> > On Fri, Apr 4, 2014 at 1:25 PM, Bryan Higgins <bryan@bryanhiggins.net
>> > >wrote:
>> >
>> > > Right, but someone outside of this group stumbling upon the repo on
>> > GitHub
>> > > won't be able to use it unless they know to delete the shrinkwrap
>> file.
>> > I'd
>> > > rather the process be a bit more cumbersome for us and preserve the
>> > > integrity of repo.
>> > >
>> > >
>> > > On Fri, Apr 4, 2014 at 1:11 PM, David Kemp <dr...@chromium.org>
>> wrote:
>> > >
>> > > > If we make the proposed change to the CLI package.json (change the
>> > > plugman
>> > > > dependency to ">=0.21.0-rc"),
>> > > > then all that is required for testing is to delete the shrinkwrap
>> file.
>> > > >
>> > > > That means a little less hackery to test the package that is being
>> > voted
>> > > > on.
>> > > >
>> > > > We have currently made those changes on the fly in the CI to get it
>> > > working
>> > > > again.
>> > > >
>> > > >
>> > > >
>> > > > On Fri, Apr 4, 2014 at 12:57 PM, Bryan Higgins <
>> bryan@bryanhiggins.net
>> > > > >wrote:
>> > > >
>> > > > > The other problem we face is the actual repo being unusable for a
>> > > period
>> > > > of
>> > > > > time unless you know how to fiddle with package.json /
>> > > > npm-shrinkwrap.json.
>> > > > >
>> > > > > At the very least this should be pointed out on the README, but
>> even
>> > > that
>> > > > > doesn't seem friendly to potential contributors.
>> > > > >
>> > > > > I'm in favour of bumping the version number in CLI after the vote
>> for
>> > > > cases
>> > > > > like this where we're releasing tools together. Those testing the
>> CLI
>> > > for
>> > > > > release can bump up the plugman version locally.
>> > > > >
>> > > > > Otherwise we should vote on plugman first, then update CLI and
>> vote
>> > on
>> > > > > that...
>> > > > >
>> > > > >
>> > > > > On Fri, Apr 4, 2014 at 12:33 PM, Parashuram Narasimhan (MS OPEN
>> > TECH) <
>> > > > > panarasi@microsoft.com> wrote:
>> > > > >
>> > > > > > Can we also include the Windows Phone and Windows Platform,
>> > > > specifically
>> > > > > > for the following bugs/pull requests
>> > > > > >
>> > > > > > 1. Windows 8 -
>> > > https://github.com/apache/cordova-windows/pull/20-
>> > > > > > This is more of a regression in case VS2013 is installed. With
>> the
>> > > > build
>> > > > > > announcement yesterday, this could be higher priority. Note that
>> > this
>> > > > is
>> > > > > > not yet merged in.
>> > > > > > 2. Windows Phone 8 -
>> > > > https://github.com/apache/cordova-wp8/pull/28-
>> > > > > > This could affect the users using the emulator.
>> > > > > >
>> > > > > > -----Original Message-----
>> > > > > > From: Axel Nennker [mailto:ignisvulpis@gmail.com]
>> > > > > > Sent: Friday, April 4, 2014 9:21 AM
>> > > > > > To: dev
>> > > > > > Subject: Re: [VOTE] cordoav-cli@3.4.1-0.1.0,
>> > > cordova-plugman@0.21.0and
>> > > > > > cordova-ios@3.4.1
>> > > > > >
>> > > > > > Is there a chance to get the cb-2606 patch for launcer icon
>> support
>> > > > into
>> > > > > a
>> > > > > > release some time no too far?
>> > > > > >
>> > > > > > Axel
>> > > > > > Am 04.04.2014 10:01 schrieb "Steven Gill" <
>> stevengill97@gmail.com
>> > >:
>> > > > > >
>> > > > > > > Please review and vote on the release of this cordova-cli,
>> > > > > > > cordova-plugman and cordova-ios release.
>> > > > > > >
>> > > > > > > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
>> > > > cordova-ios@3.4.1
>> > > > > > > have been published here:
>> > > > > > > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
>> > > > > > > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
>> > > > > > >
>> > > > > > >
>> > > > > > > The packages were published from their corresponding git tags:
>> > > > > > > cordova-cli: 3.4.1-0.1.0 (b769a304be)
>> > > > > > > cordova-plugman: 0.21.0 (b2f3a130d3)
>> > > > > > > cordova-ios: 3.4.1 (a96d2360fa)
>> > > > > > >
>> > > > > > > Upon a successful vote I will upload the cli & plugman
>> archives
>> > to
>> > > > > > > dist/ and publish them to npm. Cordova-ios will be uploaded to
>> > > > > > > dist/platforms. I will then post the corresponding blog post.
>> > > > > > >
>> > > > > > > Voting will go on for a minimum of 24 hours.
>> > > > > > >
>> > > > > > > I vote +1.
>> > > > > > >
>> > > > > > > If people want individual vote threads for each item, let me
>> know
>> > > and
>> > > > > > > I will create them instead of this thread.
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Steven Gill <st...@gmail.com>.
We don't have release branches for CLI + Plugman.
On Fri, Apr 4, 2014 at 10:40 AM, Bryan Higgins <br...@bryanhiggins.net>wrote:
> SGTM
>
>
> On Fri, Apr 4, 2014 at 1:38 PM, Ian Clelland <ic...@chromium.org>
> wrote:
>
> > What about only adding the shrinkwrap file to git just before release, on
> > the release branch? Then only published releases on npm (and on
> > dist.apache.org) will include that file, and the only people who have to
> > delete it manually are those people testing the release candidate. Anyone
> > getting master from git will not have that file.
> >
> >
> > On Fri, Apr 4, 2014 at 1:25 PM, Bryan Higgins <bryan@bryanhiggins.net
> > >wrote:
> >
> > > Right, but someone outside of this group stumbling upon the repo on
> > GitHub
> > > won't be able to use it unless they know to delete the shrinkwrap file.
> > I'd
> > > rather the process be a bit more cumbersome for us and preserve the
> > > integrity of repo.
> > >
> > >
> > > On Fri, Apr 4, 2014 at 1:11 PM, David Kemp <dr...@chromium.org>
> wrote:
> > >
> > > > If we make the proposed change to the CLI package.json (change the
> > > plugman
> > > > dependency to ">=0.21.0-rc"),
> > > > then all that is required for testing is to delete the shrinkwrap
> file.
> > > >
> > > > That means a little less hackery to test the package that is being
> > voted
> > > > on.
> > > >
> > > > We have currently made those changes on the fly in the CI to get it
> > > working
> > > > again.
> > > >
> > > >
> > > >
> > > > On Fri, Apr 4, 2014 at 12:57 PM, Bryan Higgins <
> bryan@bryanhiggins.net
> > > > >wrote:
> > > >
> > > > > The other problem we face is the actual repo being unusable for a
> > > period
> > > > of
> > > > > time unless you know how to fiddle with package.json /
> > > > npm-shrinkwrap.json.
> > > > >
> > > > > At the very least this should be pointed out on the README, but
> even
> > > that
> > > > > doesn't seem friendly to potential contributors.
> > > > >
> > > > > I'm in favour of bumping the version number in CLI after the vote
> for
> > > > cases
> > > > > like this where we're releasing tools together. Those testing the
> CLI
> > > for
> > > > > release can bump up the plugman version locally.
> > > > >
> > > > > Otherwise we should vote on plugman first, then update CLI and vote
> > on
> > > > > that...
> > > > >
> > > > >
> > > > > On Fri, Apr 4, 2014 at 12:33 PM, Parashuram Narasimhan (MS OPEN
> > TECH) <
> > > > > panarasi@microsoft.com> wrote:
> > > > >
> > > > > > Can we also include the Windows Phone and Windows Platform,
> > > > specifically
> > > > > > for the following bugs/pull requests
> > > > > >
> > > > > > 1. Windows 8 -
> > > https://github.com/apache/cordova-windows/pull/20-
> > > > > > This is more of a regression in case VS2013 is installed. With
> the
> > > > build
> > > > > > announcement yesterday, this could be higher priority. Note that
> > this
> > > > is
> > > > > > not yet merged in.
> > > > > > 2. Windows Phone 8 -
> > > > https://github.com/apache/cordova-wp8/pull/28-
> > > > > > This could affect the users using the emulator.
> > > > > >
> > > > > > -----Original Message-----
> > > > > > From: Axel Nennker [mailto:ignisvulpis@gmail.com]
> > > > > > Sent: Friday, April 4, 2014 9:21 AM
> > > > > > To: dev
> > > > > > Subject: Re: [VOTE] cordoav-cli@3.4.1-0.1.0,
> > > cordova-plugman@0.21.0and
> > > > > > cordova-ios@3.4.1
> > > > > >
> > > > > > Is there a chance to get the cb-2606 patch for launcer icon
> support
> > > > into
> > > > > a
> > > > > > release some time no too far?
> > > > > >
> > > > > > Axel
> > > > > > Am 04.04.2014 10:01 schrieb "Steven Gill" <
> stevengill97@gmail.com
> > >:
> > > > > >
> > > > > > > Please review and vote on the release of this cordova-cli,
> > > > > > > cordova-plugman and cordova-ios release.
> > > > > > >
> > > > > > > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
> > > > cordova-ios@3.4.1
> > > > > > > have been published here:
> > > > > > > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> > > > > > > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
> > > > > > >
> > > > > > >
> > > > > > > The packages were published from their corresponding git tags:
> > > > > > > cordova-cli: 3.4.1-0.1.0 (b769a304be)
> > > > > > > cordova-plugman: 0.21.0 (b2f3a130d3)
> > > > > > > cordova-ios: 3.4.1 (a96d2360fa)
> > > > > > >
> > > > > > > Upon a successful vote I will upload the cli & plugman archives
> > to
> > > > > > > dist/ and publish them to npm. Cordova-ios will be uploaded to
> > > > > > > dist/platforms. I will then post the corresponding blog post.
> > > > > > >
> > > > > > > Voting will go on for a minimum of 24 hours.
> > > > > > >
> > > > > > > I vote +1.
> > > > > > >
> > > > > > > If people want individual vote threads for each item, let me
> know
> > > and
> > > > > > > I will create them instead of this thread.
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Bryan Higgins <br...@bryanhiggins.net>.
SGTM
On Fri, Apr 4, 2014 at 1:38 PM, Ian Clelland <ic...@chromium.org> wrote:
> What about only adding the shrinkwrap file to git just before release, on
> the release branch? Then only published releases on npm (and on
> dist.apache.org) will include that file, and the only people who have to
> delete it manually are those people testing the release candidate. Anyone
> getting master from git will not have that file.
>
>
> On Fri, Apr 4, 2014 at 1:25 PM, Bryan Higgins <bryan@bryanhiggins.net
> >wrote:
>
> > Right, but someone outside of this group stumbling upon the repo on
> GitHub
> > won't be able to use it unless they know to delete the shrinkwrap file.
> I'd
> > rather the process be a bit more cumbersome for us and preserve the
> > integrity of repo.
> >
> >
> > On Fri, Apr 4, 2014 at 1:11 PM, David Kemp <dr...@chromium.org> wrote:
> >
> > > If we make the proposed change to the CLI package.json (change the
> > plugman
> > > dependency to ">=0.21.0-rc"),
> > > then all that is required for testing is to delete the shrinkwrap file.
> > >
> > > That means a little less hackery to test the package that is being
> voted
> > > on.
> > >
> > > We have currently made those changes on the fly in the CI to get it
> > working
> > > again.
> > >
> > >
> > >
> > > On Fri, Apr 4, 2014 at 12:57 PM, Bryan Higgins <bryan@bryanhiggins.net
> > > >wrote:
> > >
> > > > The other problem we face is the actual repo being unusable for a
> > period
> > > of
> > > > time unless you know how to fiddle with package.json /
> > > npm-shrinkwrap.json.
> > > >
> > > > At the very least this should be pointed out on the README, but even
> > that
> > > > doesn't seem friendly to potential contributors.
> > > >
> > > > I'm in favour of bumping the version number in CLI after the vote for
> > > cases
> > > > like this where we're releasing tools together. Those testing the CLI
> > for
> > > > release can bump up the plugman version locally.
> > > >
> > > > Otherwise we should vote on plugman first, then update CLI and vote
> on
> > > > that...
> > > >
> > > >
> > > > On Fri, Apr 4, 2014 at 12:33 PM, Parashuram Narasimhan (MS OPEN
> TECH) <
> > > > panarasi@microsoft.com> wrote:
> > > >
> > > > > Can we also include the Windows Phone and Windows Platform,
> > > specifically
> > > > > for the following bugs/pull requests
> > > > >
> > > > > 1. Windows 8 -
> > https://github.com/apache/cordova-windows/pull/20-
> > > > > This is more of a regression in case VS2013 is installed. With the
> > > build
> > > > > announcement yesterday, this could be higher priority. Note that
> this
> > > is
> > > > > not yet merged in.
> > > > > 2. Windows Phone 8 -
> > > https://github.com/apache/cordova-wp8/pull/28-
> > > > > This could affect the users using the emulator.
> > > > >
> > > > > -----Original Message-----
> > > > > From: Axel Nennker [mailto:ignisvulpis@gmail.com]
> > > > > Sent: Friday, April 4, 2014 9:21 AM
> > > > > To: dev
> > > > > Subject: Re: [VOTE] cordoav-cli@3.4.1-0.1.0,
> > cordova-plugman@0.21.0and
> > > > > cordova-ios@3.4.1
> > > > >
> > > > > Is there a chance to get the cb-2606 patch for launcer icon support
> > > into
> > > > a
> > > > > release some time no too far?
> > > > >
> > > > > Axel
> > > > > Am 04.04.2014 10:01 schrieb "Steven Gill" <stevengill97@gmail.com
> >:
> > > > >
> > > > > > Please review and vote on the release of this cordova-cli,
> > > > > > cordova-plugman and cordova-ios release.
> > > > > >
> > > > > > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
> > > cordova-ios@3.4.1
> > > > > > have been published here:
> > > > > > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> > > > > > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
> > > > > >
> > > > > >
> > > > > > The packages were published from their corresponding git tags:
> > > > > > cordova-cli: 3.4.1-0.1.0 (b769a304be)
> > > > > > cordova-plugman: 0.21.0 (b2f3a130d3)
> > > > > > cordova-ios: 3.4.1 (a96d2360fa)
> > > > > >
> > > > > > Upon a successful vote I will upload the cli & plugman archives
> to
> > > > > > dist/ and publish them to npm. Cordova-ios will be uploaded to
> > > > > > dist/platforms. I will then post the corresponding blog post.
> > > > > >
> > > > > > Voting will go on for a minimum of 24 hours.
> > > > > >
> > > > > > I vote +1.
> > > > > >
> > > > > > If people want individual vote threads for each item, let me know
> > and
> > > > > > I will create them instead of this thread.
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Ian Clelland <ic...@chromium.org>.
What about only adding the shrinkwrap file to git just before release, on
the release branch? Then only published releases on npm (and on
dist.apache.org) will include that file, and the only people who have to
delete it manually are those people testing the release candidate. Anyone
getting master from git will not have that file.
On Fri, Apr 4, 2014 at 1:25 PM, Bryan Higgins <br...@bryanhiggins.net>wrote:
> Right, but someone outside of this group stumbling upon the repo on GitHub
> won't be able to use it unless they know to delete the shrinkwrap file. I'd
> rather the process be a bit more cumbersome for us and preserve the
> integrity of repo.
>
>
> On Fri, Apr 4, 2014 at 1:11 PM, David Kemp <dr...@chromium.org> wrote:
>
> > If we make the proposed change to the CLI package.json (change the
> plugman
> > dependency to ">=0.21.0-rc"),
> > then all that is required for testing is to delete the shrinkwrap file.
> >
> > That means a little less hackery to test the package that is being voted
> > on.
> >
> > We have currently made those changes on the fly in the CI to get it
> working
> > again.
> >
> >
> >
> > On Fri, Apr 4, 2014 at 12:57 PM, Bryan Higgins <bryan@bryanhiggins.net
> > >wrote:
> >
> > > The other problem we face is the actual repo being unusable for a
> period
> > of
> > > time unless you know how to fiddle with package.json /
> > npm-shrinkwrap.json.
> > >
> > > At the very least this should be pointed out on the README, but even
> that
> > > doesn't seem friendly to potential contributors.
> > >
> > > I'm in favour of bumping the version number in CLI after the vote for
> > cases
> > > like this where we're releasing tools together. Those testing the CLI
> for
> > > release can bump up the plugman version locally.
> > >
> > > Otherwise we should vote on plugman first, then update CLI and vote on
> > > that...
> > >
> > >
> > > On Fri, Apr 4, 2014 at 12:33 PM, Parashuram Narasimhan (MS OPEN TECH) <
> > > panarasi@microsoft.com> wrote:
> > >
> > > > Can we also include the Windows Phone and Windows Platform,
> > specifically
> > > > for the following bugs/pull requests
> > > >
> > > > 1. Windows 8 -
> https://github.com/apache/cordova-windows/pull/20-
> > > > This is more of a regression in case VS2013 is installed. With the
> > build
> > > > announcement yesterday, this could be higher priority. Note that this
> > is
> > > > not yet merged in.
> > > > 2. Windows Phone 8 -
> > https://github.com/apache/cordova-wp8/pull/28-
> > > > This could affect the users using the emulator.
> > > >
> > > > -----Original Message-----
> > > > From: Axel Nennker [mailto:ignisvulpis@gmail.com]
> > > > Sent: Friday, April 4, 2014 9:21 AM
> > > > To: dev
> > > > Subject: Re: [VOTE] cordoav-cli@3.4.1-0.1.0,
> cordova-plugman@0.21.0and
> > > > cordova-ios@3.4.1
> > > >
> > > > Is there a chance to get the cb-2606 patch for launcer icon support
> > into
> > > a
> > > > release some time no too far?
> > > >
> > > > Axel
> > > > Am 04.04.2014 10:01 schrieb "Steven Gill" <st...@gmail.com>:
> > > >
> > > > > Please review and vote on the release of this cordova-cli,
> > > > > cordova-plugman and cordova-ios release.
> > > > >
> > > > > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
> > cordova-ios@3.4.1
> > > > > have been published here:
> > > > > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> > > > > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
> > > > >
> > > > >
> > > > > The packages were published from their corresponding git tags:
> > > > > cordova-cli: 3.4.1-0.1.0 (b769a304be)
> > > > > cordova-plugman: 0.21.0 (b2f3a130d3)
> > > > > cordova-ios: 3.4.1 (a96d2360fa)
> > > > >
> > > > > Upon a successful vote I will upload the cli & plugman archives to
> > > > > dist/ and publish them to npm. Cordova-ios will be uploaded to
> > > > > dist/platforms. I will then post the corresponding blog post.
> > > > >
> > > > > Voting will go on for a minimum of 24 hours.
> > > > >
> > > > > I vote +1.
> > > > >
> > > > > If people want individual vote threads for each item, let me know
> and
> > > > > I will create them instead of this thread.
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Bryan Higgins <br...@bryanhiggins.net>.
Right, but someone outside of this group stumbling upon the repo on GitHub
won't be able to use it unless they know to delete the shrinkwrap file. I'd
rather the process be a bit more cumbersome for us and preserve the
integrity of repo.
On Fri, Apr 4, 2014 at 1:11 PM, David Kemp <dr...@chromium.org> wrote:
> If we make the proposed change to the CLI package.json (change the plugman
> dependency to ">=0.21.0-rc"),
> then all that is required for testing is to delete the shrinkwrap file.
>
> That means a little less hackery to test the package that is being voted
> on.
>
> We have currently made those changes on the fly in the CI to get it working
> again.
>
>
>
> On Fri, Apr 4, 2014 at 12:57 PM, Bryan Higgins <bryan@bryanhiggins.net
> >wrote:
>
> > The other problem we face is the actual repo being unusable for a period
> of
> > time unless you know how to fiddle with package.json /
> npm-shrinkwrap.json.
> >
> > At the very least this should be pointed out on the README, but even that
> > doesn't seem friendly to potential contributors.
> >
> > I'm in favour of bumping the version number in CLI after the vote for
> cases
> > like this where we're releasing tools together. Those testing the CLI for
> > release can bump up the plugman version locally.
> >
> > Otherwise we should vote on plugman first, then update CLI and vote on
> > that...
> >
> >
> > On Fri, Apr 4, 2014 at 12:33 PM, Parashuram Narasimhan (MS OPEN TECH) <
> > panarasi@microsoft.com> wrote:
> >
> > > Can we also include the Windows Phone and Windows Platform,
> specifically
> > > for the following bugs/pull requests
> > >
> > > 1. Windows 8 - https://github.com/apache/cordova-windows/pull/20-
> > > This is more of a regression in case VS2013 is installed. With the
> build
> > > announcement yesterday, this could be higher priority. Note that this
> is
> > > not yet merged in.
> > > 2. Windows Phone 8 -
> https://github.com/apache/cordova-wp8/pull/28-
> > > This could affect the users using the emulator.
> > >
> > > -----Original Message-----
> > > From: Axel Nennker [mailto:ignisvulpis@gmail.com]
> > > Sent: Friday, April 4, 2014 9:21 AM
> > > To: dev
> > > Subject: Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0and
> > > cordova-ios@3.4.1
> > >
> > > Is there a chance to get the cb-2606 patch for launcer icon support
> into
> > a
> > > release some time no too far?
> > >
> > > Axel
> > > Am 04.04.2014 10:01 schrieb "Steven Gill" <st...@gmail.com>:
> > >
> > > > Please review and vote on the release of this cordova-cli,
> > > > cordova-plugman and cordova-ios release.
> > > >
> > > > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
> cordova-ios@3.4.1
> > > > have been published here:
> > > > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> > > > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
> > > >
> > > >
> > > > The packages were published from their corresponding git tags:
> > > > cordova-cli: 3.4.1-0.1.0 (b769a304be)
> > > > cordova-plugman: 0.21.0 (b2f3a130d3)
> > > > cordova-ios: 3.4.1 (a96d2360fa)
> > > >
> > > > Upon a successful vote I will upload the cli & plugman archives to
> > > > dist/ and publish them to npm. Cordova-ios will be uploaded to
> > > > dist/platforms. I will then post the corresponding blog post.
> > > >
> > > > Voting will go on for a minimum of 24 hours.
> > > >
> > > > I vote +1.
> > > >
> > > > If people want individual vote threads for each item, let me know and
> > > > I will create them instead of this thread.
> > > >
> > >
> >
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by David Kemp <dr...@chromium.org>.
If we make the proposed change to the CLI package.json (change the plugman
dependency to ">=0.21.0-rc"),
then all that is required for testing is to delete the shrinkwrap file.
That means a little less hackery to test the package that is being voted on.
We have currently made those changes on the fly in the CI to get it working
again.
On Fri, Apr 4, 2014 at 12:57 PM, Bryan Higgins <br...@bryanhiggins.net>wrote:
> The other problem we face is the actual repo being unusable for a period of
> time unless you know how to fiddle with package.json / npm-shrinkwrap.json.
>
> At the very least this should be pointed out on the README, but even that
> doesn't seem friendly to potential contributors.
>
> I'm in favour of bumping the version number in CLI after the vote for cases
> like this where we're releasing tools together. Those testing the CLI for
> release can bump up the plugman version locally.
>
> Otherwise we should vote on plugman first, then update CLI and vote on
> that...
>
>
> On Fri, Apr 4, 2014 at 12:33 PM, Parashuram Narasimhan (MS OPEN TECH) <
> panarasi@microsoft.com> wrote:
>
> > Can we also include the Windows Phone and Windows Platform, specifically
> > for the following bugs/pull requests
> >
> > 1. Windows 8 - https://github.com/apache/cordova-windows/pull/20 -
> > This is more of a regression in case VS2013 is installed. With the build
> > announcement yesterday, this could be higher priority. Note that this is
> > not yet merged in.
> > 2. Windows Phone 8 - https://github.com/apache/cordova-wp8/pull/28-
> > This could affect the users using the emulator.
> >
> > -----Original Message-----
> > From: Axel Nennker [mailto:ignisvulpis@gmail.com]
> > Sent: Friday, April 4, 2014 9:21 AM
> > To: dev
> > Subject: Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
> > cordova-ios@3.4.1
> >
> > Is there a chance to get the cb-2606 patch for launcer icon support into
> a
> > release some time no too far?
> >
> > Axel
> > Am 04.04.2014 10:01 schrieb "Steven Gill" <st...@gmail.com>:
> >
> > > Please review and vote on the release of this cordova-cli,
> > > cordova-plugman and cordova-ios release.
> > >
> > > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
> > > have been published here:
> > > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> > > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
> > >
> > >
> > > The packages were published from their corresponding git tags:
> > > cordova-cli: 3.4.1-0.1.0 (b769a304be)
> > > cordova-plugman: 0.21.0 (b2f3a130d3)
> > > cordova-ios: 3.4.1 (a96d2360fa)
> > >
> > > Upon a successful vote I will upload the cli & plugman archives to
> > > dist/ and publish them to npm. Cordova-ios will be uploaded to
> > > dist/platforms. I will then post the corresponding blog post.
> > >
> > > Voting will go on for a minimum of 24 hours.
> > >
> > > I vote +1.
> > >
> > > If people want individual vote threads for each item, let me know and
> > > I will create them instead of this thread.
> > >
> >
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Bryan Higgins <br...@bryanhiggins.net>.
The other problem we face is the actual repo being unusable for a period of
time unless you know how to fiddle with package.json / npm-shrinkwrap.json.
At the very least this should be pointed out on the README, but even that
doesn't seem friendly to potential contributors.
I'm in favour of bumping the version number in CLI after the vote for cases
like this where we're releasing tools together. Those testing the CLI for
release can bump up the plugman version locally.
Otherwise we should vote on plugman first, then update CLI and vote on
that...
On Fri, Apr 4, 2014 at 12:33 PM, Parashuram Narasimhan (MS OPEN TECH) <
panarasi@microsoft.com> wrote:
> Can we also include the Windows Phone and Windows Platform, specifically
> for the following bugs/pull requests
>
> 1. Windows 8 - https://github.com/apache/cordova-windows/pull/20 -
> This is more of a regression in case VS2013 is installed. With the build
> announcement yesterday, this could be higher priority. Note that this is
> not yet merged in.
> 2. Windows Phone 8 - https://github.com/apache/cordova-wp8/pull/28 -
> This could affect the users using the emulator.
>
> -----Original Message-----
> From: Axel Nennker [mailto:ignisvulpis@gmail.com]
> Sent: Friday, April 4, 2014 9:21 AM
> To: dev
> Subject: Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
> cordova-ios@3.4.1
>
> Is there a chance to get the cb-2606 patch for launcer icon support into a
> release some time no too far?
>
> Axel
> Am 04.04.2014 10:01 schrieb "Steven Gill" <st...@gmail.com>:
>
> > Please review and vote on the release of this cordova-cli,
> > cordova-plugman and cordova-ios release.
> >
> > cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
> > have been published here:
> > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
> >
> >
> > The packages were published from their corresponding git tags:
> > cordova-cli: 3.4.1-0.1.0 (b769a304be)
> > cordova-plugman: 0.21.0 (b2f3a130d3)
> > cordova-ios: 3.4.1 (a96d2360fa)
> >
> > Upon a successful vote I will upload the cli & plugman archives to
> > dist/ and publish them to npm. Cordova-ios will be uploaded to
> > dist/platforms. I will then post the corresponding blog post.
> >
> > Voting will go on for a minimum of 24 hours.
> >
> > I vote +1.
> >
> > If people want individual vote threads for each item, let me know and
> > I will create them instead of this thread.
> >
>
RE: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and
cordova-ios@3.4.1
Posted by "Parashuram Narasimhan (MS OPEN TECH)" <pa...@microsoft.com>.
Can we also include the Windows Phone and Windows Platform, specifically for the following bugs/pull requests
1. Windows 8 - https://github.com/apache/cordova-windows/pull/20 - This is more of a regression in case VS2013 is installed. With the build announcement yesterday, this could be higher priority. Note that this is not yet merged in.
2. Windows Phone 8 - https://github.com/apache/cordova-wp8/pull/28 - This could affect the users using the emulator.
-----Original Message-----
From: Axel Nennker [mailto:ignisvulpis@gmail.com]
Sent: Friday, April 4, 2014 9:21 AM
To: dev
Subject: Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Is there a chance to get the cb-2606 patch for launcer icon support into a release some time no too far?
Axel
Am 04.04.2014 10:01 schrieb "Steven Gill" <st...@gmail.com>:
> Please review and vote on the release of this cordova-cli,
> cordova-plugman and cordova-ios release.
>
> cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
> have been published here:
> *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
>
>
> The packages were published from their corresponding git tags:
> cordova-cli: 3.4.1-0.1.0 (b769a304be)
> cordova-plugman: 0.21.0 (b2f3a130d3)
> cordova-ios: 3.4.1 (a96d2360fa)
>
> Upon a successful vote I will upload the cli & plugman archives to
> dist/ and publish them to npm. Cordova-ios will be uploaded to
> dist/platforms. I will then post the corresponding blog post.
>
> Voting will go on for a minimum of 24 hours.
>
> I vote +1.
>
> If people want individual vote threads for each item, let me know and
> I will create them instead of this thread.
>
Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1
Posted by Axel Nennker <ig...@gmail.com>.
Is there a chance to get the cb-2606 patch for launcer icon support into a
release some time no too far?
Axel
Am 04.04.2014 10:01 schrieb "Steven Gill" <st...@gmail.com>:
> Please review and vote on the release of this cordova-cli, cordova-plugman
> and cordova-ios release.
>
> cordova-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1 have
> been published here:
> *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/
> <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>*
>
>
> The packages were published from their corresponding git tags:
> cordova-cli: 3.4.1-0.1.0 (b769a304be)
> cordova-plugman: 0.21.0 (b2f3a130d3)
> cordova-ios: 3.4.1 (a96d2360fa)
>
> Upon a successful vote I will upload the cli & plugman archives to dist/
> and publish them to npm. Cordova-ios will be uploaded to dist/platforms. I
> will then post the corresponding blog post.
>
> Voting will go on for a minimum of 24 hours.
>
> I vote +1.
>
> If people want individual vote threads for each item, let me know and I
> will create them instead of this thread.
>