You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2018/04/04 22:56:00 UTC
[jira] [Commented] (HBASE-15203) Reduce garbage created by
path.toString() during Checksum verification
[ https://issues.apache.org/jira/browse/HBASE-15203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426297#comment-16426297 ]
stack commented on HBASE-15203:
-------------------------------
Got committed w/ a misformatted JIRA ID
commit 2cf8af5bf1d501156cbb3b421cf75c1051ead7d9
Author: ramkrishna <ra...@gmail.com>
Date: Thu Feb 4 11:44:46 2016 +0530
HBASE-HBASE-15203 Reduce garbage created by path.toString() during
Checksum verification (Ram)
> Reduce garbage created by path.toString() during Checksum verification
> ----------------------------------------------------------------------
>
> Key: HBASE-15203
> URL: https://issues.apache.org/jira/browse/HBASE-15203
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
> Fix For: 1.3.0, 2.0.0
>
> Attachments: HBASE-15203.patch, HBASE-15203_1.patch, HBASE-15203_2.patch, HBASE-15203_branch-1.1.patch
>
>
> When we try to read a block we do checksum verification for which we need the file name in which the block belongs to. So we do Path.toString() every time. This seems to create around 163MB of char[] that is garbage collected in a simple scan run. It is also visible in writes but the impact is lesser. In overall write/read profile the top 2 factors are byte[] and char[]. This toString() can easily be avoided and reduce its share from the total. To make it more precise in 1 min of profiling, among the 1.8G of garbage created by StringBuilder.toString - this path.toString() was contributing around 3.5%. After the patch this is totally not there.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)