You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "wangyum (via GitHub)" <gi...@apache.org> on 2023/04/04 06:07:05 UTC
[GitHub] [parquet-mr] wangyum opened a new pull request, #1046: PARQUET-2263: Upgrade maven-shade-plugin to 3.4.1
wangyum opened a new pull request, #1046:
URL: https://github.com/apache/parquet-mr/pull/1046
Upgrade maven-shade-plugin to 3.4.1 to fix it does not work under Java 17:
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.1.1:shade (default) on project parquet-format-structures: Error creating shaded jar: null: IllegalArgumentException -> [Help 1]
```
Please see MSHADE-289 for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #1046: PARQUET-2263: Upgrade maven-shade-plugin to 3.4.1
Posted by "gszadovszky (via GitHub)" <gi...@apache.org>.
gszadovszky commented on PR #1046:
URL: https://github.com/apache/parquet-mr/pull/1046#issuecomment-1502925974
I am fine with this change as is but I guess, the shade plugin version comes from the apache parqent pom. Don't you think it would worth to upgrade that instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] wangyum commented on pull request #1046: PARQUET-2263: Upgrade maven-shade-plugin to 3.4.1
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #1046:
URL: https://github.com/apache/parquet-mr/pull/1046#issuecomment-1501466610
cc @gszadovszky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] Fokko merged pull request #1046: PARQUET-2263: Upgrade maven-shade-plugin to 3.4.1
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #1046:
URL: https://github.com/apache/parquet-mr/pull/1046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] Fokko commented on pull request #1046: PARQUET-2263: Upgrade maven-shade-plugin to 3.4.1
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #1046:
URL: https://github.com/apache/parquet-mr/pull/1046#issuecomment-1507485602
@wangyum and @gszadovszky I'm moving this forward if you're okay with that. Thanks @wangyum for opening this PR! 👏🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] Fokko commented on pull request #1046: PARQUET-2263: Upgrade maven-shade-plugin to 3.4.1
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #1046:
URL: https://github.com/apache/parquet-mr/pull/1046#issuecomment-1507034467
I ran into the same issue in https://github.com/apache/parquet-mr/pull/1052. Looks like the latest pom ships with `maven-shade-plugin` with `3.4.1`: https://repo1.maven.org/maven2/org/apache/apache/29/apache-29.pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org