[GitHub] [spark] viirya commented on a change in pull request #24358: [SPARK-27449] Move WholeStageCodegen.limitNotReachedCond class checks into separate methods.

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #24358: [SPARK-27449] Move WholeStageCodegen.limitNotReachedCond class checks into separate methods.
URL: https://github.com/apache/spark/pull/24358#discussion_r274908137
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
 ##########
 @@ -381,14 +381,18 @@ trait CodegenSupport extends SparkPlan {
    */
   def limitNotReachedChecks: Seq[String] = parent.limitNotReachedChecks
 
+  /**
+   * Check if the node is supposed to produce limit not reached checks.
+   */
+  protected def canCheckLimitNotReached: Boolean = children.isEmpty
+
   /**
    * A helper method to generate the data producing loop condition according to the
    * limit-not-reached checks.
    */
   final def limitNotReachedCond: String = {
     // InputAdapter is also a leaf node.
 
 Review comment:
   We can remove this comment now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org