You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/23 15:26:43 UTC
[GitHub] StefanRRichter commented on a change in pull request #6898:
[FLINK-10431] Extraction of scheduling-related code from SlotPool into
preliminary Scheduler
StefanRRichter commented on a change in pull request #6898: [FLINK-10431] Extraction of scheduling-related code from SlotPool into preliminary Scheduler
URL: https://github.com/apache/flink/pull/6898#discussion_r227445579
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -385,7 +386,8 @@ public void setInitialState(@Nullable JobManagerTaskRestore taskRestore) {
return scheduleForExecution(
resourceProvider,
allowQueued,
- LocationPreferenceConstraint.ANY);
+ LocationPreferenceConstraint.ANY,
+ null);
Review comment:
Point is that`null` and `emptySet` have different meanings here: `null` means it was not previously computed/provided and has tp be determined inside the execution. `emptySet` means it has been provided and the result was just empty. Overall, this whole construct should go away very soon when we move ro group scheduling.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services