You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2024/07/11 13:14:38 UTC
[Impala-ASF-CR] IMPALA-13196 (part2): fix query timeline link for imported queries
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21574
Change subject: IMPALA-13196 (part2): fix query timeline link for imported queries
......................................................................
IMPALA-13196 (part2): fix query timeline link for imported queries
This patch qualifies the query_link url for imported queries on the
/queries page.
Testing:
- Manully checked importing json profiles worked correctly with the
fix.
Change-Id: If53947c3b8429840990b361a936ba31e1df21522
---
M www/queries.tmpl
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/21574/1
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Surya Hebbar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21574
to look at the new patch set (#4).
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
IMPALA-13196 (part2): fix some urls in template files
This patch qualified some urls in template files.
Testing:
- Manully checked importing json profiles worked correctly with the
fix.
- Added new regex checks to test_knox_compatibility.
Change-Id: If53947c3b8429840990b361a936ba31e1df21522
---
M tests/webserver/test_web_pages.py
M www/queries.tmpl
M www/query_plan_text.tmpl
M www/query_profile.tmpl
M www/query_stmt.tmpl
5 files changed, 14 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/21574/4
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/21574/2/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/21574/2/tests/webserver/test_web_pages.py@901
PS2, Line 901: U
> flake8: W605 invalid escape sequence '\$'
Done
http://gerrit.cloudera.org:8080/#/c/21574/2/tests/webserver/test_web_pages.py@901
PS2, Line 901: .
> flake8: W605 invalid escape sequence '\.'
Done
http://gerrit.cloudera.org:8080/#/c/21574/2/tests/webserver/test_web_pages.py@901
PS2, Line 901: ]
> flake8: W605 invalid escape sequence '\s'
Done
http://gerrit.cloudera.org:8080/#/c/21574/2/tests/webserver/test_web_pages.py@901
PS2, Line 901: (
> flake8: W605 invalid escape sequence '\s'
Done
http://gerrit.cloudera.org:8080/#/c/21574/3/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/21574/3/tests/webserver/test_web_pages.py@898
PS3, Line 898: \
> flake8: W605 invalid escape sequence '\('
'\' is used to escape left parenthesis.
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 13 Aug 2024 12:42:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Surya Hebbar (Code Review)" <ge...@cloudera.org>.
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 14:37:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21574
to look at the new patch set (#3).
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
IMPALA-13196 (part2): fix some urls in template files
This patch qualified some urls in template files.
Testing:
- Manully checked importing json profiles worked correctly with the
fix.
- Added new regex checks to test_knox_compatibility.
Change-Id: If53947c3b8429840990b361a936ba31e1df21522
---
M tests/webserver/test_web_pages.py
M www/queries.tmpl
M www/query_plan_text.tmpl
M www/query_profile.tmpl
M www/query_stmt.tmpl
5 files changed, 14 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/21574/3
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21574/3/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/21574/3/tests/webserver/test_web_pages.py@898
PS3, Line 898: \
flake8: W605 invalid escape sequence '\('
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Aug 2024 12:39:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/21574/2/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/21574/2/tests/webserver/test_web_pages.py@898
PS2, Line 898: \
flake8: W605 invalid escape sequence '\('
http://gerrit.cloudera.org:8080/#/c/21574/2/tests/webserver/test_web_pages.py@901
PS2, Line 901: \
flake8: W605 invalid escape sequence '\.'
http://gerrit.cloudera.org:8080/#/c/21574/2/tests/webserver/test_web_pages.py@901
PS2, Line 901: \
flake8: W605 invalid escape sequence '\s'
http://gerrit.cloudera.org:8080/#/c/21574/2/tests/webserver/test_web_pages.py@901
PS2, Line 901: \
flake8: W605 invalid escape sequence '\s'
http://gerrit.cloudera.org:8080/#/c/21574/2/tests/webserver/test_web_pages.py@901
PS2, Line 901: \
flake8: W605 invalid escape sequence '\$'
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Aug 2024 12:31:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Surya Hebbar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21574
to look at the new patch set (#5).
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
IMPALA-13196 (part2): fix some urls in template files
This patch qualified some urls in template files.
Testing:
- Manully checked importing json profiles worked correctly with the
fix.
- Added new regex checks to test_knox_compatibility.
Change-Id: If53947c3b8429840990b361a936ba31e1df21522
---
M tests/webserver/test_web_pages.py
M www/queries.tmpl
M www/query_plan_text.tmpl
M www/query_profile.tmpl
M www/query_stmt.tmpl
5 files changed, 17 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/21574/5
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Surya Hebbar (Code Review)" <ge...@cloudera.org>.
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 14:37:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 6
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 20 Aug 2024 06:18:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16710/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 14:52:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13196 (part2): fix query timeline link for imported queries
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix query timeline link for imported queries
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16493/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Jul 2024 13:40:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21574/3/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/21574/3/tests/webserver/test_web_pages.py@898
PS3, Line 898: r
> Let's use Python’s raw string notation for regular expression patterns, e.g
Done
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 03:55:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16672/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 13 Aug 2024 13:09:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 6
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 20 Aug 2024 01:22:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 5:
(3 comments)
> Patch Set 4:
>
> (3 comments)
>
> Thanks for adding the tests, the patch seems fine. Only some nits from my side.
Thanks for your review!
http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_plan_text.tmpl
File www/query_plan_text.tmpl:
http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_plan_text.tmpl@29
PS4, Line 29: import
> nit: line too long..
Done
http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_profile.tmpl
File www/query_profile.tmpl:
http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_profile.tmpl@49
PS4, Line 49:
> nit: line too long
Done
http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_stmt.tmpl
File www/query_stmt.tmpl:
http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_stmt.tmpl@39
PS4, Line 39: import {inflateParseJSON}
> nit: line too long
Done
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 14:27:08 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
IMPALA-13196 (part2): fix some urls in template files
This patch qualified some urls in template files.
Testing:
- Manully checked importing json profiles worked correctly with the
fix.
- Added new regex checks to test_knox_compatibility.
Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Reviewed-on: http://gerrit.cloudera.org:8080/21574
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/webserver/test_web_pages.py
M www/queries.tmpl
M www/query_plan_text.tmpl
M www/query_profile.tmpl
M www/query_stmt.tmpl
5 files changed, 17 insertions(+), 8 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 7
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Surya Hebbar (Code Review)" <ge...@cloudera.org>.
Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 4:
(3 comments)
Thanks for adding the tests, the patch seems fine. Only some nits from my side.
http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_plan_text.tmpl
File www/query_plan_text.tmpl:
http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_plan_text.tmpl@29
PS4, Line 29: import
nit: line too long..
http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_profile.tmpl
File www/query_profile.tmpl:
http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_profile.tmpl@49
PS4, Line 49: from
nit: line too long
http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_stmt.tmpl
File www/query_stmt.tmpl:
http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_stmt.tmpl@39
PS4, Line 39: import {inflateParseJSON} from "{{ __common__.host-url }}/www/scripts/compression_util.js";
nit: line too long
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 03:40:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Surya Hebbar (Code Review)" <ge...@cloudera.org>.
Surya Hebbar has removed a vote on this change.
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Removed Code-Review+1 by Surya Hebbar <sh...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21574
to look at the new patch set (#2).
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
IMPALA-13196 (part2): fix some urls in template files
This patch qualified some urls in template files.
Testing:
- Manully checked importing json profiles worked correctly with the
fix.
- Added new regex checks to test_knox_compatibility.
Change-Id: If53947c3b8429840990b361a936ba31e1df21522
---
M tests/webserver/test_web_pages.py
M www/queries.tmpl
M www/query_plan_text.tmpl
M www/query_profile.tmpl
M www/query_stmt.tmpl
5 files changed, 14 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/21574/2
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10876/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 6
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 20 Aug 2024 01:22:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21574/3/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/21574/3/tests/webserver/test_web_pages.py@898
PS3, Line 898: \
> '\' is used to escape left parenthesis.
Let's use Python’s raw string notation for regular expression patterns, e.g.
r"(?<!{{ __common__.host-url }})(?<!make_url\(\")/www/.*"
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 02:08:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16678/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 04:25:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16671/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 13 Aug 2024 13:02:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13196 (part2): fix some urls in template files
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21574
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522
Gerrit-Change-Number: 21574
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Surya Hebbar <sh...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 20 Aug 2024 01:22:13 +0000
Gerrit-HasComments: No