[jira] [Commented] (GEODE-8498) Messages written to Netty channel sometimes delivered out of order

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200347#comment-17200347 ] 

ASF GitHub Bot commented on GEODE-8498:
---------------------------------------

sabbeyPivotal opened a new pull request #5533:
URL: https://github.com/apache/geode/pull/5533


   Error from .tcl tests:
   ```
   [err]: Mix SUBSCRIBE and PSUBSCRIBE in tests/unit/pubsub.tcl
   Expected 'pmessage foo.* foo.bar hello' to be equal to 'message foo.bar hello'
   
   *** [err]: Mix SUBSCRIBE and PSUBSCRIBE in tests/unit/pubsub.tcl
   Expected 'pmessage foo.* foo.bar hello' to be equal to 'message foo.bar hello'
   ```
   
   When writing responses to a Netty channel, the messages may get written out of order in the `writeAndFlush` call. To verify this bug, we used a single thread to call `writeAndFlush` and added logging right before calling `writeAndFlush` and after `afterWrite` in the callback listener. We saw the messages get logged in the proper order before `writeAndFlush` was called, but the messages were logged out of order in the callback listener and arrived in the wrong order on the client.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Messages written to Netty channel sometimes delivered out of order
> ------------------------------------------------------------------
>
>                 Key: GEODE-8498
>                 URL: https://issues.apache.org/jira/browse/GEODE-8498
>             Project: Geode
>          Issue Type: Bug
>          Components: redis
>            Reporter: Sarah Abbey
>            Priority: Major
>
> {code:java}
> [err]: Mix SUBSCRIBE and PSUBSCRIBE in tests/unit/pubsub.tcl
> Expected 'pmessage foo.* foo.bar hello' to be equal to 'message foo.bar hello'
> *** [err]: Mix SUBSCRIBE and PSUBSCRIBE in tests/unit/pubsub.tcl
> Expected 'pmessage foo.* foo.bar hello' to be equal to 'message foo.bar hello'
> {code}
> When writing responses to a Netty channel, the messages may get written out of order in the `writeAndFlush` call.  To verify this bug, we used a single thread to call `writeAndFlush` and added logging right before calling `writeAndFlush` and after `afterWrite` in the callback listener.  We saw the messages get logged in the proper order before `writeAndFlush` was called, but the messages were logged out of order in the callback listener and arrived in the wrong order on the client.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)