You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Jason Zhou <ja...@gmail.com> on 2024/05/29 15:37:57 UTC

Review Request 75018: [cgroups2] check bpf.h existence on docker images & fix docker files

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75018/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

All images built with the dockerfiles inside support/mesos-build should
have bpf.h inside /usr/include/linux. The dockerfile themselves were fixed
up to account for updated pip install urls, deprecated deadsnakes PPA for
Ubuntu 16.04, and curl misconfigurations for installing clang.


Diffs
-----

  support/mesos-build/centos-7.dockerfile 306102cf778ce68c7847ede1eb512f20a23ce136 
  support/mesos-build/ubuntu-16.04-arm.dockerfile 6a147394de51f635112cfeaaaff421f0b6f484e8 
  support/mesos-build/ubuntu-16.04.dockerfile 0606170ef4a404e67dea7571232660f9a5bb1b21 


Diff: https://reviews.apache.org/r/75018/diff/1/


Testing
-------


Thanks,

Jason Zhou

Re: Review Request 75018: [cgroups2] check bpf.h existence on docker images & fix docker files

Posted by Benjamin Mahler <bm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75018/#review226491
-----------------------------------------------------------


Ship it!




Looks like the commit needs to not mention bpf here after all? Looks more python related?

- Benjamin Mahler


On May 29, 2024, 3:37 p.m., Jason Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75018/
> -----------------------------------------------------------
> 
> (Updated May 29, 2024, 3:37 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> All images built with the dockerfiles inside support/mesos-build should
> have bpf.h inside /usr/include/linux. The dockerfile themselves were fixed
> up to account for updated pip install urls, deprecated deadsnakes PPA for
> Ubuntu 16.04, and curl misconfigurations for installing clang.
> 
> 
> Diffs
> -----
> 
>   support/mesos-build/centos-7.dockerfile 306102cf778ce68c7847ede1eb512f20a23ce136 
>   support/mesos-build/ubuntu-16.04-arm.dockerfile 6a147394de51f635112cfeaaaff421f0b6f484e8 
>   support/mesos-build/ubuntu-16.04.dockerfile 0606170ef4a404e67dea7571232660f9a5bb1b21 
> 
> 
> Diff: https://reviews.apache.org/r/75018/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Zhou
> 
>