[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33989: [SPARK-36676][SQL][BUILD] Create shaded Hive module and upgrade Guava version to 30.1.1-jre

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #33989:
URL: https://github.com/apache/spark/pull/33989#discussion_r712668134



##########
File path: assembly/pom.xml
##########
@@ -78,7 +78,11 @@
     <!--
       Because we don't shade dependencies anymore, we need to restore Guava to compile scope so
       that the libraries Spark depend on have it available. We'll package the version that Spark
-      uses (14.0.1) which is not the same as Hadoop dependencies, but works.
+      uses which is not the same as Hadoop dependencies, but works.
+
+      TODO: consider removing this. It's only required by a few libraries such as

Review comment:
       Could you file a JIRA and make this an IDed TODO like `TODO(SPARK-XXX)`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org