You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/05 08:45:29 UTC

[GitHub] [lucene-solr] donnerpeter commented on pull request #2296: LUCENE-9728: Hunspell: add a performance test

donnerpeter commented on pull request #2296:
URL: https://github.com/apache/lucene-solr/pull/2296#issuecomment-773887234


   `Dictionary` changes are intended, because the test parses the corpus based on the affix file `WORDCHARS` directive, which is parsed together with the other directives in `Dictionary`.
   
   JMH would indeed get rid of manual warmup and iteration, but complicate everything. And this isn't exactly a microbenchmark, so I too think the current approach is fine for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org