You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/10 18:42:42 UTC
[GitHub] [beam] vnorigoog opened a new pull request #11381: [BEAM-8889] add
gRPC suport in GCS connector (behind an experimental-flag)
vnorigoog opened a new pull request #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381
Revival of #10786 . Enables gRPC support in GCS connector. To fully enable it, experimental-flag "use_grpc_for_gcs" needs to be enabled (introduced in pr/11183)
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-612974074
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] vnorigoog commented on issue #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
vnorigoog commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-613056703
The errors seem to be unrelated to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-613655133
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-612220776
trigger tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] chamikaramj commented on issue #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-614195508
Finally passed :)
Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] vnorigoog opened a new pull request #11381: [BEAM-8889] add
gRPC suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
vnorigoog opened a new pull request #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381
Revival of #10786 . Enables gRPC support in GCS connector. To fully enable it, experimental-flag "use_grpc_for_gcs" needs to be enabled (introduced in pr/11183)
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] chamikaramj commented on issue #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-613171185
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-612973760
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] vnorigoog closed pull request #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
vnorigoog closed pull request #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-612974038
please retest this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik removed a comment on issue #11381: [BEAM-8889] add
gRPC suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
lukecwik removed a comment on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-612974038
please retest this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] chamikaramj commented on issue #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-614167961
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] vnorigoog commented on issue #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
vnorigoog commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-613057051
errors seem to be unrelated to this pR
(close button and comment button are way close to each other..darn)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] chamikaramj merged pull request #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
chamikaramj merged pull request #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-612983556
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik removed a comment on issue #11381: [BEAM-8889] add
gRPC suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
lukecwik removed a comment on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-612973760
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lukecwik commented on issue #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-612974334
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] vnorigoog commented on issue #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
vnorigoog commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-612708012
This now passes gradlew sdk:java:extensions:google-cloud-platform-core:check and test
PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] chamikaramj commented on issue #11381: [BEAM-8889] add gRPC
suport in GCS connector (behind an experimental-flag)
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on issue #11381: [BEAM-8889] add gRPC suport in GCS connector (behind an experimental-flag)
URL: https://github.com/apache/beam/pull/11381#issuecomment-613171121
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services