[GitHub] [incubator-pagespeed-ngx] jmarantz commented on issue #1660: Override webp lossless decision logic

[GitBox <gi...@apache.org>]

jmarantz commented on issue #1660: Override webp lossless decision logic
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1660#issuecomment-515783501
 
 
   Are you caching html in your cdn, out of curiosity?
   
   I think the behavior you desire is what pagespeed does, iirc. And you are
   right as well that we cannot determine which features of webp are available
   with just the accept header so we need to compromise between exploiting new
   features and breaking images on older browsers that do not support them,
   but send the accept header anyway.
   
   Probably the support level for various webp features has changed since this
   code was last updated, so we could possibly be more aggressive.
   
   Can you say explicitly what you are requesting in this issue?
   
   On Sun, Jul 28, 2019, 1:27 PM igmdvc <no...@github.com> wrote:
   
   > Hi,
   >
   > I have been doing some tests on IPRO to be able to convert from PNG to
   > webp lossless, but looking at the documentation it seems it is using the
   > user agent to determine that capability. As I plan to have a CDN, it is not
   > recommended to have Vary on User-Agent due to poor cache hit ratio.
   >
   > I was wondering if there is a way to configure pagespeed to force the
   > conversion to webp (lossless) just by detecting the webp support in the
   > accept header, as some of the test images I am using are not converted when
   > I use pagespeed AllowVaryOn Accept;. I know that this is not accurate
   > enough as older versions of certain browsers don´t support lossless.
   >
   > Thanks in advance.
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-pagespeed-ngx/issues/1660?email_source=notifications&email_token=AAO2IPKDEZGHCCSK4JWGPODQBXJGXA5CNFSM4IHNAKJKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HB5DQXQ>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAO2IPJTP665E5TJKSPKHHDQBXJGXANCNFSM4IHNAKJA>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services