You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/10/06 10:24:53 UTC
[GitHub] [couchdb] jjrodrig opened a new pull request #3193: 3x backport - final javascript tests ported to elixir
jjrodrig opened a new pull request #3193:
URL: https://github.com/apache/couchdb/pull/3193
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
This PR backports the last test ported to elixir and javascript target removal form the build process.
- Port users_db_security javascript tests to elixir #3190
- Proposal for removing javascript tests from main build process #3192
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
## Testing recommendations
```make check``` should pass without running js tests
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
## Related Issues or Pull Requests
#3190
#3192
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [X] Code is written and works correctly
- [X] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jjrodrig commented on pull request #3193: 3x backport - final javascript tests ported to elixir
Posted by GitBox <gi...@apache.org>.
jjrodrig commented on pull request #3193:
URL: https://github.com/apache/couchdb/pull/3193#issuecomment-704829508
Thanks @dottorblaster
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] garrensmith commented on pull request #3193: 3x backport - final javascript tests ported to elixir
Posted by GitBox <gi...@apache.org>.
garrensmith commented on pull request #3193:
URL: https://github.com/apache/couchdb/pull/3193#issuecomment-704913479
Woohoo thanks everyone
________________________________
From: iilyak <no...@github.com>
Sent: Wednesday, October 7, 2020 2:40:43 PM
To: apache/couchdb <co...@noreply.github.com>
Cc: garren smith <ga...@gmail.com>; Mention <me...@noreply.github.com>
Subject: Re: [apache/couchdb] 3x backport - final javascript tests ported to elixir (#3193)
Thank you all who was involved in porting the tests. Awesome job 💯 🥇. I hope I didn't miss anyone.
* @dottorblaster<https://github.com/dottorblaster>
* @jjrodrig<https://github.com/jjrodrig>
* @tonysun83<https://github.com/tonysun83>
* @atrauzzi<https://github.com/atrauzzi>
* @leo-pires<https://github.com/leo-pires>
* @davisp<https://github.com/davisp>
* @jaydoane<https://github.com/jaydoane>
* @nickva<https://github.com/nickva>
* @garrensmith<https://github.com/garrensmith>
* @eiri<https://github.com/eiri>
* @van-mronov<https://github.com/van-mronov>
* @wohali<https://github.com/wohali>
* @chewbranca<https://github.com/chewbranca>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/apache/couchdb/pull/3193#issuecomment-704907693>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AABL2AVT5ZFOYU76NACIP6LSJROUXANCNFSM4SF2PBFQ>.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] jjrodrig merged pull request #3193: 3x backport - final javascript tests ported to elixir
Posted by GitBox <gi...@apache.org>.
jjrodrig merged pull request #3193:
URL: https://github.com/apache/couchdb/pull/3193
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] iilyak commented on pull request #3193: 3x backport - final javascript tests ported to elixir
Posted by GitBox <gi...@apache.org>.
iilyak commented on pull request #3193:
URL: https://github.com/apache/couchdb/pull/3193#issuecomment-704907693
Thank you all who was involved in porting the tests. Awesome job 💯 🥇. I hope I didn't miss anyone.
- @dottorblaster
- @jjrodrig
- @tonysun83
- @atrauzzi
- @leo-pires
- @davisp
- @jaydoane
- @nickva
- @garrensmith
- @eiri
- @van-mronov
- @wohali
- @chewbranca
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org