You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/26 08:58:12 UTC
[GitHub] [pulsar] shibd opened a new pull request, #16228: [improve][java client] No need print exception stack when DLQ send failed.
shibd opened a new pull request, #16228:
URL: https://github.com/apache/pulsar/pull/16228
### Motivation
No need to print an exception stack when DLQ send failed. Because sending DLQ fails, it will be re-delivered.
### Modifications
- Only print exception message instead of exception stack.
### Documentation
- [x] `doc-not-needed`
(Please explain why)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16228: [improve][java client] No need print exception stack when DLQ send failed.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on code in PR #16228:
URL: https://github.com/apache/pulsar/pull/16228#discussion_r908633381
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -2001,15 +2001,15 @@ private CompletableFuture<Boolean> processPossibleToDLQ(MessageIdImpl messageId)
acknowledgeAsync(finalMessageId).whenComplete((v, ex) -> {
if (ex != null) {
log.warn("[{}] [{}] [{}] Failed to acknowledge the message {} of the original"
- + " topic but send to the DLQ successfully.",
- topicName, subscription, consumerName, finalMessageId, ex);
+ + " topic but send to the DLQ successfully {}.",
+ topicName, subscription, consumerName, finalMessageId, ex.getMessage());
Review Comment:
Oh sorry, we should only skip the stacktrace for QueueFullException, not for all exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #16228: [improve][java client] No need print exception stack when DLQ send failed.
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16228:
URL: https://github.com/apache/pulsar/pull/16228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16228: [improve][java client] No need print exception stack when DLQ send failed.
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16228:
URL: https://github.com/apache/pulsar/pull/16228#issuecomment-1166884825
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16228: [improve][java client] No need print exception stack when DLQ send failed.
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16228:
URL: https://github.com/apache/pulsar/pull/16228#issuecomment-1169396292
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on a diff in pull request #16228: [improve][java client] No need print exception stack when DLQ send failed.
Posted by GitBox <gi...@apache.org>.
shibd commented on code in PR #16228:
URL: https://github.com/apache/pulsar/pull/16228#discussion_r908657187
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -2001,15 +2001,15 @@ private CompletableFuture<Boolean> processPossibleToDLQ(MessageIdImpl messageId)
acknowledgeAsync(finalMessageId).whenComplete((v, ex) -> {
if (ex != null) {
log.warn("[{}] [{}] [{}] Failed to acknowledge the message {} of the original"
- + " topic but send to the DLQ successfully.",
- topicName, subscription, consumerName, finalMessageId, ex);
+ + " topic but send to the DLQ successfully {}.",
+ topicName, subscription, consumerName, finalMessageId, ex.getMessage());
Review Comment:
Thanks for the careful review, Fixed. Please review again, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #16228: [improve][java client] No need print exception stack when DLQ send failed.
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16228:
URL: https://github.com/apache/pulsar/pull/16228#issuecomment-1166506664
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org