You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Christopher Tubbs (JIRA)" <ji...@apache.org> on 2019/06/11 04:26:00 UTC

[jira] [Resolved] (ACCUMULO-3519) Unused AccumuloSecurityException constructor

     [ https://issues.apache.org/jira/browse/ACCUMULO-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christopher Tubbs resolved ACCUMULO-3519.
-----------------------------------------
       Resolution: Won't Fix
    Fix Version/s:     (was: 2.0.0)

This is an old issue, and much has changed since this issue was created. If this is still an issue, please consider opening a new issue at https://github.com/apache/accumulo/issues

> Unused AccumuloSecurityException constructor
> --------------------------------------------
>
>                 Key: ACCUMULO-3519
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3519
>             Project: Accumulo
>          Issue Type: Sub-task
>            Reporter: Christopher Tubbs
>            Priority: Major
>
> AccumuloSecurityException has a public constructor which is completely unused. I don't know if we should consider constructors of exceptions "public API", but they are defined as such in the README, so a strict interpretation is that they are.
> The unused constructor in question is:
> {code}public AccumuloSecurityException(final String user, final SecurityErrorCode errorcode, final String tableInfo) { ... }{code}
> This class also uses thrift objects in its constructors, which we don't consider public API, so either we should also consider constructors of exceptions to be *not* public API (in which case, we can just delete the unused constructor), or we should consider the use of thrift objects bugs.
> If these constructors are public API, they should have tests and we shouldn't have any unused (because they would minimally be referenced in tests).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)