You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/01/23 10:58:31 UTC
[GitHub] zeppelin pull request #2740: [ZEPPELIN-3185] Add profiles for adding depende...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2740
[ZEPPELIN-3185] Add profiles for adding dependencies for Hive and Phoenix
### What is this PR for?
This PR adds profiles for adding dependencies for Hive and Phoenix
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* [ZEPPELIN-3185](https://issues.apache.org/jira/browse/ZEPPELIN-3185)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3185
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2740.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2740
----
commit 99eafdecb7b04440f0546adfdfd46f51e8581a41
Author: Prabhjyot Singh <pr...@...>
Date: 2018-01-23T10:55:59Z
add profile for adding dependencies for hive and phoenix
Change-Id: I3ddfa2af7b7f6742a49f615ba4af5f4cd06478ff
----
---
[GitHub] zeppelin pull request #2740: [ZEPPELIN-3185] Add profiles for adding depende...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2740
---
[GitHub] zeppelin issue #2740: [ZEPPELIN-3185] Add profiles for adding dependencies f...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2740
Thanks for the review will merge this if no more discussion.
---
[GitHub] zeppelin issue #2740: [ZEPPELIN-3185] Add profiles for adding dependencies f...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2740
I believe `zeppelin-jdbc` depends only on `zeppelin-interpreter`, and not on `zeppelin-zengine`, so it should be safe.
---
[GitHub] zeppelin issue #2740: [ZEPPELIN-3185] Add profiles for adding dependencies f...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2740
No I think it should be disabled by default, it may increase the size of binary.
---
[GitHub] zeppelin issue #2740: [ZEPPELIN-3185] Add profiles for adding dependencies f...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2740
LGTM
---
[GitHub] zeppelin issue #2740: [ZEPPELIN-3185] Add profiles for adding dependencies f...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2740
I guess it could make sense if people want to use jdbc alone (and that is Hadoop 2 set of jdbc)
Would it confict if zengine or something is hadoop2 and then the interpreter is hadoop3?
---
[GitHub] zeppelin issue #2740: [ZEPPELIN-3185] Add profiles for adding dependencies f...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2740
@zjffdu Please help review this.
---
[GitHub] zeppelin issue #2740: [ZEPPELIN-3185] Add profiles for adding dependencies f...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2740
Thanks for the review will merge this if no more discussion.
---
[GitHub] zeppelin issue #2740: [ZEPPELIN-3185] Add profiles for adding dependencies f...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2740
great
---