You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/17 15:06:55 UTC

[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #3482: Convert more cross joins to inner joins (Address performance/execution plan of TPCH query 19)

Dandandan commented on code in PR #3482:
URL: https://github.com/apache/arrow-datafusion/pull/3482#discussion_r973595592


##########
datafusion/core/src/execution/context.rs:
##########
@@ -1437,6 +1438,7 @@ impl SessionState {
             Arc::new(ScalarSubqueryToJoin::new()),
             Arc::new(SubqueryFilterToJoin::new()),
             Arc::new(EliminateFilter::new()),
+            Arc::new(ReduceCrossJoin::new()),

Review Comment:
   Gradient descent itself is not directly possible - as that needs differentiable functions / cost functions.
   
   But other (black box) optimization algorithms are possible given some cost function. I think the art of writing good cost functions for queries however can be quite an art 🎨



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org