You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/12 04:45:07 UTC
[GitHub] [superset] elyzov opened a new pull request #16219: feat: added extraEnvRaw variable to load values from other secrets
elyzov opened a new pull request #16219:
URL: https://github.com/apache/superset/pull/16219
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Added ability to load additional environment variables from third-party secrets, e.g. load DB password from zalando operator secret.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #16219: feat: added extraEnvRaw variable to load values from other secrets in Helm chart
Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #16219:
URL: https://github.com/apache/superset/pull/16219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #16219: feat: added extraEnvRaw variable to load values from other secrets in Helm chart
Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #16219:
URL: https://github.com/apache/superset/pull/16219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a change in pull request #16219: feat: added extraEnvRaw variable to load values from other secrets in Helm chart
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #16219:
URL: https://github.com/apache/superset/pull/16219#discussion_r707808282
##########
File path: helm/superset/values.yaml
##########
@@ -54,11 +54,21 @@ extraEnv: {}
# GUNICORN_TIMEOUT: 300
- # OAUTH_HOME_DOMAIN: ..
+ # OAUTH_HOME_DOMAIN: ..
# # If a whitelist is not set, any address that can use your OAuth2 endpoint will be able to login.
# # this includes any random Gmail address if your OAuth2 Web App is set to External.
# OAUTH_WHITELIST_REGEX: ...
+## Extra environment variables in RAW format that will be passed into pods
+##
+extraEnvRaw: {}
Review comment:
I think the default should be set to empty here. Using `{}` as the default is a little misleading as it's a dictionary type whereas we need a list instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] elyzov commented on pull request #16219: feat: added extraEnvRaw variable to load values from other secrets in Helm chart
Posted by GitBox <gi...@apache.org>.
elyzov commented on pull request #16219:
URL: https://github.com/apache/superset/pull/16219#issuecomment-927623053
@craig-rueda Ok, thanks, I've just bumped a version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] elyzov commented on pull request #16219: feat: added extraEnvRaw variable to load values from other secrets in Helm chart
Posted by GitBox <gi...@apache.org>.
elyzov commented on pull request #16219:
URL: https://github.com/apache/superset/pull/16219#issuecomment-929125738
@craig-rueda seems like now it's all right, can we merge the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] elyzov commented on pull request #16219: feat: added extraEnvRaw variable to load values from other secrets in Helm chart
Posted by GitBox <gi...@apache.org>.
elyzov commented on pull request #16219:
URL: https://github.com/apache/superset/pull/16219#issuecomment-929125738
@craig-rueda seems like now it's all right, can we merge the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] elyzov commented on pull request #16219: feat: added extraEnvRaw variable to load values from other secrets in Helm chart
Posted by GitBox <gi...@apache.org>.
elyzov commented on pull request #16219:
URL: https://github.com/apache/superset/pull/16219#issuecomment-921545592
@eschutho tell me please, what should I do next to merge the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #16219: feat: added extraEnvRaw variable to load values from other secrets in Helm chart
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on pull request #16219:
URL: https://github.com/apache/superset/pull/16219#issuecomment-921958576
Looks like you need a version bump
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] elyzov commented on a change in pull request #16219: feat: added extraEnvRaw variable to load values from other secrets in Helm chart
Posted by GitBox <gi...@apache.org>.
elyzov commented on a change in pull request #16219:
URL: https://github.com/apache/superset/pull/16219#discussion_r707960015
##########
File path: helm/superset/values.yaml
##########
@@ -54,11 +54,21 @@ extraEnv: {}
# GUNICORN_TIMEOUT: 300
- # OAUTH_HOME_DOMAIN: ..
+ # OAUTH_HOME_DOMAIN: ..
# # If a whitelist is not set, any address that can use your OAuth2 endpoint will be able to login.
# # this includes any random Gmail address if your OAuth2 Web App is set to External.
# OAUTH_WHITELIST_REGEX: ...
+## Extra environment variables in RAW format that will be passed into pods
+##
+extraEnvRaw: {}
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org