You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2018/08/25 09:29:52 UTC
[GitHub] storm pull request #2813: STORM-3204: Upgrade Metrics to 4.0.3
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2813
STORM-3204: Upgrade Metrics to 4.0.3
https://issues.apache.org/jira/browse/STORM-3204
The Metrics project has a BOM now, so we don't have to specify versions for each module or transitive dependency.
I used the one liner described here https://grep.codeconsult.ch/2010/07/08/list-all-your-maven-dependencies/ to get the list of dependencies for the entire project.
```
13c13
< ch.qos.logback:logback-classic:jar:1.1.2
---
> ch.qos.logback:logback-classic:jar:1.2.3
184a185
> com.rabbitmq:amqp-client:jar:4.4.1
208c209
< Finished at: 2018-08-25T09:00:50Z
---
> Finished at: 2018-08-25T08:57:14Z
226,236c227,237
< io.dropwizard.metrics:metrics-annotation:jar:4.0.2
< io.dropwizard.metrics:metrics-core:jar:3.1.0
< io.dropwizard.metrics:metrics-graphite:jar:3.1.0
< io.dropwizard.metrics:metrics-healthchecks:jar:4.0.2
< io.dropwizard.metrics:metrics-jersey2:jar:4.0.2
< io.dropwizard.metrics:metrics-jetty9:jar:4.0.2
< io.dropwizard.metrics:metrics-jmx:jar:4.0.2
< io.dropwizard.metrics:metrics-json:jar:4.0.2
< io.dropwizard.metrics:metrics-jvm:jar:4.0.2
< io.dropwizard.metrics:metrics-logback:jar:4.0.2
< io.dropwizard.metrics:metrics-servlets:jar:4.0.2
---
> io.dropwizard.metrics:metrics-annotation:jar:4.0.3
> io.dropwizard.metrics:metrics-core:jar:4.0.3
> io.dropwizard.metrics:metrics-graphite:jar:4.0.3
> io.dropwizard.metrics:metrics-healthchecks:jar:4.0.3
> io.dropwizard.metrics:metrics-jersey2:jar:4.0.3
> io.dropwizard.metrics:metrics-jetty9:jar:4.0.3
> io.dropwizard.metrics:metrics-jmx:jar:4.0.3
> io.dropwizard.metrics:metrics-json:jar:4.0.3
> io.dropwizard.metrics:metrics-jvm:jar:4.0.3
> io.dropwizard.metrics:metrics-logback:jar:4.0.3
> io.dropwizard.metrics:metrics-servlets:jar:4.0.3
386a388
> org.apache.httpcomponents:httpasyncclient:jar:4.1.3
```
The new amqp-client dependency is through metrics-graphite. It used to be optional in 3.1.0, now it isn't in 4.0.3. The httpasyncclient is in storm-elasticsearch, I'm not sure why it shows as new rather than changed (previous version was 4.1.2). The rest are just version changes for the metrics dependencies.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-3204
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2813.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2813
----
commit a91c0e84b964c01417e3a496422fd68f8bf6adca
Author: Stig Rohde Døssing <sr...@...>
Date: 2018-08-25T08:57:26Z
STORM-3204: Upgrade Metrics to 4.0.3
----
---
[GitHub] storm issue #2813: STORM-3204: Upgrade Metrics to 4.0.3
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2813
Need to look at this a bit more, there's an incompatibility with Cassandra's version of Metrics.
---
[GitHub] storm pull request #2813: STORM-3204: Upgrade Metrics to 4.0.3
Posted by srdo <gi...@git.apache.org>.
Github user srdo closed the pull request at:
https://github.com/apache/storm/pull/2813
---