[GitHub] [nifi-fds] rfellows commented on a change in pull request #14: [WIP] NIFI-6212 introduce webpack, ES6, TS, linting, dev build watch

[GitBox <gi...@apache.org>]

rfellows commented on a change in pull request #14: [WIP] NIFI-6212 introduce webpack, ES6, TS, linting, dev build watch
URL: https://github.com/apache/nifi-fds/pull/14#discussion_r281332994
 
 

 ##########
 File path: platform/core/common/styles/_basicElements.scss
 ##########
 @@ -19,56 +19,56 @@
   font-family: 'Roboto';
   font-style: normal;
   font-weight: 300;
-  src: local("Roboto Light"), local("Roboto-Light"), url("../../../../../roboto-fontface/fonts/roboto/Roboto-Light.ttf") format("truetype");
+  src: local("Roboto Light"), local("Roboto-Light"), url("../../../../../node_modules/roboto-fontface/fonts/roboto/Roboto-Light.woff2") format("woff2");
 
 Review comment:
   really should parameterize the folder location to the roboto fonts to allow consumers of nifi-fds the ability to provide their folder in an override.
   
   define it somewhere...
   ```
   $fds-font-path:    "../../../../../node_modules/roboto-fontface/fonts/roboto" !default;
   ```
   
   then use it here:
   
   ```
   src: local("Roboto Light"), local("Roboto-Light"), url("#{fds-font-path}/Roboto-Light.woff2") format("woff2");
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services