You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by pnowojski <gi...@git.apache.org> on 2017/08/10 15:20:07 UTC
[GitHub] flink pull request #4515: Logging improvements in NetworkFailuresProxy
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/4515
Logging improvements in NetworkFailuresProxy
This PR consists of only one minor bug fix and one improvement in logging of `NetworkFailuresProxy` class used in tests. It's highly unlikely that it will brake anything. Change is covered by existing `NetworkFailuresProxyTest`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pnowojski/flink misc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4515.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4515
----
commit 3ebe2038caf0d0e4d3522f53395bb41081d978ad
Author: Piotr Nowojski <pi...@gmail.com>
Date: 2017-08-09T14:26:08Z
[hotfix][misc] Fix logging of local port in NetworkFailuresProxy
Previously if localPort was set 0, actually obtained/bind port was not
logged anywhere. Now we print local port after binding.
commit aed0f5c9d79b82897ee227093e8fde8ebd10b593
Author: Piotr Nowojski <pi...@gmail.com>
Date: 2017-08-10T08:29:17Z
[hotfix][misc] More verbose logging in NetworkFailuresProxy
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4515: Logging improvements in NetworkFailuresProxy
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4515#discussion_r133231386
--- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/networking/NetworkFailureHandler.java ---
@@ -92,7 +92,14 @@ public void channelOpen(ChannelHandlerContext context, ChannelStateEvent event)
final Channel sourceChannel = event.getChannel();
sourceChannel.setReadable(false);
- if (blocked.get()) {
+ boolean isBlocked = blocked.get();
+ LOG.debug("Attempt to open proxy channel from [%s] to [%s:%s] in state [blocked = %s]",
--- End diff --
Sorry I didn't fix this nit, I was OoO :( thanks for merging!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4515: Logging improvements in NetworkFailuresProxy
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4515#discussion_r132754963
--- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/networking/NetworkFailureHandler.java ---
@@ -92,7 +92,14 @@ public void channelOpen(ChannelHandlerContext context, ChannelStateEvent event)
final Channel sourceChannel = event.getChannel();
sourceChannel.setReadable(false);
- if (blocked.get()) {
+ boolean isBlocked = blocked.get();
+ LOG.debug("Attempt to open proxy channel from [%s] to [%s:%s] in state [blocked = %s]",
--- End diff --
yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4515: Logging improvements in NetworkFailuresProxy
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4515#discussion_r132630941
--- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/networking/NetworkFailureHandler.java ---
@@ -92,7 +92,14 @@ public void channelOpen(ChannelHandlerContext context, ChannelStateEvent event)
final Channel sourceChannel = event.getChannel();
sourceChannel.setReadable(false);
- if (blocked.get()) {
+ boolean isBlocked = blocked.get();
+ LOG.debug("Attempt to open proxy channel from [%s] to [%s:%s] in state [blocked = %s]",
--- End diff --
Is there a particular reason why you use `%s` instead of `{}` (the latter being more common)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4515: Logging improvements in NetworkFailuresProxy
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4515
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4515: Logging improvements in NetworkFailuresProxy
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4515#discussion_r132638260
--- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/networking/NetworkFailureHandler.java ---
@@ -92,7 +92,14 @@ public void channelOpen(ChannelHandlerContext context, ChannelStateEvent event)
final Channel sourceChannel = event.getChannel();
sourceChannel.setReadable(false);
- if (blocked.get()) {
+ boolean isBlocked = blocked.get();
+ LOG.debug("Attempt to open proxy channel from [%s] to [%s:%s] in state [blocked = %s]",
--- End diff --
No, probably just my `C++` habits :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4515: Logging improvements in NetworkFailuresProxy
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4515
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---