You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/04 04:22:33 UTC
[GitHub] [pulsar] rdhabalia opened a new pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
rdhabalia opened a new pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444
### Motivation
we need an api to get list of topics under a specific bundle which will be useful when broker is having load issue with specific topics/bundle and we can find out appropriate list of topics belong to the specific bundle.
### Modification
- added rest api param to get list of topics filtering by bundle
- add cli option to pass bundle with list-topics command
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-721902610
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#discussion_r519397745
##########
File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
##########
@@ -217,27 +229,6 @@ public void failed(Throwable throwable) {
}
}
- @Override
- public CompletableFuture<List<String>> getListInBundleAsync(String namespace, String bundleRange) {
Review comment:
it looks like that we are changing the behaviour of this method.
two questions:
- will be the new admin client (2.7.0) compatible with 2.6.x ?
- was this method working before this change ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#discussion_r524868285
##########
File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java
##########
@@ -217,27 +229,6 @@ public void failed(Throwable throwable) {
}
}
- @Override
- public CompletableFuture<List<String>> getListInBundleAsync(String namespace, String bundleRange) {
Review comment:
I think this will not break the compatibility since this will not change the interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-731491271
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-733190676
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-783150300
@rdhabalia Could you please rebase the code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-735527843
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap closed pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
zymap closed pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-722259854
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-730094232
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-721755813
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-722117671
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] rdhabalia commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
rdhabalia commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-721539105
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-723570657
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-730213431
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-785513474
Because this PR is opened for a long time. I will close this PR. Feel free to reopen it if you needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-730523946
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-726438297
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-728709267
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-730344714
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-731080694
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-784178255
Hi, @rdhabalia. Do we still need this? If we don't need this I will close this PR and remove the `release/2.7.1` label.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8444: [Pulsar-Broker] fetch list of topics under a namespace bundle
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8444:
URL: https://github.com/apache/pulsar/pull/8444#issuecomment-728691011
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org